From 0065c6023a617249e810d593dab42a8428f689a9 Mon Sep 17 00:00:00 2001 From: Guido Casati Date: Thu, 3 Apr 2025 22:30:29 +0200 Subject: [PATCH] Remove unconsistent check in rrc_gNB_process_NGAP_PDUSESSION_RELEASE_COMMAND Leading to clang error: /oai-ran/openair2/RRC/NR/rrc_gNB_NGAP.c:1329:37: error: result of comparison of constant 256 with expression of type 'uint8_t' (aka 'unsigned char') is always false [-Werror,-Wtautological-constant-out-of-range-compare] The value comes from the decoding of: ie->value.choice.PDUSessionResourceToReleaseListRelCmd.list.count --- openair2/RRC/NR/rrc_gNB_NGAP.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/openair2/RRC/NR/rrc_gNB_NGAP.c b/openair2/RRC/NR/rrc_gNB_NGAP.c index d7d7b8f360..99e657aa4d 100644 --- a/openair2/RRC/NR/rrc_gNB_NGAP.c +++ b/openair2/RRC/NR/rrc_gNB_NGAP.c @@ -1327,10 +1327,6 @@ int rrc_gNB_process_NGAP_PDUSESSION_RELEASE_COMMAND(MessageDef *msg_p, instance_ uint32_t gNB_ue_ngap_id; ngap_pdusession_release_command_t *cmd = &NGAP_PDUSESSION_RELEASE_COMMAND(msg_p); gNB_ue_ngap_id = cmd->gNB_ue_ngap_id; - if (cmd->nb_pdusessions_torelease > NGAP_MAX_PDU_SESSION) { - LOG_E(NR_RRC, "incorrect number of pdu session do release %d\n", cmd->nb_pdusessions_torelease); - return -1; - } gNB_RRC_INST *rrc = RC.nrrrc[instance]; rrc_gNB_ue_context_t *ue_context_p = rrc_gNB_get_ue_context(rrc, gNB_ue_ngap_id);