From fcb16521f355f6177b5886fee87c587720f7643a Mon Sep 17 00:00:00 2001 From: Raphael Defosseux Date: Wed, 13 Feb 2019 13:42:59 +0100 Subject: [PATCH 1/4] Hot fix on UE configuration module proposed by Xenofon Foukas Signed-off-by: Raphael Defosseux --- targets/RT/USER/lte-uesoftmodem.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/targets/RT/USER/lte-uesoftmodem.c b/targets/RT/USER/lte-uesoftmodem.c index a3aa003662..d93269ae1c 100644 --- a/targets/RT/USER/lte-uesoftmodem.c +++ b/targets/RT/USER/lte-uesoftmodem.c @@ -693,9 +693,13 @@ int main( int argc, char **argv ) { #if defined (XFORMS) int ret; #endif + configmodule_interface_t *config_mod; + start_background_system(); - if ( load_configmodule(argc,argv,CONFIG_ENABLECMDLINEONLY) == NULL) { + config_mod = load_configmodule(argc, argv, CONFIG_ENABLECMDLINEONLY); + + if (config_mod == NULL) { exit_fun("[SOFTMODEM] Error, configuration module init failed\n"); } @@ -811,7 +815,7 @@ int main( int argc, char **argv ) { } else init_openair0(frame_parms[0],(int)rx_gain[0][0]); if (simL1flag==1) { - AssertFatal(NULL!=load_configmodule(argc,argv,CONFIG_ENABLECMDLINEONLY), + AssertFatal(NULL!=config_mod, "[SOFTMODEM] Error, configuration module init failed\n"); RCConfig_sim(); } From 7c63d0d5512f617170f31830eb4bfb1503a15db3 Mon Sep 17 00:00:00 2001 From: Boris Djalal Date: Wed, 13 Feb 2019 15:56:10 +0100 Subject: [PATCH 2/4] Proposal of Francois Taburet Signed-off-by: Boris Djalal --- targets/RT/USER/lte-uesoftmodem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/targets/RT/USER/lte-uesoftmodem.c b/targets/RT/USER/lte-uesoftmodem.c index d93269ae1c..13cc859414 100644 --- a/targets/RT/USER/lte-uesoftmodem.c +++ b/targets/RT/USER/lte-uesoftmodem.c @@ -815,8 +815,6 @@ int main( int argc, char **argv ) { } else init_openair0(frame_parms[0],(int)rx_gain[0][0]); if (simL1flag==1) { - AssertFatal(NULL!=config_mod, - "[SOFTMODEM] Error, configuration module init failed\n"); RCConfig_sim(); } From e85bd103077d7e3b6501f33c7c4c23bec7c27c9c Mon Sep 17 00:00:00 2001 From: Raphael Defosseux Date: Tue, 12 Feb 2019 16:33:30 +0100 Subject: [PATCH 3/4] CI: trying to improve reliability of L2 sim -- checking if oip1 interface has an IP address before pinging Signed-off-by: Raphael Defosseux (cherry picked from commit a4dd3fdb0758483afb41f416ba597a67152ec74a) Signed-off-by: Raphael Defosseux --- ci-scripts/runTestOnVM.sh | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/ci-scripts/runTestOnVM.sh b/ci-scripts/runTestOnVM.sh index 7ff04e23f8..208381a944 100755 --- a/ci-scripts/runTestOnVM.sh +++ b/ci-scripts/runTestOnVM.sh @@ -604,10 +604,34 @@ function start_l2_sim_ue { if [ $i -lt 50 ] then UE_SYNC=0 - echo "L2-SIM UE is NOT sync'ed w/eNB" + echo "L2-SIM UE is NOT sync'ed w/ eNB" + return else UE_SYNC=1 - echo "L2-SIM UE is sync'ed w/eNB" + echo "L2-SIM UE is sync'ed w/ eNB" + fi + # Checking oip1 interface has now an IP address + i="0" + echo "ifconfig oip1 | egrep -c \"inet addr\"" > $1 + while [ $i -lt 10 ] + do + sleep 5 + CONNECTED=`ssh -o StrictHostKeyChecking=no ubuntu@$LOC_VM_IP_ADDR < $1` + if [ $CONNECTED -eq 1 ] + then + i="100" + else + i=$[$i+1] + fi + done + rm $1 + if [ $i -lt 50 ] + then + UE_SYNC=0 + echo "L2-SIM UE oip1 is NOT sync'ed w/ EPC" + else + UE_SYNC=1 + echo "L2-SIM UE oip1 is sync'ed w/ EPC" fi sleep 10 } From 28a1fcde2e03e0034d8c65bbed225cdbc3e56335 Mon Sep 17 00:00:00 2001 From: Raphael Defosseux Date: Thu, 14 Feb 2019 10:10:59 +0100 Subject: [PATCH 4/4] Adding comment in release notes Signed-off-by: Raphael Defosseux --- README.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/README.txt b/README.txt index aec938c0d3..33c0df9d8d 100644 --- a/README.txt +++ b/README.txt @@ -61,3 +61,4 @@ v1.0.0 -> January 2019. This version first implements the architectural split de S1-flex has been introduced. New tools: config library, telnet server, ... A lot of bugfixes and a proper automated Continuous Integration process validates contributions. +v1.0.1 -> February 2019: Bug fix for the UE L1 simulator.