Use (std) bool instead of custom bool types
OAI is riddled with boolean_t, FALSE, TRUE, etc. This makes no sense, as there is a standard bool type, and could lead to nasty bugs if a definition of a bool is non-standard (0 == false, true == !false). This commit removes all non-standard bools in the whole project.
This commit is contained in:
@@ -35,17 +35,17 @@
|
||||
* @param pdcp_entity The PDCP entity to be initialized
|
||||
* @return none
|
||||
*/
|
||||
boolean_t pdcp_init_seq_numbers(pdcp_t* pdcp_entity);
|
||||
bool pdcp_init_seq_numbers(pdcp_t* pdcp_entity);
|
||||
/**
|
||||
* Checks if incoming PDCP entitiy pointer and relevant sequence number size is valid
|
||||
* @return TRUE (0x01) if it is valid, FALSE (0x00) otherwise
|
||||
* @return true (0x01) if it is valid, false (0x00) otherwise
|
||||
*/
|
||||
boolean_t pdcp_is_seq_num_size_valid(pdcp_t* pdcp_entity);
|
||||
bool pdcp_is_seq_num_size_valid(pdcp_t* pdcp_entity);
|
||||
/**
|
||||
* Check if SN number is in the range according to SN size
|
||||
* @return TRUE if it is valid, FALSE otherwise
|
||||
* @return true if it is valid, false otherwise
|
||||
*/
|
||||
boolean_t pdcp_is_seq_num_valid(uint16_t seq_num, uint8_t seq_num_size);
|
||||
bool pdcp_is_seq_num_valid(uint16_t seq_num, uint8_t seq_num_size);
|
||||
/**
|
||||
* Returns the maximum allowed sequence number value for given size of SN field
|
||||
* @return Max sequence number value
|
||||
@@ -58,11 +58,11 @@ uint16_t pdcp_get_next_tx_seq_number(pdcp_t* pdcp_entity);
|
||||
/**
|
||||
* Advances the RX window state of given PDCP entity upon successfull receipt of a SDU
|
||||
*/
|
||||
boolean_t pdcp_advance_rx_window(pdcp_t* pdcp_entity);
|
||||
bool pdcp_advance_rx_window(pdcp_t* pdcp_entity);
|
||||
/**
|
||||
* Updates missing PDU bitmap with incoming sequence number
|
||||
* @return TRUE if successful, FALSE otherwise
|
||||
* @return true if successful, false otherwise
|
||||
*/
|
||||
boolean_t pdcp_mark_current_pdu_as_received(uint16_t seq_num, pdcp_t* pdcp_entity);
|
||||
bool pdcp_mark_current_pdu_as_received(uint16_t seq_num, pdcp_t* pdcp_entity);
|
||||
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user