maki/openairinterface5g
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use (std) bool instead of custom bool types

Browse Source 
OAI is riddled with boolean_t, FALSE, TRUE, etc. This makes no sense, as
there is a standard bool type, and could lead to nasty bugs if a
definition of a bool is non-standard (0 == false, true == !false). This
commit removes all non-standard bools in the whole project.
This commit is contained in:
Robert Schmidt
2022-06-27 10:07:48 +02:00
parent 6d030ea2fa
commit 0b91791f67
176 changed files with 1414 additions and 1573 deletions
Download Patch File Download Diff File Expand all files Collapse all files
openair3/NAS/UE/API/USER/at_command.c
+9 -9
View File
@@ -354,7 +354,7 @@ static int ParseString(char * at_str, at_command_t* at_command)
char* terminal_character_index = NULL;
int num_of_chars_to_compare = -1;
int handler_index;
int handler_found = FALSE;
bool handler_found = false;
int check_for_carriage_return_index = 0;
/*
@@ -415,7 +415,7 @@ static int ParseString(char * at_str, at_command_t* at_command)
if (strncasecmp(at_str, _at_command_handler[handler_index].command,
num_of_chars_to_compare) != 0) continue;
handler_found = TRUE;
handler_found = true;
break;
}
@@ -681,7 +681,7 @@ static unsigned int NumberOfParameters(const unsigned char* str)
** Others: None **
** **
** Outputs: None **
** Return: TRUE, FALSE **
** Return: true, false **
** Others: None **
** **
***************************************************************************/
@@ -689,11 +689,11 @@ static unsigned int IsNumeric(const char* str, size_t len)
{
while (len-- > 0) {
if (!isdigit(str[len])) {
return FALSE;
return false;
}
}
return TRUE;
return true;
}
/****************************************************************************/
@@ -719,7 +719,7 @@ static int parse_e1(const char* string, int position, at_command_t* at_command)
static int parse_q0(const char* string, int position, at_command_t* at_command)
{
/* Result code suppression Q0 */
at_error_code_suppression_q1 = FALSE;
at_error_code_suppression_q1 = false;
at_command->id = 0;
at_command->mask = AT_COMMAND_NO_PARAM;
return at_command->id;
@@ -728,7 +728,7 @@ static int parse_q0(const char* string, int position, at_command_t* at_command)
static int parse_q1(const char* string, int position, at_command_t* at_command)
{
/* Result code suppression Q1 */
at_error_code_suppression_q1 = TRUE;
at_error_code_suppression_q1 = true;
at_command->id = 0;
at_command->mask = AT_COMMAND_NO_PARAM;
return at_command->id;
@@ -738,7 +738,7 @@ static int parse_v0(const char* string, int position, at_command_t* at_command)
{
/* Response format V0 (numeric result code + limited header) */
at_error_format = AT_ERROR_NUMERIC;
at_response_format_v1 = FALSE;
at_response_format_v1 = false;
at_command->id = 0;
at_command->mask = AT_COMMAND_NO_PARAM;
return at_command->id;
@@ -748,7 +748,7 @@ static int parse_v1(const char* string, int position, at_command_t* at_command)
{
/* Response format V1 (verbose result code + full header) */
at_error_format = AT_ERROR_VERBOSE;
at_response_format_v1 = TRUE;
at_response_format_v1 = true;
at_command->id = 0;
at_command->mask = AT_COMMAND_NO_PARAM;
return at_command->id;
openair3/NAS/UE/API/USER/at_error.c
+3 -3
View File
@@ -55,10 +55,10 @@ extern int at_response_format_v1;
/*
* Result code suppression indicator (set by ATQ0 and ATQ1)
* -------------------------------------------------------
* FALSE - Result codes are transmitted to the user application
* TRUE - Result codes are suppressed and not transmitted
* false - Result codes are transmitted to the user application
* true - Result codes are suppressed and not transmitted
*/
int at_error_code_suppression_q1 = FALSE;
bool at_error_code_suppression_q1 = false;
/*
* Verbose mode indicator (set by ATV0, ATV1 and AT+CMEE)
openair3/NAS/UE/API/USER/at_response.c
+3 -3
View File
@@ -52,10 +52,10 @@ Description Defines structure of the AT command response returned after
/*
* Response format indicator (set by ATV0 and ATV1)
* -----------------------------------------------
* TRUE - <CR><LF><text><CR><LF>, <CR><LF><verbose code><CR><LF>
* FALSE - <text><CR><LF>, <numeric code><CR><LF>
* true - <CR><LF><text><CR><LF>, <CR><LF><verbose code><CR><LF>
* false - <text><CR><LF>, <numeric code><CR><LF>
*/
int at_response_format_v1 = TRUE;
bool at_response_format_v1 = true;
/****************************************************************************/
/******************* L O C A L D E F I N I T I O N S *******************/