diff --git a/common/utils/T/tracer/to_vcd.c b/common/utils/T/tracer/to_vcd.c index 998649af01..a3c13aebf9 100644 --- a/common/utils/T/tracer/to_vcd.c +++ b/common/utils/T/tracer/to_vcd.c @@ -345,11 +345,9 @@ int main(int n, char **v) /* setup traces */ for (i = 0; i < nvars; i++) { char format[256]; - if (strlen(vars[i].arg) + strlen(vars[i].vcd_name) > 256-16) abort(); - sprintf(format, "%c [%s] %s", - vars[i].boolean ? 'b' : 'l', - vars[i].arg, - vars[i].vcd_name); + int ret = snprintf(format, 256, "%c [%s] %s", vars[i].boolean ? 'b' : 'l', vars[i].arg, vars[i].vcd_name); + if (ret > 255) + abort(); textlog = new_textlog(h, database, vars[i].event, format); logger_add_view(textlog, vcd_view); on_off(database, vars[i].event, is_on, 1); diff --git a/openair1/SCHED_UE/phy_procedures_lte_ue.c b/openair1/SCHED_UE/phy_procedures_lte_ue.c index 19d58ef4b5..c8c83e86bc 100644 --- a/openair1/SCHED_UE/phy_procedures_lte_ue.c +++ b/openair1/SCHED_UE/phy_procedures_lte_ue.c @@ -644,7 +644,7 @@ uint16_t get_n1_pucch(PHY_VARS_UE *ue, LTE_DL_FRAME_PARMS *frame_parms=&ue->frame_parms; uint8_t nCCE0,nCCE1,nCCE2,nCCE3,harq_ack1,harq_ack0,harq_ack3,harq_ack2; ANFBmode_t bundling_flag; - uint16_t n1_pucch0=0,n1_pucch1=0,n1_pucch2=0,n1_pucch3=0,n1_pucch_inter; + uint16_t n1_pucch0 = 0, n1_pucch1 = 0, n1_pucch2 = 0, n1_pucch3 = 0, n1_pucch_inter = 0; static uint8_t candidate_dl[9]; // which downlink(s) the current ACK/NACK is associating to uint8_t last_dl=0xff; // the last downlink with valid DL-DCI. for calculating the PUCCH resource index int sf; @@ -951,7 +951,7 @@ uint16_t get_n1_pucch(PHY_VARS_UE *ue, // proc->frame_tx%1024, // proc->subframe_tx,n1_pucch_inter, // b[0],b[1]); - return(n1_pucch_inter); + return n1_pucch_inter; } else if ((bundling_flag==multiplexing)&&(SR==0)) { // Table 10.1 if (subframe == 3) { LOG_I(PHY, "sbuframe=%d \n",subframe); diff --git a/openair1/SIMULATION/TOOLS/random_channel.c b/openair1/SIMULATION/TOOLS/random_channel.c index fad949ce93..f360adad32 100644 --- a/openair1/SIMULATION/TOOLS/random_channel.c +++ b/openair1/SIMULATION/TOOLS/random_channel.c @@ -1723,8 +1723,9 @@ void free_channel_desc_scm(channel_desc_t *ch) { free(ch); } -void set_channeldesc_owner(channel_desc_t *cdesc, uint32_t module_id) { - cdesc->module_id=module_id; +void set_channeldesc_owner(channel_desc_t *cdesc, channelmod_moduleid_t module_id) +{ + cdesc->module_id = module_id; } void set_channeldesc_name(channel_desc_t *cdesc,char *modelname) {