From 39fa6d81ec9976ee7eb507e8ecbba96244ed1a46 Mon Sep 17 00:00:00 2001 From: francescomani Date: Tue, 10 Mar 2026 09:18:44 +0100 Subject: [PATCH] add flag for unused function arguments in rfsimulator CMakeLists --- radio/rfsimulator/CMakeLists.txt | 1 + radio/rfsimulator/apply_channelmod.c | 7 +------ radio/rfsimulator/rfsimulator.h | 7 +------ radio/rfsimulator/simulator.cpp | 12 +++++++++++- 4 files changed, 14 insertions(+), 13 deletions(-) diff --git a/radio/rfsimulator/CMakeLists.txt b/radio/rfsimulator/CMakeLists.txt index c93ab8cbec..e04ad1edcc 100644 --- a/radio/rfsimulator/CMakeLists.txt +++ b/radio/rfsimulator/CMakeLists.txt @@ -1,5 +1,6 @@ # SPDX-License-Identifier: LicenseRef-CSSL-1.0 +add_compile_options(-Wunused-parameter) add_library(rfsimulator MODULE simulator.cpp apply_channelmod.c diff --git a/radio/rfsimulator/apply_channelmod.c b/radio/rfsimulator/apply_channelmod.c index 800cf9b55d..0994231376 100644 --- a/radio/rfsimulator/apply_channelmod.c +++ b/radio/rfsimulator/apply_channelmod.c @@ -213,12 +213,7 @@ void update_channel_model(channel_desc_t *channelDesc, int nbSamples, uint64_t T either we regenerate the channel (call again random_channel(desc,0)), or we keep it over subframes legacy: we regenerate each sub frame in UL, and each frame only in DL */ -void rxAddInput(c16_t **input_sig, - cf_t *after_channel_sig, - int rxAnt, - channel_desc_t *channelDesc, - int nbSamples, - uint64_t TS) +void rxAddInput(c16_t **input_sig, cf_t *after_channel_sig, int rxAnt, channel_desc_t *channelDesc, int nbSamples) { // channelDesc->path_loss_dB should contain the total path gain // so, in actual RF: tx gain + path loss + rx gain (+antenna gain, ...) diff --git a/radio/rfsimulator/rfsimulator.h b/radio/rfsimulator/rfsimulator.h index be8884fbe6..895f9b8341 100644 --- a/radio/rfsimulator/rfsimulator.h +++ b/radio/rfsimulator/rfsimulator.h @@ -5,11 +5,6 @@ #ifndef __RFSIMULATOR_H #define __RFSIMULATOR_H #include -void rxAddInput(c16_t **input_sig, - cf_t *after_channel_sig, - int rxAnt, - channel_desc_t *channelDesc, - int nbSamples, - uint64_t TS); +void rxAddInput(c16_t **input_sig, cf_t *after_channel_sig, int rxAnt, channel_desc_t *channelDesc, int nbSamples); void update_channel_model(channel_desc_t *channelDesc, int nbSamples, uint64_t TS); #endif diff --git a/radio/rfsimulator/simulator.cpp b/radio/rfsimulator/simulator.cpp index 38b5351e40..f122b21fa0 100644 --- a/radio/rfsimulator/simulator.cpp +++ b/radio/rfsimulator/simulator.cpp @@ -605,6 +605,7 @@ static void rfsimulator_readconfig(rfsimulator_state_t *rfsimulator) static int rfsimu_set_beam(char *buff, int debug, telnet_printfunc_t prnt, void *arg) { + UNUSED(debug); rfsimulator_state_t *t = (rfsimulator_state_t *)arg; rfsim_beam_ctrl_t *beam_ctrl = t->beam_ctrl; AssertFatal(beam_ctrl->enable_beams, "Beam simualtion is disabled, cannot set beams\n"); @@ -619,6 +620,7 @@ static int rfsimu_set_beam(char *buff, int debug, telnet_printfunc_t prnt, void static int rfsimu_set_beamids(char *buff, int debug, telnet_printfunc_t prnt, void *arg) { + UNUSED(debug); rfsimulator_state_t *t = (rfsimulator_state_t *)arg; rfsim_beam_ctrl_t *beam_ctrl = t->beam_ctrl; AssertFatal(beam_ctrl->enable_beams, "Beam simualtion is disabled, cannot set beams\n"); @@ -787,6 +789,8 @@ static int rfsimu_getdistance_cmd(char *buff, int debug, telnet_printfunc_t prnt static int rfsimu_vtime_cmd(char *buff, int debug, telnet_printfunc_t prnt, void *arg) { + UNUSED(debug); + UNUSED(buff); rfsimulator_state_t *t = (rfsimulator_state_t *)arg; const openair0_timestamp_t ts = t->nextRxTstamp; const double sample_rate = t->sample_rate; @@ -1316,7 +1320,7 @@ static void rfsimulator_read_internal(rfsimulator_state_t *t, input); for (int aarx = 0; aarx < nbAnt; aarx++) { - rxAddInput(input, temp_array[aarx], aarx, ptr->channel_model, nsamps, timestamp); + rxAddInput(input, temp_array[aarx], aarx, ptr->channel_model, nsamps); } } else { if (is_first_beam && is_first_peer && (ptr->nbAnt == 1 || nbAnt == 1)) { @@ -1528,10 +1532,12 @@ static int rfsimulator_read(openair0_device_t *device, openair0_timestamp_t *pti static int rfsimulator_get_stats(openair0_device_t *device) { + UNUSED(device); return 0; } static int rfsimulator_reset_stats(openair0_device_t *device) { + UNUSED(device); return 0; } static void rfsimulator_end(openair0_device_t *device) @@ -1559,6 +1565,7 @@ static void stopServer(openair0_device_t *device) static int rfsimulator_stop(openair0_device_t *device) { + UNUSED(device); return 0; } static int rfsimulator_set_freq(openair0_device_t *device, openair0_config_t *openair0_cfg) @@ -1569,10 +1576,13 @@ static int rfsimulator_set_freq(openair0_device_t *device, openair0_config_t *op } static int rfsimulator_set_gains(openair0_device_t *device, openair0_config_t *openair0_cfg) { + UNUSED(device); + UNUSED(openair0_cfg); return 0; } static int rfsimulator_write_init(openair0_device_t *device) { + UNUSED(device); return 0; }