From 3a92eed5b92c12531f2d22e55e3440a99a9815c8 Mon Sep 17 00:00:00 2001 From: Romain Beurdouche Date: Mon, 23 Mar 2026 13:56:46 +0100 Subject: [PATCH] fix(build & doc): Remove remaining mentions of ldpc_cuda * Option to build ldpc_cuda was remaining in the build script * Build script option to build ldpc_cuda was still used in CI * Mentions of ldpc_cuda were remaining in the documentation Note: In the documentation, the example of ldpctest usage that was loading ldpc_cuda was replaced by an example in which it is loading ldpc_orig even though this is pointless as it makes ldpctest compare ldpc_orig with ldpc_orig. On the other hand, it is the only library other than the default ldpc that uses the former interface. --- ci-scripts/xml_files/gnb_usrp_build.xml | 2 +- cmake_targets/build_oai | 2 +- doc/BUILD.md | 1 - openair1/PHY/CODING/DOC/LDPCImplementation.md | 6 ++---- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/ci-scripts/xml_files/gnb_usrp_build.xml b/ci-scripts/xml_files/gnb_usrp_build.xml index ea7cc8b8ed..4917e15c33 100644 --- a/ci-scripts/xml_files/gnb_usrp_build.xml +++ b/ci-scripts/xml_files/gnb_usrp_build.xml @@ -44,7 +44,7 @@ Build_eNB Build gNB (USRP) caracal - --gNB -w USRP --ninja -c -P --build-lib ldpc_cuda --build-lib ldpc_aal --cmake-opt -DASN1C_EXEC=/opt/asn1c/bin/asn1c --cmake-opt -DPHYSIM_CHECK_FILES="ThresholdsOffload.cmake" + --gNB -w USRP --ninja -c -P --build-lib ldpc_aal --cmake-opt -DASN1C_EXEC=/opt/asn1c/bin/asn1c --cmake-opt -DPHYSIM_CHECK_FILES="ThresholdsOffload.cmake" diff --git a/cmake_targets/build_oai b/cmake_targets/build_oai index c9e268407d..e47e70df7a 100755 --- a/cmake_targets/build_oai +++ b/cmake_targets/build_oai @@ -40,7 +40,7 @@ HWs="" BUILD_DIR=ran_build CMAKE_BUILD_TYPE="RelWithDebInfo" CMAKE_CMD="$CMAKE" -OPTIONAL_LIBRARIES="telnetsrv enbscope uescope nrscope ldpc_cuda ldpc_aal ldpc_xdma websrv oai_iqplayer imscope imscope_record" +OPTIONAL_LIBRARIES="telnetsrv enbscope uescope nrscope ldpc_aal ldpc_xdma websrv oai_iqplayer imscope imscope_record" TARGET_LIST="" BUILD_TOOL_OPT="-j$(nproc)" diff --git a/doc/BUILD.md b/doc/BUILD.md index 40394214d4..0ee2d43820 100644 --- a/doc/BUILD.md +++ b/doc/BUILD.md @@ -171,7 +171,6 @@ The following libraries are build in CI and should always work: `telnetsrv`, Some libraries have further dependencies and might not build on every system: - `enbscope`, `uescope`, `nrscope`: libforms/X -- `ldpc_cuda`: CUDA - `websrv`: npm and others - `ldpc_aal`: DPDK with patch diff --git a/openair1/PHY/CODING/DOC/LDPCImplementation.md b/openair1/PHY/CODING/DOC/LDPCImplementation.md index d6ea6565fa..2717b5587c 100644 --- a/openair1/PHY/CODING/DOC/LDPCImplementation.md +++ b/openair1/PHY/CODING/DOC/LDPCImplementation.md @@ -110,10 +110,10 @@ A mechanism to select ldpc implementation is also available in the `ldpctest` ph #### Examples of ldpc shared lib selection when running ldpctest: -Loading libldpc_cuda.so, the cuda implementation of the ldpc decoder: +Loading libldpc_orig.so, the legacy implementation of the ldpc decoder: ``` -$ ./ldpctest -v _cuda +$ ./ldpctest -v _orig ``` ### LDPC libraries @@ -124,6 +124,4 @@ Libraries implementing the LDPC algorithms must be named `libldpc<_version>.so`, * `LDPCdecoder` implementing type `LDPC_decoderfunc_t *` * `LDPCencoder` implementing type `LDPC_encoderfunc_t *` -`libldpc_cuda.so` has been tested with the `ldpctest` executable, usage from the softmodem's has to be tested. - [oai Wikis home](https://gitlab.eurecom.fr/oai/openairinterface5g/wikis/home)