From 3b11764d1de8a7686cb087aed8f8da283c9d2cce Mon Sep 17 00:00:00 2001 From: Guido Casati Date: Wed, 28 Aug 2024 17:22:09 +0200 Subject: [PATCH] Minor comments --- openair2/COMMON/f1ap_messages_types.h | 3 +-- openair2/F1AP/f1ap_du_rrc_message_transfer.c | 4 +++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/openair2/COMMON/f1ap_messages_types.h b/openair2/COMMON/f1ap_messages_types.h index 95ff676307..f2fd001e4e 100644 --- a/openair2/COMMON/f1ap_messages_types.h +++ b/openair2/COMMON/f1ap_messages_types.h @@ -292,8 +292,7 @@ typedef struct f1ap_gnb_du_configuration_update_s { f1ap_plmn_t plmn; uint64_t nr_cellid; // NR Global Cell Id } cell_to_delete[F1AP_MAX_NB_CELLS]; - - /// string holding gNB_CU_name + /// gNB-DU unique ID, at least within a gNB-CU (0 .. 2^36 - 1) uint64_t *gNB_DU_ID; } f1ap_gnb_du_configuration_update_t; diff --git a/openair2/F1AP/f1ap_du_rrc_message_transfer.c b/openair2/F1AP/f1ap_du_rrc_message_transfer.c index 5f150bf25c..7fd83ecd78 100644 --- a/openair2/F1AP/f1ap_du_rrc_message_transfer.c +++ b/openair2/F1AP/f1ap_du_rrc_message_transfer.c @@ -74,6 +74,7 @@ int DU_handle_DL_RRC_MESSAGE_TRANSFER(instance_t instance, sctp_assoc_t assoc_id /* UL RRC Message Transfer */ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_initial_ul_rrc_message_t *msg) { + /* encode Initial UL RRC Message Transfer */ F1AP_F1AP_PDU_t *pdu = encode_initial_ul_rrc_message_transfer(msg); /* free F1AP message after encoding */ free_initial_ul_rrc_message_transfer(msg); @@ -84,7 +85,7 @@ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_in return -1; } - /* encode */ + /* encode F1AP PDU */ uint8_t *buffer = NULL; uint32_t len = 0; if (f1ap_encode_pdu(pdu, &buffer, &len) < 0) { @@ -94,6 +95,7 @@ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_in } ASN_STRUCT_FREE(asn_DEF_F1AP_F1AP_PDU, pdu); + /* Send to ITTI */ f1ap_itti_send_sctp_data_req(assoc_id, buffer, len); return 0; }