From 3b174f685e732e45d93d651a656e0a1007f37b0d Mon Sep 17 00:00:00 2001 From: Bartosz Podrygajlo Date: Wed, 2 Apr 2025 14:32:34 +0200 Subject: [PATCH] Remove unnecessary memset of UE TX time domain samples array Remove memset of the UE TX time domain samples array after trx_write in RU_write() This memset is unnecessary and can break openair0 libraries. Some functionalities, e.g. usrp_lib write_thread expect the samples to be present in the array after trx_write returns. The array is always set before being sent either in idft or using memset so there is no risk of sending the same data twice. --- executables/nr-ue.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/executables/nr-ue.c b/executables/nr-ue.c index b8888708aa..d34e710cec 100644 --- a/executables/nr-ue.c +++ b/executables/nr-ue.c @@ -553,9 +553,6 @@ static void RU_write(nr_rxtx_thread_data_t *rxtxD, bool sl_tx_action) int tmp = openair0_write_reorder(&UE->rfdevice, writeTimestamp, txp, writeBlockSize, fp->nb_antennas_tx, flags); AssertFatal(tmp == writeBlockSize, ""); - - for (int i = 0; i < fp->nb_antennas_tx; i++) - memset(txp[i], 0, writeBlockSize); } void processSlotTX(void *arg)