code review comments + re-test

common/utils/system.c

@@ -391,7 +391,7 @@ void thread_top_init(char *thread_name,
 
 
 // Block CPU C-states deep sleep
-void configure_linux(void) {
+void set_latency_target(void) {
   int ret;
   static int latency_target_fd=-1;
   uint32_t latency_target_value=2; // in microseconds

common/utils/system.h

@@ -43,10 +43,9 @@ int background_system(char *command);
 void start_background_system(void);
 
 void set_latency_target(void);
-void configure_linux(void);
 
-void threadCreate(pthread_t* t, void * (*func)(void*), void * param, char* name, int affinity, int priority);
- 
+void threadCreate(pthread_t *t, void *(*func)(void *), void *param, char *name, int affinity, int priority);
+
 #define SCHED_OAI SCHED_RR
 #define OAI_PRIORITY_RT_LOW sched_get_priority_min(SCHED_OAI)
 #define OAI_PRIORITY_RT ((sched_get_priority_min(SCHED_OAI)+sched_get_priority_max(SCHED_OAI))/2)
@@ -65,7 +64,7 @@ void thread_top_init(char *thread_name,
 int checkIfFedoraDistribution(void);
 int checkIfGenericKernelOnFedora(void);
 int checkIfInsideContainer(void);
-  int rt_sleep_ns (uint64_t x);
+int rt_sleep_ns (uint64_t x);
 #ifdef __cplusplus
 }
 #endif

common/utils/utils.c

@@ -7,23 +7,7 @@
 #include <errno.h>
 #include "utils.h"
 
-void *calloc_or_fail(size_t size) {
-  void *ptr = calloc(1, size);
-  if (ptr == NULL) {
-    fprintf(stderr, "[UE] Failed to calloc %zu bytes", size);
-    exit(EXIT_FAILURE);
-  }
-  return ptr;
-}
 
-void *malloc_or_fail(size_t size) {
-  void *ptr = malloc(size);
-  if (ptr == NULL) {
-    fprintf(stderr, "[UE] Failed to malloc %zu bytes", size);
-    exit(EXIT_FAILURE);
-  }
-  return ptr;
-}
 
 const char *hexdump(const void *data, size_t data_len, char *out, size_t out_len)
 {

common/utils/utils.h

@@ -1,16 +1,110 @@
 #ifndef _UTILS_H
 #define _UTILS_H
 
-#include <stdint.h>
-#include <sys/types.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
 
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+#include <malloc.h>
+#include <sys/types.h>
+#include <common/utils/assertions.h>
+
+  #ifdef MALLOC_TRACE
+  #define malloc myMalloc
+  #endif
+
 #define sizeofArray(a) (sizeof(a)/sizeof(*(a)))
-void *calloc_or_fail(size_t size);
-void *malloc_or_fail(size_t size);
-const char *hexdump(const void *data, size_t data_len, char *out, size_t out_len);
+  
+#define cmax(a,b)  ((a>b) ? (a) : (b))
+#define cmax3(a,b,c) ((cmax(a,b)>c) ? (cmax(a,b)) : (c))
+#define cmin(a,b)  ((a<b) ? (a) : (b))
+
+#ifdef __cplusplus
+#ifdef min
+#undef min
+#undef max
+#endif
+#else
+#define max(a,b) cmax(a,b)
+#define min(a,b) cmin(a,b)
+#endif
+
+#ifndef malloc16
+#  ifdef __AVX2__
+#    define malloc16(x) memalign(32,x+32)
+#  else
+#    define malloc16(x) memalign(16,x+16)
+#  endif
+#endif
+#define free16(y,x) free(y)
+#define bigmalloc malloc
+#define bigmalloc16 malloc16
+#define openair_free(y,x) free((y))
+#define PAGE_SIZE 4096
+
+#define free_and_zero(PtR) do {			\
+      if (PtR) {           \
+        free(PtR);         \
+        PtR = NULL;        \
+      }                    \
+    } while (0)
+  
+static inline void* malloc16_clear( size_t size )
+{
+#ifdef __AVX2__
+  void* ptr = memalign(32, size+32);
+#else
+  void* ptr = memalign(16, size+16);
+#endif
+  DevAssert(ptr);
+  memset( ptr, 0, size );
+  return ptr;
+}
+  
+  
+  static inline void *calloc_or_fail(size_t size) {
+    void *ptr = calloc(1, size);
+    if (ptr == NULL) {
+      fprintf(stderr, "[UE] Failed to calloc %zu bytes", size);
+      exit(EXIT_FAILURE);
+    }
+    return ptr;
+  }
+
+  static inline void *malloc_or_fail(size_t size) {
+  void *ptr = malloc(size);
+  if (ptr == NULL) {
+    fprintf(stderr, "[UE] Failed to malloc %zu bytes", size);
+    exit(EXIT_FAILURE);
+  }
+  return ptr;
+  }
+  
+#if !defined (msg)
+# define msg(aRGS...) LOG_D(PHY, ##aRGS)
+#endif
+#ifndef malloc16
+#  ifdef __AVX2__
+#    define malloc16(x) memalign(32,x)
+#  else
+#    define malloc16(x) memalign(16,x)
+#  endif
+#endif
+  
+#define free16(y,x) free(y)
+#define bigmalloc malloc
+#define bigmalloc16 malloc16
+#define openair_free(y,x) free((y))
+#define PAGE_SIZE 4096
+
+#define PAGE_MASK 0xfffff000
+#define virt_to_phys(x) (x)
+
+  const char *hexdump(const void *data, size_t data_len, char *out, size_t out_len);
 
 // Converts an hexadecimal ASCII coded digit into its value. **
 int hex_char_to_hex_value (char c);