e1: no need to pass security information since it does not change
In Bearer Context Modification Request, the security information field is needed only if we change the PDCP algorithms/keys. Since we don't, no need to pass it. Let's keep the old code, maybe the current understanding of the specifications is wrong.
This commit is contained in:
committed by
Guido Casati
parent
1273446804
commit
410446cbe9
@@ -816,9 +816,17 @@ static void cuup_notify_reestablishment(gNB_RRC_INST *rrc, gNB_RRC_UE_t *ue_p)
|
|||||||
/* increase DRB to modify counter */
|
/* increase DRB to modify counter */
|
||||||
pdu_e1->numDRB2Modify += 1;
|
pdu_e1->numDRB2Modify += 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#if 0
|
||||||
|
/* According to current understanding of E1 specifications, it is not needed
|
||||||
|
* to send security information because this does not change.
|
||||||
|
* But let's keep the code here in case it's needed.
|
||||||
|
*/
|
||||||
// Always send security information
|
// Always send security information
|
||||||
req.secInfo = malloc_or_fail(sizeof(*req.secInfo));
|
req.secInfo = malloc_or_fail(sizeof(*req.secInfo));
|
||||||
fill_security_info(rrc, ue_p, req.secInfo);
|
fill_security_info(rrc, ue_p, req.secInfo);
|
||||||
|
#endif
|
||||||
|
|
||||||
/* Send E1 Bearer Context Modification Request (3GPP TS 38.463) */
|
/* Send E1 Bearer Context Modification Request (3GPP TS 38.463) */
|
||||||
sctp_assoc_t assoc_id = get_existing_cuup_for_ue(rrc, ue_p);
|
sctp_assoc_t assoc_id = get_existing_cuup_for_ue(rrc, ue_p);
|
||||||
rrc->cucp_cuup.bearer_context_mod(assoc_id, &req);
|
rrc->cucp_cuup.bearer_context_mod(assoc_id, &req);
|
||||||
|
|||||||
Reference in New Issue
Block a user