Extract nr_common and nr_phy_common libs. Also add unit tests for nr_common

common/utils/CMakeLists.txt

@@ -10,3 +10,4 @@ if(ENABLE_WEBSRV)
 endif()
 
 add_subdirectory(T)
+add_subdirectory(nr)

common/utils/nr/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_library(nr_common nr_common.c)
+target_include_directories(nr_common PUBLIC .)
+if (ENABLE_TESTS)
+  add_subdirectory(tests)
+endif()

common/utils/nr/nr_common.c

@@ -1174,38 +1174,6 @@ void init_delay_table(uint16_t ofdm_symbol_size,
   }
 }
 
-void freq2time(uint16_t ofdm_symbol_size,
-               int16_t *freq_signal,
-               int16_t *time_signal)
-{
-  const idft_size_idx_t idft_size = get_idft(ofdm_symbol_size);
-  idft(idft_size, freq_signal, time_signal, 1);
-}
-
-void nr_est_delay(int ofdm_symbol_size, const c16_t *ls_est, c16_t *ch_estimates_time, delay_t *delay)
-{
-  freq2time(ofdm_symbol_size, (int16_t *)ls_est, (int16_t *)ch_estimates_time);
-
-  int max_pos = delay->delay_max_pos;
-  int max_val = delay->delay_max_val;
-  const int sync_pos = 0;
-
-  for (int i = 0; i < ofdm_symbol_size; i++) {
-    int temp = c16amp2(ch_estimates_time[i]) >> 1;
-    if (temp > max_val) {
-      max_pos = i;
-      max_val = temp;
-    }
-  }
-
-  if (max_pos > ofdm_symbol_size / 2)
-    max_pos = max_pos - ofdm_symbol_size;
-
-  delay->delay_max_pos = max_pos;
-  delay->delay_max_val = max_val;
-  delay->est_delay = max_pos - sync_pos;
-}
-
 void nr_timer_start(NR_timer_t *timer)
 {
   timer->active = true;

common/utils/nr/nr_common.h

@@ -241,12 +241,6 @@ uint32_t get_ssb_offset_to_pointA(uint32_t absoluteFrequencySSB,
 int get_ssb_subcarrier_offset(uint32_t absoluteFrequencySSB, uint32_t absoluteFrequencyPointA, int scs);
 int get_delay_idx(int delay, int max_delay_comp);
 
-void freq2time(uint16_t ofdm_symbol_size,
-               int16_t *freq_signal,
-               int16_t *time_signal);
-
-void nr_est_delay(int ofdm_symbol_size, const c16_t *ls_est, c16_t *ch_estimates_time, delay_t *delay);
-
 int get_scan_ssb_first_sc(const double fc,
                           const int nbRB,
                           const int nrBand,

common/utils/nr/tests/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_executable(test_nr_common test_nr_common.cpp)
+target_link_libraries(test_nr_common PRIVATE nr_common GTest::gtest minimal_lib)
+add_dependencies(tests test_nr_common)
+add_test(NAME test_nr_common
+  COMMAND ./test_nr_common)

common/utils/nr/tests/test_nr_common.cpp

@@ -0,0 +1,47 @@
+/*
+ * Licensed to the OpenAirInterface (OAI) Software Alliance under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The OpenAirInterface Software Alliance licenses this file to You under
+ * the OAI Public License, Version 1.1  (the "License"); you may not use this file
+ * except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.openairinterface.org/?page_id=698
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *-------------------------------------------------------------------------------
+ * For more information about the OpenAirInterface (OAI) Software Alliance:
+ *      contact@openairinterface.org
+ */
+
+#include <gtest/gtest.h>
+extern "C" {
+#include "nr_common.h"
+#include "common/utils/LOG/log.h"
+}
+
+TEST(nr_common, nr_timer) {
+  NR_timer_t timer;
+  nr_timer_setup(&timer, 10, 1);
+  nr_timer_start(&timer);
+  EXPECT_TRUE(is_nr_timer_active(timer));
+  EXPECT_FALSE(nr_timer_expired(timer));
+  for (auto i = 0; i < 10; i++) {
+    nr_timer_tick(&timer);
+  }
+  EXPECT_FALSE(is_nr_timer_active(timer));
+  EXPECT_TRUE(nr_timer_expired(timer));
+}
+
+
+int main(int argc, char **argv)
+{
+  logInit();
+  testing::InitGoogleTest(&argc, argv);
+  return RUN_ALL_TESTS();
+}