From 679816c3c1b1fb24903677327c37960b63b5b5f5 Mon Sep 17 00:00:00 2001 From: Melissa Elkadi Date: Tue, 15 Feb 2022 15:05:04 -0800 Subject: [PATCH] Added comment around asn1cCalloc memory leak --- openair2/RRC/LTE/MESSAGES/asn1_msg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openair2/RRC/LTE/MESSAGES/asn1_msg.c b/openair2/RRC/LTE/MESSAGES/asn1_msg.c index 349441544d..d271eecd5c 100644 --- a/openair2/RRC/LTE/MESSAGES/asn1_msg.c +++ b/openair2/RRC/LTE/MESSAGES/asn1_msg.c @@ -4293,8 +4293,9 @@ ssize_t do_nrMeasurementReport(uint8_t *buffer, LTE_MeasResultListEUTRA_t *measResultListEUTRA2=&measResultNeighCells->choice.measResultListEUTRA; asn1cSequenceAdd(measResultListEUTRA2->list, struct LTE_MeasResultEUTRA, measresulteutra_list); measresulteutra_list->physCellId = phy_id; + /* TODO: This asn1cCalloc leaks memory but also masks a bug. + If we delete this asn1cCalloc statement, eNB will crash in NSA mode. */ asn1cCalloc(measresulteutra_list->cgi_Info, measresult_cgi2); - memset(measresult_cgi2, 0, sizeof(LTE_CellGlobalIdEUTRA_t)); struct LTE_MeasResultEUTRA__measResult* measResult= &measresulteutra_list->measResult; asn1cCallocOne(measResult->rsrpResult, rsrp_tar); asn1cCallocOne(measResult->rsrqResult, rsrq_tar);