add flag for unused function arguments in common folder CMakeLists

(not enforced because of fmtlog external dependency)

common/utils/T/T.c

@@ -89,6 +89,7 @@ static int get_message(int s)
 
 static void *T_receive_thread(void *_)
 {
+  UNUSED(_);
   int err = 0;
   while (!err) err = get_message(T_socket);
 

common/utils/T/check_vcd.c

@@ -27,6 +27,10 @@
  */
 void exit_function(const char *file, const char *function, const int line, const char *s, const int assert)
 {
+  UNUSED(file);
+  UNUSED(function);
+  UNUSED(line);
+  UNUSED(s);
   if (assert) {
     abort();
   } else {

common/utils/T/tracer/enb.c

@@ -428,7 +428,7 @@ static void enb_main_gui(enb_gui *e, gui *g, event_handler *h, void *database,
   for (i = 0; i < 8; i++)
     timeline_set_subline_background_color(g, timeline_plot, i,
         new_color(g, i==0 || i==4 ? "#aaf" : "#eee"));
-  timeview = new_view_time(3600, 10, g, timeline_plot);
+  timeview = new_view_time(10, g, timeline_plot);
   /* DL tick logging */
   timelog = new_timelog(h, database, "ENB_PHY_DL_TICK");
   subview = new_subview_time(timeview, 0, new_color(g, "#77c"), 3600*1000);

common/utils/T/tracer/event.h

@@ -7,6 +7,7 @@
 
 #include "utils.h"
 #include "../T_defs.h"
+#include "common/platform_types.h"
 #ifdef T_SEND_TIME
 #include <time.h>
 #endif

common/utils/T/tracer/filter/filter.c

@@ -41,6 +41,7 @@ int eval_eq(struct filter *f, event e)
 
 int eval_int(struct filter *f, event e)
 {
+  UNUSED(e);
   return f->v.v;
 }
 
@@ -152,9 +153,9 @@ filter *filter_evarg(void *database, char *event_name, char *varname)
   return ret;
 }
 
-filter *filter_evfun(void *database, int (*fun)(void *priv, int v),
-    void *priv, filter *x)
+filter *filter_evfun(void *database, int (*fun)(void *priv, int v), void *priv, filter *x)
 {
+  UNUSED(database);
   struct filter *ret = calloc(1, sizeof(struct filter));
   if (ret == NULL) abort();
   ret->eval = eval_evfun;

common/utils/T/tracer/filter/filter.h

@@ -13,11 +13,8 @@ filter *filter_and(filter *a, filter *b);
 filter *filter_eq(filter *a, filter *b);
 filter *filter_int(int v);
 filter *filter_evarg(void *database, char *event_name, char *varname);
-filter *filter_evfun(void *database, int (*fun)(void *priv, int v),
-    void *priv, filter *x);
-
+filter *filter_evfun(void *database, int (*fun)(void *priv, int v), void *priv, filter *x);
 int filter_eval(filter *f, event e);
-
 void free_filter(filter *f);
 
 #endif /* _FILTER_H_ */

common/utils/T/tracer/handler.c

@@ -52,8 +52,7 @@ event_handler *new_handler(void *database)
   return ret;
 }
 
-unsigned long register_handler_function(event_handler *_h, int event_id,
-    void (*f)(void *, event), void *p)
+unsigned long register_handler_function(event_handler *_h, int event_id, void (*f)(void *, event), void *p)
 {
   struct _event_handler *h = _h;
   unsigned long ret = h->next_id;
@@ -78,9 +77,11 @@ unsigned long register_handler_function(event_handler *_h, int event_id,
   return ret;
 }
 
-void remove_handler_function(event_handler *h, int event_id,
-    unsigned long handler_id)
+void remove_handler_function(event_handler *h, int event_id, unsigned long handler_id)
 {
+  UNUSED(h);
+  UNUSED(event_id);
+  UNUSED(handler_id);
   printf("%s:%d: TODO\n", __FILE__, __LINE__);
   abort();
 }

common/utils/T/tracer/handler.h

@@ -11,10 +11,7 @@ typedef void event_handler;
 
 event_handler *new_handler(void *database);
 void handle_event(event_handler *h, event e);
-
-unsigned long register_handler_function(event_handler *_h, int event_id,
-    void (*f)(void *, event), void *p);
-void remove_handler_function(event_handler *h, int event_id,
-    unsigned long handler_id);
+unsigned long register_handler_function(event_handler *_h, int event_id, void (*f)(void *, event), void *p);
+void remove_handler_function(event_handler *h, int event_id, unsigned long handler_id);
 
 #endif /* _HANDLER_H_ */

common/utils/T/tracer/macpdu2wireshark.c

@@ -323,7 +323,7 @@ void dl(void *_d, event e)
   }
 
   trace_lte(e.sending_time, d, DIRECTION_DOWNLINK,
-            e.e[d->dl_rnti].i != 0xffff ? C_RNTI : SI_RNTI, e.e[d->dl_rnti].i,
+            e.e[d->dl_rnti].i != 0xffff ? C_RNTI : SI_RNTI_T, e.e[d->dl_rnti].i,
             e.e[d->dl_frame].i, e.e[d->dl_subframe].i,
             e.e[d->dl_data].b, e.e[d->dl_data].bsize,
             NO_PREAMBLE, NO_SR_RNTI);
@@ -406,7 +406,7 @@ void sr(void *_d, event e)
 
 void trace_nr(struct timespec sending_time, ev_data *d, int direction,
         int rnti_type, int rnti, int frame, int slot, int harq_pid, void *buf,
-        int bufsize, int preamble)
+        int bufsize)
 {
   ssize_t ret;
   int i;
@@ -475,7 +475,7 @@ void nr_ul(void *_d, event e)
            NR_C_RNTI, e.e[d->nr_ul_rnti].i,
            e.e[d->nr_ul_frame].i, e.e[d->nr_ul_slot].i,
            e.e[d->nr_ul_harq_pid].i, e.e[d->nr_ul_data].b,
-           e.e[d->nr_ul_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_ul_data].bsize);
 }
 
 void nr_dl(void *_d, event e)
@@ -494,7 +494,7 @@ void nr_dl(void *_d, event e)
            e.e[d->nr_dl_rnti].i != 0xffff ? NR_C_RNTI : NR_SI_RNTI,
            e.e[d->nr_dl_rnti].i, e.e[d->nr_dl_frame].i, e.e[d->nr_dl_slot].i,
            e.e[d->nr_dl_harq_pid].i, e.e[d->nr_dl_data].b,
-           e.e[d->nr_dl_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_dl_data].bsize);
 }
 
 void nr_dl_retx(void *_d, event e)
@@ -505,7 +505,7 @@ void nr_dl_retx(void *_d, event e)
            NR_C_RNTI, e.e[d->nr_dl_retx_rnti].i,
            e.e[d->nr_dl_retx_frame].i, e.e[d->nr_dl_retx_slot].i,
            e.e[d->nr_dl_retx_harq_pid].i, e.e[d->nr_dl_retx_data].b,
-           e.e[d->nr_dl_retx_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_dl_retx_data].bsize);
 }
 
 void nr_mib(void *_d, event e)
@@ -520,7 +520,7 @@ void nr_mib(void *_d, event e)
 
   trace_nr(e.sending_time, d, NR_DIRECTION_DOWNLINK, NR_NO_RNTI, 0,
            e.e[d->nr_mib_frame].i, e.e[d->nr_mib_slot].i, 0 /* harq pid */,
-           e.e[d->nr_mib_data].b, e.e[d->nr_mib_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_mib_data].b, e.e[d->nr_mib_data].bsize);
 }
 
 void nr_ue_mib(void *_d, event e)
@@ -535,7 +535,7 @@ void nr_ue_mib(void *_d, event e)
 
   trace_nr(e.sending_time, d, NR_DIRECTION_DOWNLINK, NR_NO_RNTI, 0,
            e.e[d->nr_ue_mib_frame].i, e.e[d->nr_ue_mib_slot].i, 0 /* harq pid */,
-           e.e[d->nr_ue_mib_data].b, e.e[d->nr_ue_mib_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_ue_mib_data].b, e.e[d->nr_ue_mib_data].bsize);
 }
 
 void nr_rar(void *_d, event e)
@@ -545,7 +545,7 @@ void nr_rar(void *_d, event e)
   trace_nr(e.sending_time, d, NR_DIRECTION_DOWNLINK,
            NR_RA_RNTI, e.e[d->nr_rar_rnti].i,
            e.e[d->nr_rar_frame].i, e.e[d->nr_rar_slot].i, 0 /* harq pid */,
-           e.e[d->nr_rar_data].b, e.e[d->nr_rar_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_rar_data].b, e.e[d->nr_rar_data].bsize);
 }
 
 void nr_ue_ul(void *_d, event e)
@@ -556,7 +556,7 @@ void nr_ue_ul(void *_d, event e)
            NR_C_RNTI, e.e[d->nr_ue_ul_rnti].i,
            e.e[d->nr_ue_ul_frame].i, e.e[d->nr_ue_ul_slot].i,
            e.e[d->nr_ue_ul_harq_pid].i, e.e[d->nr_ue_ul_data].b,
-           e.e[d->nr_ue_ul_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_ue_ul_data].bsize);
 }
 
 void nr_ue_dl(void *_d, event e)
@@ -575,7 +575,7 @@ void nr_ue_dl(void *_d, event e)
            e.e[d->nr_ue_dl_rnti].i != 0xffff ? NR_C_RNTI : NR_SI_RNTI,
            e.e[d->nr_ue_dl_rnti].i, e.e[d->nr_ue_dl_frame].i,
            e.e[d->nr_ue_dl_slot].i, e.e[d->nr_ue_dl_harq_pid].i,
-           e.e[d->nr_ue_dl_data].b, e.e[d->nr_ue_dl_data].bsize, NO_PREAMBLE);
+           e.e[d->nr_ue_dl_data].b, e.e[d->nr_ue_dl_data].bsize);
 }
 
 void nr_ue_rar(void *_d, event e)
@@ -584,8 +584,7 @@ void nr_ue_rar(void *_d, event e)
   trace_nr(e.sending_time, d, DIRECTION_DOWNLINK,
            RA_RNTI, e.e[d->nr_ue_rar_rnti].i,
            e.e[d->nr_ue_rar_frame].i, e.e[d->nr_ue_rar_slot].i, 0,
-           e.e[d->nr_ue_rar_data].b, e.e[d->nr_ue_rar_data].bsize,
-           NO_PREAMBLE);
+           e.e[d->nr_ue_rar_data].b, e.e[d->nr_ue_rar_data].bsize);
 }
 
 /****************************************************************************/
@@ -961,7 +960,7 @@ static int sock = -1;
 
 void force_stop(int x)
 {
-  printf("\ngently quit...\n");
+  printf("\ngently quit(%d)...\n", x);
   close(sock);
   sock = -1;
   run = 0;

common/utils/T/tracer/packet-mac-lte.h

@@ -27,12 +27,12 @@
 
 /* rntiType */
 #define NO_RNTI     0
-#define P_RNTI      1
+#define P_RNTI_T    1
 #define RA_RNTI     2
 #define C_RNTI      3
-#define SI_RNTI     4
+#define SI_RNTI_T   4
 #define SPS_RNTI    5
-#define M_RNTI      6
+#define M_RNTI_T    6
 #define SL_BCH_RNTI 7
 #define SL_RNTI     8
 #define SC_RNTI     9

common/utils/T/tracer/record.c

@@ -11,6 +11,7 @@
 #include "utils.h"
 #include "../T_defs.h"
 #include "configuration.h"
+#include "common/platform_types.h"
 
 void usage(void)
 {
@@ -39,7 +40,7 @@ static int socket = -1;
 
 void force_stop(int x)
 {
-  printf("\ngently quit...\n");
+  printf("\ngently quit (%d)...\n", x);
   close(socket);
   socket = -1;
   run = 0;

common/utils/T/tracer/record_db.cpp

@@ -249,7 +249,7 @@ static int socket_fd = -1;
 
 void force_stop(int x)
 {
-  logi("gently quit...");
+  logi("gently quit %d", x);
   close(socket_fd);
   socket_fd = -1;
   run = 0;
@@ -785,12 +785,7 @@ uint8_t should_insert(EventBuffer &buf)
   return 0;
 }
 
-int insert_event(clickhouse_config_t *ch,
-                 void *database,
-                 int event_id,
-                 const char *event_data,
-                 int data_length,
-                 std::chrono::high_resolution_clock::time_point t_start)
+int insert_event(clickhouse_config_t *ch, int event_id, const char *event_data, int data_length)
 {
   auto t_fn_start = std::chrono::high_resolution_clock::now();
 
@@ -1270,14 +1265,12 @@ int main(int n, char **v)
     if (fullread(socket_fd, v + vpos, length) == -1)
       goto read_error;
 
-    auto t_start = std::chrono::high_resolution_clock::now();
-
     if (type == -1) {
       append_received_config_chunk(v + vpos, length);
     } else if (type == -2) {
       verify_config();
     } else if (type >= 0 && type < number_of_events && is_on[type]) {
-      if (insert_event(&ch_config, database, type, v + vpos, length, t_start) != 0) {
+      if (insert_event(&ch_config, type, v + vpos, length) != 0) {
         loge("Failed to insert event type {}", type);
       }
     }

common/utils/T/tracer/ue.c

@@ -417,7 +417,7 @@ static void ue_main_gui(ue_gui *e, gui *g, event_handler *h, void *database,
   for (i = 0; i < 8; i++)
     timeline_set_subline_background_color(g, timeline_plot, i,
         new_color(g, i==0 || i==4 ? "#aaf" : "#eee"));
-  timeview = new_view_time(3600, 10, g, timeline_plot);
+  timeview = new_view_time(10, g, timeline_plot);
   /* DL tick logging */
   timelog = new_timelog(h, database, "UE_PHY_DL_TICK");
   subview = new_subview_time(timeview, 0, new_color(g, "#77c"), 3600*1000);

common/utils/T/tracer/vcd.c

@@ -100,7 +100,7 @@ static void vcd_main_gui(gui *g, event_handler *h, void *database)
   for (i = 0; i < nb_functions; i++)
     timeline_set_subline_background_color(g, w, i,
         new_color(g, i & 1 ? "#ddd" : "#eee"));
-  timeview = new_view_time(3600, 10, g, w);
+  timeview = new_view_time(10, g, w);
   i = 0;
   for (j = 0; j < n; j++) {
     if (strncmp(ids[j], "VCD_FUNCTION_", 13) != 0) continue;

common/utils/T/tracer/view/scrolltti.c

@@ -70,6 +70,7 @@ static void *scrolltti_thread(void *_this)
 static void clear(view *this)
 {
   /* TODO */
+  UNUSED(this);
 }
 
 static void insert(struct scrolltti *this, double value)

common/utils/T/tracer/view/stdout.c

@@ -15,6 +15,7 @@ struct stdout {
 static void clear(view *this)
 {
   /* do nothing */
+  UNUSED(this);
 }
 
 static void append(view *_this, char *s)

common/utils/T/tracer/view/textlist.c

@@ -71,6 +71,7 @@ static void *textlist_thread(void *_this)
 static void clear(view *this)
 {
   /* TODO */
+  UNUSED(this);
 }
 
 static void append(view *_this, char *s)
@@ -120,9 +121,11 @@ static void scroll(void *private, gui *g,
   if (pthread_mutex_unlock(&this->lock)) abort();
 }
 
-static void click(void *private, gui *g,
-    char *notification, widget *w, void *notification_data)
+static void click(void *private, gui *g, char *notification, widget *w, void *notification_data)
 {
+  UNUSED(notification);
+  UNUSED(g);
+  UNUSED(w);
   struct textlist *this = private;
   int *d = notification_data;
   int button = d[1];

common/utils/T/tracer/view/ticktime.c

@@ -164,9 +164,10 @@ static void *ticktime_thread(void *_this)
   return 0;
 }
 
-static void scroll(void *private, gui *g,
-    char *notification, widget *w, void *notification_data)
+static void scroll(void *private, gui *g, char *notification, widget *w, void *notification_data)
 {
+  UNUSED(g);
+  UNUSED(w);
   struct ticktime *this = private;
   int *d = notification_data;
   int x = d[0];
@@ -225,9 +226,11 @@ end:
   if (pthread_mutex_unlock(&this->lock)) abort();
 }
 
-static void click(void *private, gui *g,
-    char *notification, widget *w, void *notification_data)
+static void click(void *private, gui *g, char *notification, widget *w, void *notification_data)
 {
+  UNUSED(g);
+  UNUSED(w);
+  UNUSED(notification);
   struct ticktime *this = private;
   int *d = notification_data;
   int button = *d;
@@ -365,9 +368,9 @@ struct clock_ticktime {
   struct ticktime *parent;
 };
 
-static void clock_append(view *_this, struct timespec t,
-    int frame, int subframe)
+static void clock_append(view *_this, struct timespec t, int frame, int subframe)
 {
+  UNUSED(t);
   struct clock_ticktime *this = (struct clock_ticktime *)_this;
   struct ticktime *tt = this->parent;
   int64_t diff;

common/utils/T/tracer/view/time.c

@@ -156,9 +156,10 @@ static void *time_thread(void *_this)
   return 0;
 }
 
-static void scroll(void *private, gui *g,
-    char *notification, widget *w, void *notification_data)
+static void scroll(void *private, gui *g, char *notification, widget *w, void *notification_data)
 {
+  UNUSED(g);
+  UNUSED(w);
   struct time *this = private;
   int *d = notification_data;
   int x = d[0];
@@ -217,9 +218,11 @@ end:
   if (pthread_mutex_unlock(&this->lock)) abort();
 }
 
-static void click(void *private, gui *g,
-    char *notification, widget *w, void *notification_data)
+static void click(void *private, gui *g, char *notification, widget *w, void *notification_data)
 {
+  UNUSED(g);
+  UNUSED(w);
+  UNUSED(notification);
   struct time *this = private;
   int *d = notification_data;
   int button = *d;
@@ -228,8 +231,7 @@ static void click(void *private, gui *g,
   if (button == 1) this->autoscroll = 1;
 }
 
-view *new_view_time(int number_of_seconds, float refresh_rate,
-    gui *g, widget *w)
+view *new_view_time(float refresh_rate, gui *g, widget *w)
 {
   struct time *ret = calloc(1, sizeof(struct time));
   if (ret == NULL) abort();

common/utils/T/tracer/view/tti.c

@@ -94,6 +94,7 @@ static void *tti_thread(void *_this)
 static void clear(view *this)
 {
   /* TODO */
+  UNUSED(this);
 }
 
 static void append(view *_this, int frame, int tick, double value)

common/utils/T/tracer/view/view.h

@@ -6,6 +6,7 @@
 #define _VIEW_H_
 
 #include "gui/gui.h"
+#include "common/platform_types.h"
 
 /* defines the public API of views */
 
@@ -19,14 +20,10 @@ enum xy_mode { XY_LOOP_MODE, XY_FORCED_MODE };
 
 view *new_view_stdout(void);
 view *new_view_textlist(int maxsize, float refresh_rate, gui *g, widget *w);
-view *new_view_xy(int length, float refresh_rate, gui *g, widget *w,
-    int color, enum xy_mode mode);
-view *new_view_tti(float refresh_rate, gui *g, widget *w, int color,
-    int ticks_per_frame);
-view *new_view_scrolltti(float refresh_rate, gui *g, widget *w,
-    int color, widget *throughput_label, int ticks_per_frame);
-view *new_view_time(int number_of_seconds, float refresh_rate,
-    gui *g, widget *w);
+view *new_view_xy(int length, float refresh_rate, gui *g, widget *w, int color, enum xy_mode mode);
+view *new_view_tti(float refresh_rate, gui *g, widget *w, int color, int ticks_per_frame);
+view *new_view_scrolltti(float refresh_rate, gui *g, widget *w, int color, widget *throughput_label, int ticks_per_frame);
+view *new_view_time(float refresh_rate, gui *g, widget *w);
 view *new_subview_time(view *time, int line, int color, int size);
 view *new_view_ticktime(float refresh_rate, gui *g, widget *w);
 view *new_subview_ticktime(view *ticktime, int line, int color, int size);

common/utils/T/tracer/view/xy.c

@@ -42,6 +42,7 @@ static void *xy_thread(void *_this)
 static void clear(view *this)
 {
   /* TODO */
+  UNUSED(this);
 }
 
 static void append_loop(view *_this, float *x, float *y, int length)