From 83838962fd51748781a8d2fe03b2efa561672825 Mon Sep 17 00:00:00 2001 From: Robert Schmidt Date: Tue, 1 Oct 2024 10:45:22 +0200 Subject: [PATCH] Aerial: Avoid superfluous memcpy(), reduce scope MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We can directly read from buffers, so the memcpy() only takes time. Also, limit the scope of the variables for the unpacking of RX_DATA.indication. Co-authored-by: Rúben Soares Silva --- nfapi/oai_integration/aerial/fapi_nvIPC.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/nfapi/oai_integration/aerial/fapi_nvIPC.c b/nfapi/oai_integration/aerial/fapi_nvIPC.c index 46a28c440e..a1de610c03 100644 --- a/nfapi/oai_integration/aerial/fapi_nvIPC.c +++ b/nfapi/oai_integration/aerial/fapi_nvIPC.c @@ -102,16 +102,8 @@ static int ipc_handle_rx_msg(nv_ipc_t *ipc, nv_ipc_msg_t *msg) } } - int messageBufLen = msg->msg_len; - int dataBufLen = msg->data_len; - uint8_t msgbuf[messageBufLen]; - uint8_t databuf[dataBufLen]; - memcpy(msgbuf, msg->msg_buf, messageBufLen); - memcpy(databuf, msg->data_buf, dataBufLen); - uint8_t *pReadPackedMessage = msgbuf; - uint8_t *pReadData = databuf; - uint8_t *end = msgbuf + messageBufLen; - uint8_t *data_end = databuf + dataBufLen; + uint8_t *pReadPackedMessage = msg->msg_buf; + uint8_t *end = msg->msg_buf + msg->msg_len; // unpack FAPI messages and handle them if (vnf_config != 0) { @@ -209,6 +201,9 @@ static int ipc_handle_rx_msg(nv_ipc_t *ipc, nv_ipc_msg_t *msg) } case NFAPI_NR_PHY_MSG_TYPE_RX_DATA_INDICATION: { + uint8_t *pReadData = msg->data_buf; + int dataBufLen = msg->data_len; + uint8_t *data_end = msg->data_buf + dataBufLen; nfapi_nr_rx_data_indication_t ind; ind.header.message_id = fapi_msg.message_id; ind.header.message_length = fapi_msg.message_length;