From 8a97d9472596fa2c43ada1695a0ba65d45b57e30 Mon Sep 17 00:00:00 2001 From: Rakesh Mundlamuri Date: Wed, 17 Dec 2025 17:25:03 +0530 Subject: [PATCH] Add F1AP positioning measurement failure message enc/dec + test Reference: 3GPP 38.473 v16.21.0 Mandatory fields: Transaction ID (supported) LMF Measurement ID (supported) RAN Measurement ID (supported) Cause (supported) Optional fields: Criticality Diagnostics (not supported) --- openair2/COMMON/f1ap_messages_types.h | 12 +++ openair2/F1AP/lib/f1ap_positioning.c | 142 ++++++++++++++++++++++++++ openair2/F1AP/lib/f1ap_positioning.h | 8 ++ openair2/F1AP/tests/f1ap_lib_test.c | 32 ++++++ 4 files changed, 194 insertions(+) diff --git a/openair2/COMMON/f1ap_messages_types.h b/openair2/COMMON/f1ap_messages_types.h index fc8587c35c..042e0ce73d 100644 --- a/openair2/COMMON/f1ap_messages_types.h +++ b/openair2/COMMON/f1ap_messages_types.h @@ -1547,4 +1547,16 @@ typedef struct f1ap_positioning_measurement_resp_s { f1ap_pos_measurement_result_list_t *pos_measurement_result_list; } f1ap_positioning_measurement_resp_t; +typedef struct f1ap_positioning_measurement_failure_s { + // IE 9.3.1.23 (mandatory) + uint8_t transaction_id; + // (mandatory) + uint16_t lmf_measurement_id; + // (mandatory) + uint16_t ran_measurement_id; + // IE 9.3.1.2 (mandatory) + f1ap_Cause_t cause; + // IE 9.3.1.2 (mandatory) + long cause_value; +} f1ap_positioning_measurement_failure_t; #endif /* F1AP_MESSAGES_TYPES_H_ */ diff --git a/openair2/F1AP/lib/f1ap_positioning.c b/openair2/F1AP/lib/f1ap_positioning.c index c8a7cfee72..57a8add74d 100644 --- a/openair2/F1AP/lib/f1ap_positioning.c +++ b/openair2/F1AP/lib/f1ap_positioning.c @@ -5639,3 +5639,145 @@ void free_positioning_measurement_resp(f1ap_positioning_measurement_resp_t *msg) free(msg->pos_measurement_result_list); } } + +/** + * @brief Encode F1 positioning measurement failure to ASN.1 + */ +F1AP_F1AP_PDU_t *encode_positioning_measurement_failure(const f1ap_positioning_measurement_failure_t *msg) +{ + F1AP_F1AP_PDU_t *pdu = calloc_or_fail(1, sizeof(*pdu)); + + /* Message Type */ + pdu->present = F1AP_F1AP_PDU_PR_unsuccessfulOutcome; + asn1cCalloc(pdu->choice.unsuccessfulOutcome, tmp); + tmp->procedureCode = F1AP_ProcedureCode_id_PositioningMeasurementExchange; + tmp->criticality = F1AP_Criticality_reject; + tmp->value.present = F1AP_UnsuccessfulOutcome__value_PR_PositioningMeasurementFailure; + F1AP_PositioningMeasurementFailure_t *out = &tmp->value.choice.PositioningMeasurementFailure; + + /* mandatory : TransactionID */ + asn1cSequenceAdd(out->protocolIEs.list, F1AP_PositioningMeasurementFailureIEs_t, ie1); + ie1->id = F1AP_ProtocolIE_ID_id_TransactionID; + ie1->criticality = F1AP_Criticality_reject; + ie1->value.present = F1AP_PositioningMeasurementFailureIEs__value_PR_TransactionID; + ie1->value.choice.TransactionID = msg->transaction_id; + + /* mandatory : LMF_MeasurementID */ + asn1cSequenceAdd(out->protocolIEs.list, F1AP_PositioningMeasurementFailureIEs_t, ie2); + ie2->id = F1AP_ProtocolIE_ID_id_LMF_MeasurementID; + ie2->criticality = F1AP_Criticality_reject; + ie2->value.present = F1AP_PositioningMeasurementFailureIEs__value_PR_LMF_MeasurementID; + ie2->value.choice.LMF_MeasurementID = msg->lmf_measurement_id; + + /* mandatory : RAN_MeasurementID */ + asn1cSequenceAdd(out->protocolIEs.list, F1AP_PositioningMeasurementFailureIEs_t, ie3); + ie3->id = F1AP_ProtocolIE_ID_id_RAN_MeasurementID; + ie3->criticality = F1AP_Criticality_reject; + ie3->value.present = F1AP_PositioningMeasurementFailureIEs__value_PR_RAN_MeasurementID; + ie3->value.choice.RAN_MeasurementID = msg->ran_measurement_id; + + /* mandatory : Cause */ + asn1cSequenceAdd(out->protocolIEs.list, F1AP_PositioningMeasurementFailureIEs_t, ie4); + ie4->id = F1AP_ProtocolIE_ID_id_Cause; + ie4->criticality = F1AP_Criticality_ignore; + ie4->value.present = F1AP_PositioningMeasurementFailureIEs__value_PR_Cause; + ie4->value.choice.Cause = encode_f1ap_cause(msg->cause, msg->cause_value); + + return pdu; +} + +/** + * @brief Decode F1 positioning measurement failure + */ +bool decode_positioning_measurement_failure(const F1AP_F1AP_PDU_t *pdu, f1ap_positioning_measurement_failure_t *out) +{ + DevAssert(out != NULL); + memset(out, 0, sizeof(*out)); + + F1AP_PositioningMeasurementFailure_t *in = &pdu->choice.unsuccessfulOutcome->value.choice.PositioningMeasurementFailure; + F1AP_PositioningMeasurementFailureIEs_t *ie; + + F1AP_LIB_FIND_IE(F1AP_PositioningMeasurementFailureIEs_t, ie, &in->protocolIEs.list, F1AP_ProtocolIE_ID_id_TransactionID, true); + F1AP_LIB_FIND_IE(F1AP_PositioningMeasurementFailureIEs_t, + ie, + &in->protocolIEs.list, + F1AP_ProtocolIE_ID_id_LMF_MeasurementID, + true); + F1AP_LIB_FIND_IE(F1AP_PositioningMeasurementFailureIEs_t, + ie, + &in->protocolIEs.list, + F1AP_ProtocolIE_ID_id_RAN_MeasurementID, + true); + F1AP_LIB_FIND_IE(F1AP_PositioningMeasurementFailureIEs_t, ie, &in->protocolIEs.list, F1AP_ProtocolIE_ID_id_Cause, true); + + for (int i = 0; i < in->protocolIEs.list.count; ++i) { + ie = in->protocolIEs.list.array[i]; + AssertError(ie != NULL, return false, "in->protocolIEs.list.array[i] is NULL"); + switch (ie->id) { + case F1AP_ProtocolIE_ID_id_TransactionID: + _F1_EQ_CHECK_INT(ie->value.present, F1AP_PositioningMeasurementFailureIEs__value_PR_TransactionID); + out->transaction_id = ie->value.choice.TransactionID; + break; + case F1AP_ProtocolIE_ID_id_LMF_MeasurementID: + _F1_EQ_CHECK_INT(ie->value.present, F1AP_PositioningMeasurementFailureIEs__value_PR_LMF_MeasurementID); + out->lmf_measurement_id = ie->value.choice.LMF_MeasurementID; + break; + case F1AP_ProtocolIE_ID_id_RAN_MeasurementID: + _F1_EQ_CHECK_INT(ie->value.present, F1AP_PositioningMeasurementFailureIEs__value_PR_RAN_MeasurementID); + out->ran_measurement_id = ie->value.choice.RAN_MeasurementID; + break; + case F1AP_ProtocolIE_ID_id_Cause: + _F1_EQ_CHECK_INT(ie->value.present, F1AP_PositioningMeasurementFailureIEs__value_PR_Cause); + _F1_CHECK_EXP(decode_f1ap_cause(ie->value.choice.Cause, &out->cause, &out->cause_value)); + break; + case F1AP_ProtocolIE_ID_id_CriticalityDiagnostics: + PRINT_ERROR("F1AP_ProtocolIE_ID_id %ld not handled, skipping\n", ie->id); + break; + default: + PRINT_ERROR("F1AP_ProtocolIE_ID_id %ld unknown, skipping\n", ie->id); + break; + } + } + + return true; +} + +/** + * @brief F1 positioning measurement failure deep copy + */ +f1ap_positioning_measurement_failure_t cp_positioning_measurement_failure(const f1ap_positioning_measurement_failure_t *orig) +{ + /* copy all mandatory fields that are not dynamic memory */ + f1ap_positioning_measurement_failure_t cp = { + .transaction_id = orig->transaction_id, + .lmf_measurement_id = orig->lmf_measurement_id, + .ran_measurement_id = orig->ran_measurement_id, + .cause = orig->cause, + .cause_value = orig->cause_value, + }; + + return cp; +} + +/** + * @brief F1 positioning measurement failure equality check + */ +bool eq_positioning_measurement_failure(const f1ap_positioning_measurement_failure_t *a, + const f1ap_positioning_measurement_failure_t *b) +{ + _F1_EQ_CHECK_INT(a->transaction_id, b->transaction_id); + _F1_EQ_CHECK_INT(a->lmf_measurement_id, b->lmf_measurement_id); + _F1_EQ_CHECK_INT(a->ran_measurement_id, b->ran_measurement_id); + _F1_EQ_CHECK_INT(a->cause, b->cause); + _F1_EQ_CHECK_LONG(a->cause_value, b->cause_value); + + return true; +} + +/** + * @brief Free Allocated F1 positioning measurement failure + */ +void free_positioning_measurement_failure(f1ap_positioning_measurement_failure_t *msg) +{ + // nothing to free +} diff --git a/openair2/F1AP/lib/f1ap_positioning.h b/openair2/F1AP/lib/f1ap_positioning.h index aefe893a29..061bb29536 100644 --- a/openair2/F1AP/lib/f1ap_positioning.h +++ b/openair2/F1AP/lib/f1ap_positioning.h @@ -120,4 +120,12 @@ bool decode_positioning_measurement_resp(const struct F1AP_F1AP_PDU *pdu, f1ap_p f1ap_positioning_measurement_resp_t cp_positioning_measurement_resp(const f1ap_positioning_measurement_resp_t *orig); bool eq_positioning_measurement_resp(const f1ap_positioning_measurement_resp_t *a, const f1ap_positioning_measurement_resp_t *b); void free_positioning_measurement_resp(f1ap_positioning_measurement_resp_t *msg); + +// positioning measurement failure +struct F1AP_F1AP_PDU *encode_positioning_measurement_failure(const f1ap_positioning_measurement_failure_t *msg); +bool decode_positioning_measurement_failure(const struct F1AP_F1AP_PDU *pdu, f1ap_positioning_measurement_failure_t *out); +f1ap_positioning_measurement_failure_t cp_positioning_measurement_failure(const f1ap_positioning_measurement_failure_t *orig); +bool eq_positioning_measurement_failure(const f1ap_positioning_measurement_failure_t *a, + const f1ap_positioning_measurement_failure_t *b); +void free_positioning_measurement_failure(f1ap_positioning_measurement_failure_t *msg); #endif /* F1AP_POSITIONING_H_ */ diff --git a/openair2/F1AP/tests/f1ap_lib_test.c b/openair2/F1AP/tests/f1ap_lib_test.c index 64f95b2967..ed70b6ea9b 100644 --- a/openair2/F1AP/tests/f1ap_lib_test.c +++ b/openair2/F1AP/tests/f1ap_lib_test.c @@ -2135,6 +2135,37 @@ static void test_f1ap_positioning_measurement_response() printf("%s() successful\n", __func__); } +static void test_f1ap_positioning_measurement_failure() +{ + f1ap_positioning_measurement_failure_t orig = { + .transaction_id = 12, + .lmf_measurement_id = 1999, + .ran_measurement_id = 2225, + .cause = F1AP_CAUSE_MISC, + .cause_value = 3, + }; + F1AP_F1AP_PDU_t *f1enc = encode_positioning_measurement_failure(&orig); + F1AP_F1AP_PDU_t *f1dec = f1ap_encode_decode(f1enc); + f1ap_msg_free(f1enc); + + f1ap_positioning_measurement_failure_t decoded = {0}; + bool ret = decode_positioning_measurement_failure(f1dec, &decoded); + AssertFatal(ret, "decode_positioning_measurement_failure(): could not decode message\n"); + f1ap_msg_free(f1dec); + + ret = eq_positioning_measurement_failure(&orig, &decoded); + AssertFatal(ret, "eq_positioning_measurement_failure(): decoded message doesn't match\n"); + free_positioning_measurement_failure(&decoded); + + f1ap_positioning_measurement_failure_t cp = cp_positioning_measurement_failure(&orig); + ret = eq_positioning_measurement_failure(&orig, &cp); + AssertFatal(ret, "eq_positioning_measurement_failure(): copied message doesn't match\n"); + free_positioning_measurement_failure(&orig); + free_positioning_measurement_failure(&cp); + + printf("%s() successful\n", __func__); +} + int main() { test_initial_ul_rrc_message_transfer(); @@ -2174,5 +2205,6 @@ int main() test_f1ap_trp_information_failure(); test_f1ap_positioning_measurement_request(); test_f1ap_positioning_measurement_response(); + test_f1ap_positioning_measurement_failure(); return 0; }