From a12fdb68b7182bd3b80bbd3a2871780de28a0d23 Mon Sep 17 00:00:00 2001 From: Robert Schmidt Date: Tue, 21 May 2024 13:56:59 +0200 Subject: [PATCH] unpack_dl_tti_ssb_pdu_rel15_value(): match pack function unpack_dl_tti_ssb_pdu_rel15_value() reads two additional bytes, seemingly for RX power information. However, table 3-79 does not contain such info, so I remove to match the corresponding pack function pack_dl_tti_ssb_pdu_rel15_value(). TODO: tx power info relevant? --- nfapi/open-nFAPI/nfapi/src/nfapi_p7.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/nfapi/open-nFAPI/nfapi/src/nfapi_p7.c b/nfapi/open-nFAPI/nfapi/src/nfapi_p7.c index 5ea3e5e031..57ddbecb06 100644 --- a/nfapi/open-nFAPI/nfapi/src/nfapi_p7.c +++ b/nfapi/open-nFAPI/nfapi/src/nfapi_p7.c @@ -352,7 +352,6 @@ static uint8_t pack_dl_tti_ssb_pdu_rel15_value(void *tlv, uint8_t **ppWritePacke && push8((value->bchPayload >> 16) & 0xff, ppWritePackedMsg, end) && push8((value->bchPayload >> 8) & 0xff, ppWritePackedMsg, end) && push8(value->bchPayload & 0xff, ppWritePackedMsg, end) && push8(0, ppWritePackedMsg, end) - // TODO add Tx Power Info && push16(value->precoding_and_beamforming.num_prgs, ppWritePackedMsg, end) && push16(value->precoding_and_beamforming.prg_size, ppWritePackedMsg, end) && push8(value->precoding_and_beamforming.dig_bf_interfaces, ppWritePackedMsg, end))) { @@ -4095,9 +4094,8 @@ static uint8_t unpack_dl_tti_ssb_pdu_rel15_value(void *tlv, uint8_t **ppReadPack value->bchPayload |= byte2; value->bchPayload = value->bchPayload << 8; value->bchPayload |= byte1; - // TODO add Tx Power Info - if (!(pull8(ppReadPackedMsg, &byte1, end) && pull8(ppReadPackedMsg, &byte0, end) - && pull16(ppReadPackedMsg, &value->precoding_and_beamforming.num_prgs, end) + + if (!(pull16(ppReadPackedMsg, &value->precoding_and_beamforming.num_prgs, end) && pull16(ppReadPackedMsg, &value->precoding_and_beamforming.prg_size, end) && pull8(ppReadPackedMsg, &value->precoding_and_beamforming.dig_bf_interfaces, end))) { return 0;