maki/openairinterface5g
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug fixes from Fujitsu (bug 24)

Browse Source 
----------------------------------------------------------
bug 24

Ttile:
The last line "multicast_group = multicast_group" is hard
to understand. The local variable should be different name
than the global variable.

Bug Location:
const char *multicast_group_list[MULTICAST_LINK_NUM_GROUPS] = {
  "239.0.0.161",
  "239.0.0.162",
  "239.0.0.163",
  "239.0.0.164"
};
:
:
void multicast_link_start(void (*rx_handlerP) (unsigned int, char *),
                          unsigned char multicast_group, char *multicast_ifname)
{
  rx_handler = rx_handlerP;
  multicast_group = multicast_group;

Note:
Detected by CppCheck
----------------------------------------------------------
This commit is contained in:
Cedric Roux
2017-05-12 11:52:52 +02:00
parent 34c6805f7a
commit adb3b25c67
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
openair1/SIMULATION/ETH_TRANSPORT/multicast_link.c
+2 -2
View File
@@ -308,10 +308,10 @@ void* multicast_link_main_loop (void *param)
} }
void multicast_link_start(void (*rx_handlerP) (unsigned int, char *), void multicast_link_start(void (*rx_handlerP) (unsigned int, char *),
unsigned char multicast_group, char *multicast_ifname) unsigned char _multicast_group, char *multicast_ifname)
{ {
rx_handler = rx_handlerP; rx_handler = rx_handlerP;
multicast_group = multicast_group; multicast_group = _multicast_group;
multicast_if = multicast_ifname; multicast_if = multicast_ifname;
LOG_I(EMU, "[MULTICAST] LINK START on interface=%s for group=%d: handler=%p\n", LOG_I(EMU, "[MULTICAST] LINK START on interface=%s for group=%d: handler=%p\n",
(multicast_if == NULL) ? "not specified" : multicast_if, multicast_group, (multicast_if == NULL) ? "not specified" : multicast_if, multicast_group,