Move functions for packing/unpacking RACH.indication

Changed parameter in unpack function to be inline with other unpack functions.
Changed nfapi_p7_allocate call to calloc to avoid dependency to NFAPI_LIB.

Added unitary test for RACH.indication( test pack/unpack, free, copy and compare )
Added constant NFAPI_NR_RACH_IND_MAX_PDU to follow constants related to other P7 messages limiting the maximum number of PDUs to use.

Removed now unneeded dependency to NFAPI_LIB and NFAPI_USER_LIB

nfapi/tests/p7/CMakeLists.txt

@@ -1,5 +1,5 @@
 set(Test_Labels fapi p7)
-set(_fapi_p7_messages "dci_inversion;dl_tti_request;ul_tti_request;slot_indication;ul_dci_request;tx_data_request;rx_data_indication;crc_indication;uci_indication;srs_indication")
+set(_fapi_p7_messages "dci_inversion;dl_tti_request;ul_tti_request;slot_indication;ul_dci_request;tx_data_request;rx_data_indication;crc_indication;uci_indication;srs_indication;rach_indication")
 foreach (fapi_p7_message IN LISTS _fapi_p7_messages)
     add_executable(nr_fapi_${fapi_p7_message}_test nr_fapi_${fapi_p7_message}_test.c)
     target_link_libraries(nr_fapi_${fapi_p7_message}_test PUBLIC nr_fapi_p7)

nfapi/tests/p7/nr_fapi_rach_indication_test.c

@@ -0,0 +1,115 @@
+/*
+ * Licensed to the OpenAirInterface (OAI) Software Alliance under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The OpenAirInterface Software Alliance licenses this file to You under
+ * the OAI Public License, Version 1.1  (the "License"); you may not use this file
+ * except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.openairinterface.org/?page_id=698
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *-------------------------------------------------------------------------------
+ * For more information about the OpenAirInterface (OAI) Software Alliance:
+ *      contact@openairinterface.org
+ */
+#include "dci_payload_utils.h"
+#include "nr_fapi_p7.h"
+#include "nr_fapi_p7_utils.h"
+
+static void fill_rach_indication_PDU(nfapi_nr_prach_indication_pdu_t *pdu)
+{
+  pdu->phy_cell_id = rand32();
+  pdu->symbol_index = rand8_range(0,13);
+  pdu->slot_index = rand8_range(0,79);
+  pdu->freq_index = rand8_range(0,7);
+  pdu->avg_rssi = rand8();
+  pdu->avg_snr = rand8();
+  pdu->num_preamble = rand8_range(0,63);
+  for (int preamble_idx = 0; preamble_idx < pdu->num_preamble; ++preamble_idx) {
+    nfapi_nr_prach_indication_preamble_t *preamble = &pdu->preamble_list[preamble_idx];
+    preamble->preamble_index = rand8_range(0,63);
+    preamble->timing_advance = rand16_range(0,3846);
+    preamble->preamble_pwr = rand32_range(0, 170000);
+  }
+}
+
+static void fill_rach_indication(nfapi_nr_rach_indication_t *msg)
+{
+  msg->sfn = rand16_range(0, 1023);
+  msg->slot = rand16_range(0, 159);
+  msg->number_of_pdus = rand8_range(1, NFAPI_NR_RACH_IND_MAX_PDU); // Minimum 1 PDUs in order to test at least one
+  msg->pdu_list = calloc_or_fail(msg->number_of_pdus, sizeof(*msg->pdu_list));
+  for (int pdu_idx = 0; pdu_idx < msg->number_of_pdus; ++pdu_idx) {
+    fill_rach_indication_PDU(&msg->pdu_list[pdu_idx]);
+  }
+}
+
+static void test_pack_unpack(nfapi_nr_rach_indication_t *req)
+{
+  size_t message_size = get_rach_indication_size(req);
+  uint8_t *msg_buf = calloc_or_fail(message_size, sizeof(uint8_t));
+  /*uint8_t msg_buf[1024*1024*3];
+  size_t message_size = sizeof(msg_buf);*/
+  // first test the packing procedure
+  int pack_result = fapi_nr_p7_message_pack(req, msg_buf, message_size, NULL);
+
+  DevAssert(pack_result >= 0 + NFAPI_HEADER_LENGTH);
+  // update req message_length value with value calculated in message_pack procedure
+  req->header.message_length = pack_result; //- NFAPI_HEADER_LENGTH;
+  // test the unpacking of the header
+  // copy first NFAPI_HEADER_LENGTH bytes into a new buffer, to simulate SCTP PEEK
+  fapi_message_header_t header;
+  uint32_t header_buffer_size = NFAPI_HEADER_LENGTH;
+  uint8_t header_buffer[header_buffer_size];
+  for (int idx = 0; idx < header_buffer_size; idx++) {
+    header_buffer[idx] = msg_buf[idx];
+  }
+  uint8_t *pReadPackedMessage = header_buffer;
+  int unpack_header_result = fapi_nr_message_header_unpack(&pReadPackedMessage, NFAPI_HEADER_LENGTH, &header, sizeof(header), 0);
+  DevAssert(unpack_header_result >= 0);
+  DevAssert(header.message_id == req->header.message_id);
+  DevAssert(header.message_length == req->header.message_length);
+  // test the unpacking and compare with initial message
+  nfapi_nr_rach_indication_t unpacked_req = {0};
+  int unpack_result =
+      fapi_nr_p7_message_unpack(msg_buf, header.message_length + NFAPI_HEADER_LENGTH, &unpacked_req, sizeof(unpacked_req), 0);
+  DevAssert(unpack_result >= 0);
+  DevAssert(eq_rach_indication(&unpacked_req, req));
+  free_rach_indication(&unpacked_req);
+  free(msg_buf);
+}
+
+static void test_copy(const nfapi_nr_rach_indication_t *msg)
+{
+  // Test copy function
+  nfapi_nr_rach_indication_t copy = {0};
+  copy_rach_indication(msg, &copy);
+  DevAssert(eq_rach_indication(msg, &copy));
+  free_rach_indication(&copy);
+}
+
+int main(int n, char *v[])
+{
+  fapi_test_init();
+
+  nfapi_nr_rach_indication_t *req = calloc_or_fail(1, sizeof(nfapi_nr_rach_indication_t));
+  req->header.message_id = NFAPI_NR_PHY_MSG_TYPE_RACH_INDICATION;
+  // Get the actual allocated size
+  printf("Allocated size before filling: %zu bytes\n", get_rach_indication_size(req));
+  // Fill TX_DATA request
+  fill_rach_indication(req);
+  printf("Allocated size after filling: %zu bytes\n", get_rach_indication_size(req));
+  // Perform tests
+  test_pack_unpack(req);
+  test_copy(req);
+  // All tests successful!
+  free_rach_indication(req);
+  free(req);
+  return 0;
+}