maki/openairinterface5g
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: repair RC.mac memory allocation

Browse Source 
- there can be a race between the FlexRAN agent reading the RC.mac and its
  allocation in main.c
- In order to circumvent this, change the allocation by allocating
  everything "into" a local variable
- finally "make it visible" by storing  the pointer in RC.mac
This commit is contained in:
Robert Schmidt
2018-09-03 18:10:28 +02:00
parent 62957b97d8
commit da35afb01b
1 changed files with 83 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files
openair2/LAYER2/MAC/main.c
+83 -103
View File
@@ -46,122 +46,102 @@
extern RAN_CONTEXT_t RC; extern RAN_CONTEXT_t RC;
void mac_top_init_eNB(void) void mac_top_init_eNB(void)
{ {
module_id_t i, j;
int list_el;
UE_list_t *UE_list;
slice_info_t *sli;
eNB_MAC_INST **mac;
module_id_t i, j; LOG_I(MAC, "[MAIN] Init function start:nb_macrlc_inst=%d\n",
int list_el; RC.nb_macrlc_inst);
UE_list_t *UE_list;
slice_info_t *sli;
eNB_MAC_INST *mac;
LOG_I(MAC, "[MAIN] Init function start:nb_macrlc_inst=%d\n", if (RC.nb_macrlc_inst <= 0) {
RC.nb_macrlc_inst); RC.mac = NULL;
return;
}
if (RC.nb_macrlc_inst > 0) { mac = malloc16(RC.nb_macrlc_inst * sizeof(eNB_MAC_INST *));
if (RC.mac == NULL){ AssertFatal(mac != NULL,
RC.mac = "can't ALLOCATE %zu Bytes for %d eNB_MAC_INST with size %zu \n",
(eNB_MAC_INST **) malloc16(RC.nb_macrlc_inst * RC.nb_macrlc_inst * sizeof(eNB_MAC_INST *),
sizeof(eNB_MAC_INST *)); RC.nb_macrlc_inst, sizeof(eNB_MAC_INST));
bzero(RC.mac, RC.nb_macrlc_inst * sizeof(eNB_MAC_INST *)); for (i = 0; i < RC.nb_macrlc_inst; i++) {
} mac[i] = malloc16(sizeof(eNB_MAC_INST));
AssertFatal(RC.mac != NULL, AssertFatal(mac[i] != NULL,
"can't ALLOCATE %zu Bytes for %d eNB_MAC_INST with size %zu \n", "can't ALLOCATE %zu Bytes for %d eNB_MAC_INST with size %zu \n",
RC.nb_macrlc_inst * sizeof(eNB_MAC_INST *), RC.nb_macrlc_inst * sizeof(eNB_MAC_INST *),
RC.nb_macrlc_inst, sizeof(eNB_MAC_INST)); RC.nb_macrlc_inst, sizeof(eNB_MAC_INST));
for (i = 0; i < RC.nb_macrlc_inst; i++) { LOG_D(MAC,
if (RC.mac[i] == NULL) { "[MAIN] ALLOCATE %zu Bytes for %d eNB_MAC_INST @ %p\n",
RC.mac[i] = (eNB_MAC_INST *) malloc16(sizeof(eNB_MAC_INST)); sizeof(eNB_MAC_INST), RC.nb_macrlc_inst, mac);
AssertFatal(RC.mac[i] != NULL, bzero(mac[i], sizeof(eNB_MAC_INST));
"can't ALLOCATE %zu Bytes for %d eNB_MAC_INST with size %zu \n", mac[i]->Mod_id = i;
RC.nb_macrlc_inst * sizeof(eNB_MAC_INST *), for (j = 0; j < MAX_NUM_CCs; j++) {
RC.nb_macrlc_inst, sizeof(eNB_MAC_INST)); mac[i]->DL_req[j].dl_config_request_body.dl_config_pdu_list =
LOG_D(MAC, mac[i]->dl_config_pdu_list[j];
"[MAIN] ALLOCATE %zu Bytes for %d eNB_MAC_INST @ %p\n", mac[i]->UL_req[j].ul_config_request_body.ul_config_pdu_list =
sizeof(eNB_MAC_INST), RC.nb_macrlc_inst, RC.mac); mac[i]->ul_config_pdu_list[j];
bzero(RC.mac[i], sizeof(eNB_MAC_INST)); for (int k = 0; k < 10; k++)
} mac[i]->UL_req_tmp[j][k].ul_config_request_body.ul_config_pdu_list =
RC.mac[i]->Mod_id = i; mac[i]->ul_config_pdu_list_tmp[j][k];
for (j = 0; j < MAX_NUM_CCs; j++) { for(int sf=0;sf<10;sf++)
RC.mac[i]->DL_req[j].dl_config_request_body. mac[i]->HI_DCI0_req[j][sf].hi_dci0_request_body.hi_dci0_pdu_list =
dl_config_pdu_list = RC.mac[i]->dl_config_pdu_list[j]; mac[i]->hi_dci0_pdu_list[j][sf];
RC.mac[i]->UL_req[j].ul_config_request_body. mac[i]->TX_req[j].tx_request_body.tx_pdu_list = mac[i]->tx_request_pdu[j];
ul_config_pdu_list = RC.mac[i]->ul_config_pdu_list[j]; mac[i]->ul_handle = 0;
for (int k = 0; k < 10; k++)
RC.mac[i]->UL_req_tmp[j][k].
ul_config_request_body.ul_config_pdu_list =
RC.mac[i]->ul_config_pdu_list_tmp[j][k];
for(int sf=0;sf<10;sf++){
RC.mac[i]->HI_DCI0_req[j][sf].hi_dci0_request_body.hi_dci0_pdu_list =RC.mac[i]->hi_dci0_pdu_list[j][sf];
}
RC.mac[i]->TX_req[j].tx_request_body.tx_pdu_list =
RC.mac[i]->tx_request_pdu[j];
RC.mac[i]->ul_handle = 0;
}
}
AssertFatal(rlc_module_init() == 0,
"Could not initialize RLC layer\n");
// These should be out of here later
pdcp_layer_init();
rrc_init_global_param();
} else {
RC.mac = NULL;
} }
// Initialize Linked-List for Active UEs and slice configuration mac[i]->if_inst = IF_Module_init(i);
for (i = 0; i < RC.nb_macrlc_inst; i++) {
mac = RC.mac[i];
UE_list = &mac[i]->UE_list;
UE_list->num_UEs = 0;
UE_list->head = -1;
UE_list->head_ul = -1;
UE_list->avail = 0;
mac->if_inst = IF_Module_init(i); for (list_el = 0; list_el < MAX_MOBILES_PER_ENB - 1; list_el++) {
UE_list = &mac->UE_list;
UE_list->num_UEs = 0;
UE_list->head = -1;
UE_list->head_ul = -1;
UE_list->avail = 0;
for (list_el = 0; list_el < MAX_MOBILES_PER_ENB - 1; list_el++) {
UE_list->next[list_el] = list_el + 1; UE_list->next[list_el] = list_el + 1;
UE_list->next_ul[list_el] = list_el + 1; UE_list->next_ul[list_el] = list_el + 1;
}
UE_list->next[list_el] = -1;
UE_list->next_ul[list_el] = -1;
sli = &mac->slice_info;
sli->intraslice_share_active = 1;
sli->interslice_share_active = 1;
sli->n_dl = 1;
memset(sli->dl, 0, sizeof(slice_sched_conf_dl_t) * MAX_NUM_SLICES);
sli->dl[0].pct = 1.0;
sli->dl[0].prio = 10;
sli->dl[0].pos_high = N_RBG_MAX;
sli->dl[0].maxmcs = 28;
sli->dl[0].sorting = 0x012345;
sli->dl[0].sched_name = "schedule_ue_spec";
sli->dl[0].sched_cb = dlsym(NULL, sli->dl[0].sched_name);
AssertFatal(sli->dl[0].sched_cb, "DLSCH scheduler callback is NULL\n");
sli->n_ul = 1;
memset(sli->ul, 0, sizeof(slice_sched_conf_ul_t) * MAX_NUM_SLICES);
sli->ul[0].pct = 1.0;
sli->ul[0].maxmcs = 20;
sli->ul[0].sorting = 0x0123;
sli->ul[0].sched_name = "schedule_ulsch_rnti";
sli->ul[0].sched_cb = dlsym(NULL, sli->ul[0].sched_name);
AssertFatal(sli->ul[0].sched_cb, "ULSCH scheduler callback is NULL\n");
} }
UE_list->next[list_el] = -1;
UE_list->next_ul[list_el] = -1;
sli = &mac[i]->slice_info;
sli->intraslice_share_active = 1;
sli->interslice_share_active = 1;
sli->n_dl = 1;
memset(sli->dl, 0, sizeof(slice_sched_conf_dl_t) * MAX_NUM_SLICES);
sli->dl[0].pct = 1.0;
sli->dl[0].prio = 10;
sli->dl[0].pos_high = N_RBG_MAX;
sli->dl[0].maxmcs = 28;
sli->dl[0].sorting = 0x012345;
sli->dl[0].sched_name = "schedule_ue_spec";
sli->dl[0].sched_cb = dlsym(NULL, sli->dl[0].sched_name);
AssertFatal(sli->dl[0].sched_cb, "DLSCH scheduler callback is NULL\n");
sli->n_ul = 1;
memset(sli->ul, 0, sizeof(slice_sched_conf_ul_t) * MAX_NUM_SLICES);
sli->ul[0].pct = 1.0;
sli->ul[0].maxmcs = 20;
sli->ul[0].sorting = 0x0123;
sli->ul[0].sched_name = "schedule_ulsch_rnti";
sli->ul[0].sched_cb = dlsym(NULL, sli->ul[0].sched_name);
AssertFatal(sli->ul[0].sched_cb, "ULSCH scheduler callback is NULL\n");
}
RC.mac = mac;
AssertFatal(rlc_module_init() == 0,
"Could not initialize RLC layer\n");
// These should be out of here later
pdcp_layer_init();
rrc_init_global_param();
} }
void mac_init_cell_params(int Mod_idP, int CC_idP) void mac_init_cell_params(int Mod_idP, int CC_idP)