From e0eac2e3319fd51ef0c6c101e2dffff24ba738b4 Mon Sep 17 00:00:00 2001 From: Cedric Roux Date: Thu, 4 Jul 2019 14:47:11 +0200 Subject: [PATCH] hotfix: do not set s-Measure in measurement report configuration The value was set to 20 which means -120 dB. Setting this value means that the UE reports an event only if the RSRP of the serving cell is lower than -120 dB. In the lab, we get values of around -70, and to go as low as -120 means a very degraded environment. This is not practical. Let's disactivate the setting of this parameter for the moment so that the UE reports an event without taking into consideration the RSRP of the serving cell. With this hotfix, the X2 handover works much better. --- openair2/RRC/LTE/rrc_eNB.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/openair2/RRC/LTE/rrc_eNB.c b/openair2/RRC/LTE/rrc_eNB.c index 230b9511f0..6a038c51a0 100644 --- a/openair2/RRC/LTE/rrc_eNB.c +++ b/openair2/RRC/LTE/rrc_eNB.c @@ -1893,8 +1893,15 @@ rrc_eNB_process_RRCConnectionReestablishmentComplete( ReportConfig_A5->reportConfig.choice.reportConfigEUTRA.reportAmount = LTE_ReportConfigEUTRA__reportAmount_infinity; ASN_SEQUENCE_ADD(&ReportConfig_list->list, ReportConfig_A5); // LTE_RRCConnectionReconfiguration->criticalExtensions.choice.c1.choice.rrcConnectionReconfiguration_r8.measConfig->reportConfigToAddModList = ReportConfig_list; +#if 0 + /* TODO: set a proper value. + * 20 means: UE does not report if RSRP of serving cell is higher + * than -120 dB (see 36.331 5.5.3.1). + * This is too low for the X2 handover experiment. + */ rsrp = CALLOC(1, sizeof(LTE_RSRP_Range_t)); *rsrp = 20; +#endif Sparams = CALLOC(1, sizeof(*Sparams)); Sparams->present = LTE_MeasConfig__speedStatePars_PR_setup; Sparams->choice.setup.timeToTrigger_SF.sf_High = LTE_SpeedStateScaleFactors__sf_Medium_oDot75; @@ -3416,8 +3423,15 @@ void rrc_eNB_generate_defaultRRCConnectionReconfiguration(const protocol_ctxt_t ReportConfig_A5->reportConfig.choice.reportConfigEUTRA.reportAmount = LTE_ReportConfigEUTRA__reportAmount_infinity; ASN_SEQUENCE_ADD(&ReportConfig_list->list, ReportConfig_A5); // LTE_RRCConnectionReconfiguration->criticalExtensions.choice.c1.choice.rrcConnectionReconfiguration_r8.measConfig->reportConfigToAddModList = ReportConfig_list; +#if 0 + /* TODO: set a proper value. + * 20 means: UE does not report if RSRP of serving cell is higher + * than -120 dB (see 36.331 5.5.3.1). + * This is too low for the X2 handover experiment. + */ rsrp = CALLOC(1, sizeof(LTE_RSRP_Range_t)); *rsrp = 20; +#endif Sparams = CALLOC(1, sizeof(*Sparams)); Sparams->present = LTE_MeasConfig__speedStatePars_PR_setup; Sparams->choice.setup.timeToTrigger_SF.sf_High = LTE_SpeedStateScaleFactors__sf_Medium_oDot75; @@ -5401,8 +5415,15 @@ rrc_eNB_generate_HO_RRCConnectionReconfiguration(const protocol_ctxt_t *const ct ReportConfig_A5->reportConfig.choice.reportConfigEUTRA.reportAmount = LTE_ReportConfigEUTRA__reportAmount_infinity; ASN_SEQUENCE_ADD(&ReportConfig_list->list, ReportConfig_A5); // rrcConnectionReconfiguration->criticalExtensions.choice.c1.choice.rrcConnectionReconfiguration_r8.measConfig->reportConfigToAddModList = ReportConfig_list; +#if 0 + /* TODO: set a proper value. + * 20 means: UE does not report if RSRP of serving cell is higher + * than -120 dB (see 36.331 5.5.3.1). + * This is too low for the X2 handover experiment. + */ rsrp = CALLOC(1, sizeof(RSRP_Range_t)); *rsrp = 20; +#endif Sparams = CALLOC(1, sizeof(*Sparams)); Sparams->present = LTE_MeasConfig__speedStatePars_PR_setup; Sparams->choice.setup.timeToTrigger_SF.sf_High = LTE_SpeedStateScaleFactors__sf_Medium_oDot75;