add flag for unused function arguments in E1AP CMakeLists

openair2/E1AP/CMakeLists.txt

@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: LicenseRef-CSSL-1.0
 
+add_compile_options(-Wunused-parameter)
 add_subdirectory(MESSAGES)
 add_subdirectory(lib)
 

openair2/E1AP/e1ap.c

@@ -103,46 +103,6 @@ static void e1_task_handle_sctp_data_ind(instance_t instance, sctp_data_ind_t *s
   AssertFatal(result == EXIT_SUCCESS, "Failed to free memory (%d)!\n", result);
 }
 
-int e1ap_send_RESET(bool isCu, sctp_assoc_t assoc_id, E1AP_Reset_t *Reset)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  E1AP_E1AP_PDU_t *pdu = calloc_or_fail(1, sizeof(*pdu));
-  return e1ap_encode_send(isCu, assoc_id, pdu, 0, __func__);
-}
-
-int e1ap_send_RESET_ACKNOWLEDGE(instance_t instance, E1AP_Reset_t *Reset)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1ap_handle_RESET(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1ap_handle_RESET_ACKNOWLEDGE(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-/*
-    Error Indication
-*/
-int e1ap_handle_ERROR_INDICATION(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1ap_send_ERROR_INDICATION(instance_t instance, E1AP_ErrorIndication_t *ErrorIndication)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
 void e1ap_send_SETUP_RESPONSE(sctp_assoc_t assoc_id, const e1ap_setup_resp_t *e1ap_setup_resp)
 {
   E1AP_E1AP_PDU_t *pdu = encode_e1ap_cuup_setup_response(e1ap_setup_resp);
@@ -162,6 +122,7 @@ static void e1apCUCP_send_SETUP_FAILURE(sctp_assoc_t assoc_id, const e1ap_setup_
 int e1apCUCP_handle_SETUP_REQUEST(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
   DevAssert(pdu != NULL);
+  UNUSED(inst);
   /* Create ITTI message and send to queue */
   MessageDef *msg_p = itti_alloc_new_message(TASK_CUCP_E1, 0 /*unused by callee*/, E1AP_SETUP_REQ);
   // Decode E1 CU-UP Setup Request
@@ -187,6 +148,7 @@ int e1apCUCP_handle_SETUP_REQUEST(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst,
 
 int e1apCUUP_handle_SETUP_RESPONSE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
   // Decode E1 CU-UP Setup Response
   e1ap_setup_resp_t out = {0};
   if (!decode_e1ap_cuup_setup_response(pdu, &out)) {
@@ -210,6 +172,7 @@ int e1apCUUP_handle_SETUP_RESPONSE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst
  */
 int e1apCUUP_handle_SETUP_FAILURE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
   LOG_D(E1AP, "CU-UP: Decoding E1AP Setup Failure...\n");
   E1AP_GNB_CU_UP_E1SetupFailureIEs_t *ie;
   DevAssert(pdu != NULL);
@@ -302,58 +265,6 @@ int e1apCUCP_send_gNB_DU_CONFIGURATION_UPDATE_ACKNOWLEDGE(void)
   return -1;
 }
 
-int e1apCUCP_handle_CONFIGURATION_UPDATE(E1AP_E1AP_PDU_t *pdu)
-{
-  /*
-  E1AP_GNB_CU_UP_E1SetupRequestIEs_t *ie;
-  DevAssert(pdu != NULL);
-  E1AP_GNB_CU_UP_E1SetupRequest_t *in = &pdu->choice.initiatingMessage->value.choice.GNB_CU_UP_E1SetupRequest;
-  */
-
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUUP_handle_gNB_DU_CONFIGURATION_UPDATE_ACKNOWLEDGE(sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUUP_handle_gNB_DU_CONFIGURATION_FAILURE(sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-/*
-  E1 release
-*/
-
-int e1ap_send_RELEASE_REQUEST(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1ap_send_RELEASE_ACKNOWLEDGE(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1ap_handle_RELEASE_REQUEST(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1ap_handle_RELEASE_ACKNOWLEDGE(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
 void e1apCUCP_send_BEARER_CONTEXT_SETUP_REQUEST(sctp_assoc_t assoc_id, e1ap_bearer_setup_req_t *const bearerCxt)
 {
   E1AP_E1AP_PDU_t *pdu = encode_E1_bearer_context_setup_request(bearerCxt);
@@ -375,6 +286,8 @@ static void e1apCUUP_send_BEARER_CONTEXT_SETUP_FAILURE(sctp_assoc_t assoc_id, co
 
 int e1apCUUP_handle_BEARER_CONTEXT_SETUP_REQUEST(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *e1_inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
+  UNUSED(e1_inst);
   // Decode E1AP message
   e1ap_bearer_setup_req_t bearerCxt = {0};
   if (!decode_E1_bearer_context_setup_request(pdu, &bearerCxt)) {
@@ -387,6 +300,7 @@ int e1apCUUP_handle_BEARER_CONTEXT_SETUP_REQUEST(sctp_assoc_t assoc_id, e1ap_upc
 
 int e1apCUCP_handle_BEARER_CONTEXT_SETUP_RESPONSE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(inst);
   MessageDef *msg = itti_alloc_new_message(TASK_CUCP_E1, 0, E1AP_BEARER_CONTEXT_SETUP_RESP);
   // Decode
   e1ap_bearer_setup_resp_t *bearerCxt = &E1AP_BEARER_CONTEXT_SETUP_RESP(msg);
@@ -404,6 +318,7 @@ int e1apCUCP_handle_BEARER_CONTEXT_SETUP_RESPONSE(sctp_assoc_t assoc_id, e1ap_up
 
 int e1apCUCP_handle_BEARER_CONTEXT_SETUP_FAILURE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(inst);
   e1ap_bearer_context_setup_failure_t fail = {0};
   if (!decode_E1_bearer_context_setup_failure(&fail, pdu)) {
     LOG_E(E1AP, "Failed to decode Bearer Context Setup Failure\n");
@@ -447,6 +362,8 @@ int e1apCUUP_handle_BEARER_CONTEXT_MODIFICATION_REQUEST(sctp_assoc_t assoc_id,
                                                         e1ap_upcp_inst_t *e1_inst,
                                                         const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
+  UNUSED(e1_inst);
   e1ap_bearer_mod_req_t bearerCxt = {0};
   if (!decode_E1_bearer_context_mod_request(pdu, &bearerCxt)) {
     LOG_E(E1AP, "Failed to handle Bearer Context Modification Request\n");
@@ -462,6 +379,8 @@ int e1apCUCP_handle_BEARER_CONTEXT_MODIFICATION_RESPONSE(sctp_assoc_t assoc_id,
                                                          e1ap_upcp_inst_t *e1_inst,
                                                          const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
+  UNUSED(e1_inst);
   MessageDef *msg = itti_alloc_new_message(TASK_CUUP_E1, 0, E1AP_BEARER_CONTEXT_MODIFICATION_RESP);
   e1ap_bearer_modif_resp_t *modif = &E1AP_BEARER_CONTEXT_MODIFICATION_RESP(msg);
   if(!decode_E1_bearer_context_mod_response(modif, pdu)) {
@@ -474,6 +393,8 @@ int e1apCUCP_handle_BEARER_CONTEXT_MODIFICATION_RESPONSE(sctp_assoc_t assoc_id,
 
 int e1apCUCP_handle_BEARER_CONTEXT_MODIFICATION_FAILURE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
+  UNUSED(inst);
   e1ap_bearer_context_mod_failure_t failure = {0};
   if (!decode_E1_bearer_context_mod_failure(&failure, pdu)) {
     free_E1_bearer_context_mod_failure(&failure);
@@ -489,35 +410,6 @@ int e1apCUCP_handle_BEARER_CONTEXT_MODIFICATION_FAILURE(sctp_assoc_t assoc_id, e
   return 0;
 }
 
-int e1apCUUP_send_BEARER_CONTEXT_MODIFICATION_REQUIRED(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUCP_send_BEARER_CONTEXT_MODIFICATION_CONFIRM(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUCP_handle_BEARER_CONTEXT_MODIFICATION_REQUIRED(instance_t instance,
-                                                         sctp_assoc_t assoc_id,
-                                                         uint32_t stream,
-                                                         E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUUP_handle_BEARER_CONTEXT_MODIFICATION_CONFIRM(instance_t instance,
-                                                        sctp_assoc_t assoc_id,
-                                                        uint32_t stream,
-                                                        E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
 /*
   BEARER CONTEXT RELEASE
 */
@@ -534,14 +426,10 @@ int e1apCUUP_send_BEARER_CONTEXT_RELEASE_COMPLETE(sctp_assoc_t assoc_id, const e
   return e1ap_encode_send(CPtype, assoc_id, pdu, 0, __func__);
 }
 
-int e1apCUUP_send_BEARER_CONTEXT_RELEASE_REQUEST(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
 int e1apCUUP_handle_BEARER_CONTEXT_RELEASE_COMMAND(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
+  UNUSED(inst);
   e1ap_bearer_release_cmd_t release = {0};
   if(!decode_e1_bearer_context_release_command(&release, pdu)) {
     free_e1_bearer_context_release_command(&release);
@@ -553,6 +441,8 @@ int e1apCUUP_handle_BEARER_CONTEXT_RELEASE_COMMAND(sctp_assoc_t assoc_id, e1ap_u
 
 int e1apCUCP_handle_BEARER_CONTEXT_RELEASE_COMPLETE(sctp_assoc_t assoc_id, e1ap_upcp_inst_t *e1_inst, const E1AP_E1AP_PDU_t *pdu)
 {
+  UNUSED(assoc_id);
+  UNUSED(e1_inst);
   e1ap_bearer_release_cplt_t bearerCxt = {0};
   if(!decode_e1_bearer_context_release_complete(&bearerCxt, pdu)) {
     free_e1_bearer_context_release_complete(&bearerCxt);
@@ -565,61 +455,6 @@ int e1apCUCP_handle_BEARER_CONTEXT_RELEASE_COMPLETE(sctp_assoc_t assoc_id, e1ap_
   return 0;
 }
 
-int e1apCUCP_handle_BEARER_CONTEXT_RELEASE_REQUEST(instance_t instance,
-                                                   sctp_assoc_t assoc_id,
-                                                   uint32_t stream,
-                                                   E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-/*
-BEARER CONTEXT INACTIVITY NOTIFICATION
- */
-
-int e1apCUUP_send_BEARER_CONTEXT_INACTIVITY_NOTIFICATION(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUCP_handle_BEARER_CONTEXT_INACTIVITY_NOTIFICATION(instance_t instance,
-                                                           sctp_assoc_t assoc_id,
-                                                           uint32_t stream,
-                                                           E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-/*
-  DL DATA
-*/
-
-int e1apCUUP_send_DL_DATA_NOTIFICATION(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUUP_send_DATA_USAGE_REPORT(instance_t instance)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUCP_handle_DL_DATA_NOTIFICATION(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
-int e1apCUCP_handle_send_DATA_USAGE_REPORT(instance_t instance, sctp_assoc_t assoc_id, uint32_t stream, E1AP_E1AP_PDU_t *pdu)
-{
-  AssertFatal(false, "Not implemented yet\n");
-  return -1;
-}
-
 static instance_t cuup_task_create_gtpu_instance_to_du(eth_params_t *IPaddrs)
 {
   openAddr_t tmp = {0};
@@ -775,6 +610,7 @@ static void e1apHandleTimer(instance_t myInstance)
  */
 void *E1AP_CUCP_task(void *arg)
 {
+  UNUSED(arg);
   LOG_I(E1AP, "Starting E1AP at CU CP\n");
   MessageDef *msg = NULL;
   e1ap_common_init();
@@ -859,6 +695,7 @@ void *E1AP_CUCP_task(void *arg)
  */
 void *E1AP_CUUP_task(void *arg)
 {
+  UNUSED(arg);
   LOG_I(E1AP, "Starting E1AP at CU UP\n");
   e1ap_common_init();
   int result;

openair2/E1AP/lib/e1ap_bearer_context_management.c

@@ -1086,6 +1086,7 @@ bool eq_bearer_context_setup_response(const e1ap_bearer_setup_resp_t *a, const e
  */
 void free_e1ap_context_setup_response(const e1ap_bearer_setup_resp_t *msg)
 {
+  UNUSED(msg);
   // Do nothing (no dynamic allocation)
 }
 
@@ -1305,6 +1306,7 @@ e1ap_bearer_release_cmd_t cp_bearer_context_release_command(const e1ap_bearer_re
 /** @brief Bearer Context Release Command equality check */
 void free_e1_bearer_context_release_command(const e1ap_bearer_release_cmd_t *msg)
 {
+  UNUSED(msg);
   // do nothing
 }
 
@@ -1392,6 +1394,7 @@ e1ap_bearer_release_cplt_t cp_bearer_context_release_complete(const e1ap_bearer_
 /** @brief Bearer Context Release Complete equality check */
 void free_e1_bearer_context_release_complete(const e1ap_bearer_release_cplt_t *msg)
 {
+  UNUSED(msg);
   // No dynamic memory, do nothing
 }
 
@@ -2662,5 +2665,6 @@ bool eq_E1_bearer_context_mod_failure(const e1ap_bearer_context_mod_failure_t *a
 /** @brief E1AP Bearer Context Modification Failure: free */
 void free_E1_bearer_context_mod_failure(const e1ap_bearer_context_mod_failure_t *msg)
 {
+  UNUSED(msg);
   // do nothing
 }