diff --git a/openair2/LAYER2/NR_MAC_gNB/mac_rrc_dl_handler.c b/openair2/LAYER2/NR_MAC_gNB/mac_rrc_dl_handler.c index 9c6f5f4b27..124d63d293 100644 --- a/openair2/LAYER2/NR_MAC_gNB/mac_rrc_dl_handler.c +++ b/openair2/LAYER2/NR_MAC_gNB/mac_rrc_dl_handler.c @@ -482,7 +482,8 @@ static NR_UE_info_t *create_new_UE(gNB_MAC_INST *mac, uint32_t cu_id) return NULL; f1_ue_data_t new_ue_data = {.secondary_ue = cu_id}; - du_add_f1_ue_data(rnti, &new_ue_data); + bool success = du_add_f1_ue_data(rnti, &new_ue_data); + DevAssert(success); const NR_ServingCellConfigCommon_t *scc = mac->common_channels[CC_id].ServingCellConfigCommon; const NR_ServingCellConfig_t *sccd = mac->common_channels[CC_id].pre_ServingCellConfig; @@ -826,7 +827,8 @@ void dl_rrc_message_transfer(const f1ap_dl_rrc_message_t *dl_rrc) if (!du_exists_f1_ue_data(dl_rrc->gNB_DU_ue_id)) { LOG_D(NR_MAC, "No CU UE ID stored for UE RNTI %04x, adding CU UE ID %d\n", dl_rrc->gNB_DU_ue_id, dl_rrc->gNB_CU_ue_id); f1_ue_data_t new_ue_data = {.secondary_ue = dl_rrc->gNB_CU_ue_id}; - du_add_f1_ue_data(dl_rrc->gNB_DU_ue_id, &new_ue_data); + bool success = du_add_f1_ue_data(dl_rrc->gNB_DU_ue_id, &new_ue_data); + DevAssert(success); } if (UE->expect_reconfiguration && dl_rrc->srb_id == 1) { diff --git a/openair2/LAYER2/nr_pdcp/cucp_cuup_handler.c b/openair2/LAYER2/nr_pdcp/cucp_cuup_handler.c index 1d3394e788..380ae1f60a 100644 --- a/openair2/LAYER2/nr_pdcp/cucp_cuup_handler.c +++ b/openair2/LAYER2/nr_pdcp/cucp_cuup_handler.c @@ -150,7 +150,8 @@ void e1_bearer_context_setup(const e1ap_bearer_setup_req_t *req) uint32_t cu_up_ue_id = req->gNB_cu_cp_ue_id; f1_ue_data_t ued = {.secondary_ue = req->gNB_cu_cp_ue_id}; if (need_ue_id_mgmt) { - cu_add_f1_ue_data(cu_up_ue_id, &ued); + bool success = cu_add_f1_ue_data(cu_up_ue_id, &ued); + DevAssert(success); LOG_I(E1AP, "adding UE with CU-CP UE ID %d and CU-UP UE ID %d\n", req->gNB_cu_cp_ue_id, cu_up_ue_id); } diff --git a/openair2/RRC/NR/rrc_gNB.c b/openair2/RRC/NR/rrc_gNB.c index 2456a851de..76f902ffb8 100644 --- a/openair2/RRC/NR/rrc_gNB.c +++ b/openair2/RRC/NR/rrc_gNB.c @@ -1181,8 +1181,10 @@ static void rrc_handle_RRCReestablishmentRequest(gNB_RRC_INST *rrc, /* update to old DU assoc id -- RNTI + secondary DU UE ID further below */ f1_ue_data_t ue_data = cu_get_f1_ue_data(UE->rrc_ue_id); ue_data.du_assoc_id = source_ctx->du->assoc_id; - cu_remove_f1_ue_data(UE->rrc_ue_id); - cu_add_f1_ue_data(UE->rrc_ue_id, &ue_data); + bool success = cu_remove_f1_ue_data(UE->rrc_ue_id); + DevAssert(success); + success = cu_add_f1_ue_data(UE->rrc_ue_id, &ue_data); + DevAssert(success); nr_rrc_finalize_ho(UE); } else if (physCellId != cell_info->nr_pci) { /* UE was moving from previous cell so quickly that RRCReestablishment for previous cell was received in this cell */ @@ -1212,8 +1214,10 @@ static void rrc_handle_RRCReestablishmentRequest(gNB_RRC_INST *rrc, UE->nr_cellid = msg->nr_cellid; f1_ue_data_t ue_data = cu_get_f1_ue_data(UE->rrc_ue_id); ue_data.secondary_ue = msg->gNB_DU_ue_id; - cu_remove_f1_ue_data(UE->rrc_ue_id); - cu_add_f1_ue_data(UE->rrc_ue_id, &ue_data); + bool success = cu_remove_f1_ue_data(UE->rrc_ue_id); + DevAssert(success); + success = cu_add_f1_ue_data(UE->rrc_ue_id, &ue_data); + DevAssert(success); rrc_gNB_generate_RRCReestablishment(ue_context_p, msg->du2cu_rrc_container, old_rnti, du); return; @@ -2125,8 +2129,10 @@ static void rrc_CU_process_ue_context_modification_response(MessageDef *msg_p, i f1_ue_data_t ue_data = cu_get_f1_ue_data(UE->rrc_ue_id); ue_data.secondary_ue = target_ctx->du_ue_id; ue_data.du_assoc_id = target_ctx->du->assoc_id; - cu_remove_f1_ue_data(UE->rrc_ue_id); - cu_add_f1_ue_data(UE->rrc_ue_id, &ue_data); + bool success = cu_remove_f1_ue_data(UE->rrc_ue_id); + DevAssert(success); + success = cu_add_f1_ue_data(UE->rrc_ue_id, &ue_data); + DevAssert(success); LOG_I(NR_RRC, "UE %d handover: update RNTI from %04x to %04x\n", UE->rrc_ue_id, UE->rnti, target_ctx->new_rnti); nr_ho_source_cu_t *source_ctx = UE->ho_context->source; DevAssert(source_ctx->old_rnti == UE->rnti); diff --git a/openair2/RRC/NR/rrc_gNB_UE_context.c b/openair2/RRC/NR/rrc_gNB_UE_context.c index eae5c0706e..9b02eaa1f4 100644 --- a/openair2/RRC/NR/rrc_gNB_UE_context.c +++ b/openair2/RRC/NR/rrc_gNB_UE_context.c @@ -204,7 +204,8 @@ rrc_gNB_ue_context_t *rrc_gNB_create_ue_context(sctp_assoc_t assoc_id, AssertFatal(!cu_exists_f1_ue_data(ue->rrc_ue_id), "UE F1 Context for ID %d already exists, logic bug\n", ue->rrc_ue_id); - cu_add_f1_ue_data(ue->rrc_ue_id, &ue_data); + bool success = cu_add_f1_ue_data(ue->rrc_ue_id, &ue_data); + DevAssert(success); RB_INSERT(rrc_nr_ue_tree_s, &rrc_instance_pP->rrc_ue_head, ue_context_p); LOG_UE_EVENT(ue, diff --git a/openair2/RRC/NR/rrc_gNB_cuup.c b/openair2/RRC/NR/rrc_gNB_cuup.c index 621ebca56e..2b007e490b 100644 --- a/openair2/RRC/NR/rrc_gNB_cuup.c +++ b/openair2/RRC/NR/rrc_gNB_cuup.c @@ -132,8 +132,10 @@ sctp_assoc_t get_new_cuup_for_ue(const gNB_RRC_INST *rrc, const gNB_RRC_UE_t *ue /* update the association for the UE so it will be picked up later */ ue_data.e1_assoc_id = selected->assoc_id; - cu_remove_f1_ue_data(ue->rrc_ue_id); - cu_add_f1_ue_data(ue->rrc_ue_id, &ue_data); + bool success = cu_remove_f1_ue_data(ue->rrc_ue_id); + DevAssert(success); + success = cu_add_f1_ue_data(ue->rrc_ue_id, &ue_data); + DevAssert(success); LOG_I(RRC, "UE %d associating to CU-UP assoc_id %d out of %ld CU-UPs\n", ue->rrc_ue_id, ue_data.e1_assoc_id, rrc->num_cuups); return ue_data.e1_assoc_id; diff --git a/openair2/RRC/NR/rrc_gNB_du.c b/openair2/RRC/NR/rrc_gNB_du.c index 654ef04be1..64f96efbee 100644 --- a/openair2/RRC/NR/rrc_gNB_du.c +++ b/openair2/RRC/NR/rrc_gNB_du.c @@ -426,9 +426,11 @@ static int invalidate_du_connections(gNB_RRC_INST *rrc, sctp_assoc_t assoc_id) if (ue_data.du_assoc_id == assoc_id) { /* this UE belongs to the DU that disconnected, set du_assoc_id to 0, * meaning DU is offline, then trigger release request */ - cu_remove_f1_ue_data(ue_id); + bool success = cu_remove_f1_ue_data(ue_id); + DevAssert(success); ue_data.du_assoc_id = 0; - cu_add_f1_ue_data(ue_id, &ue_data); + success = cu_add_f1_ue_data(ue_id, &ue_data); + DevAssert(success); rrc_gNB_send_NGAP_UE_CONTEXT_RELEASE_REQ(0, ue_context_p, NGAP_CAUSE_RADIO_NETWORK, diff --git a/openair2/RRC/NR/rrc_gNB_nsa.c b/openair2/RRC/NR/rrc_gNB_nsa.c index bae7c45180..595e380846 100644 --- a/openair2/RRC/NR/rrc_gNB_nsa.c +++ b/openair2/RRC/NR/rrc_gNB_nsa.c @@ -355,9 +355,11 @@ void rrc_add_nsa_user(gNB_RRC_INST *rrc, rrc_gNB_ue_context_t *ue_context_p, x2a uint32_t du_ue_id = ue_context_p->ue_context.rnti; uint32_t rrc_ue_id = ue_context_p->ue_context.rrc_ue_id; f1_ue_data_t du_ue_data = {.secondary_ue = rrc_ue_id}; - du_add_f1_ue_data(du_ue_id, &du_ue_data); + bool success = du_add_f1_ue_data(du_ue_id, &du_ue_data); + DevAssert(success); f1_ue_data_t cu_ue_data = {.secondary_ue = du_ue_id}; - cu_add_f1_ue_data(rrc_ue_id, &cu_ue_data); + success = cu_add_f1_ue_data(rrc_ue_id, &cu_ue_data); + DevAssert(success); LOG_I(RRC, "Assign CU UE ID %d and DU UE ID %d to UE RNTI %04x\n", rrc_ue_id, du_ue_id, ue_context_p->ue_context.rnti); // configure MAC and RLC