Raphael Defosseux
0f11865fa4
Merge remote-tracking branch 'origin/issue-404-pdcp-integrity' into develop_integration_2019_w09
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2019-02-28 14:37:10 +01:00
Cedric Roux
e3782b5ca2
bugfix: fix PDCP sequence management (plus some cleanup)
...
With the introduction of X2AP into develop, the UEs now have to regularly
send measurement reports.
In the logs of the eNB, we see:
[OSA] Mismatch found in integrity for algorithm 2,
got e0.a0.c2.66, expecting a5.9c.cb.57
[PDCP] [OSA][RB 1] eNB failed to validate MAC-I of incoming PDU
This is a bug in the PDCP layer that uses wrong parameters to compute the
integrity.
This commit fixes this bug.
The function pdcp_is_rx_seq_number_valid was removed. Its processing
has been directly integrated into the function pdcp_data_ind.
The function pdcp_mark_current_pdu_as_received is not called anymore.
Its processing was not used later on, so as of today, not calling it does
not introduce any functional change.
The function pdcp_validate_security takes now as parameters both
SN and HFN. Same for the function pdcp_get_next_count_rx.
Useless constants PDCP_SN_5BIT, PDCP_SN_7BIT and PDCP_SN_12BIT have been
removed.
The compilation option ENABLE_SECURITY has been removed. It's now always
on. (This may impact some use cases.)
The PDCP for DRB using RLC AM is not correct. It was not correct before
this commit (apart from the integrity bug). We should deal with a list
of PDUs and transmit packets to upper layers as detailed in the specs.
Today we transmit the PDU as soon as we get it. We don't care about
duplicates, in-order delivery, timeouts.
Also, we don't deal with "PDCP re-establishment". Not sure how that impacts
the software.
And, last but not least, there is still no ROHC.
2019-02-27 12:33:04 +01:00
frtabu
fb46545526
Fix corrupted LOGs in L1L2simulator, introducing two new components NFAPI_VNF and NFAPI_pnf. Integrate Fujitsu fix for up to 50 UEs. Apply astyle to all modified files in the branch
2019-02-25 16:50:03 +01:00
frtabu
38d772d8a2
nos1 et s1 execs identical, nos1 enforced based on exec name or --noS1 option
2019-02-17 23:46:45 +01:00
Raphael Defosseux
d14ad6797e
Applying the cppcheck fix on last files
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2019-02-15 19:18:24 +01:00
Raphael Defosseux
341fedd468
Merge branch 'issue394_fix_cppcheck' into develop_integration_2019_w07_v2
...
--> openair2/LAYER2/MAC/eNB_scheduler_primitives.c is still old (not from issue394_fix_cppcheck branch)
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2019-02-15 12:24:19 +01:00
Cedric Roux
e4443b1810
x2: fix compilation
2019-02-13 15:42:29 +01:00
Cedric Roux
1c6b9f0eda
Merge remote-tracking branch 'origin/develop' into x2
...
Conflicts:
openair2/LAYER2/MAC/config.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/rrc_defs.h
2019-02-13 15:20:45 +01:00
frtabu
60defa245d
more fixes for cppcheck
2019-02-12 10:12:07 +01:00
Raymond Knopp
e704e7ccc0
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
2019-02-07 23:58:17 +01:00
Cedric Roux
be68e1e651
Merge remote-tracking branch 'origin/develop' into x2
...
Conflicts:
common/utils/msc/msc.h
openair2/X2AP/x2ap_eNB.c
2019-02-01 14:27:55 +01:00
frtabu
9d0c70c9fe
remove L1L2 task, also remove some call to send messages to UNKNOWN_TASK, removed in new itti. Align LOG in rlc sources with new LOG code (remove DEBUG_RLC...)
2019-01-21 19:43:19 +01:00
Cedric Roux
3ee6ccbeb5
fix enb nos1 ethernet compilation
2019-01-21 17:27:57 +01:00
Konstantinos Alexandris
80cf53a3c0
minor: fix spacing
2019-01-21 10:54:21 +01:00
Raymond Knopp
c47e1fc97f
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
2019-01-19 12:14:23 +01:00
Cedric Roux
7d481c5734
Merge remote-tracking branch 'origin/develop' into x2
2019-01-18 10:40:01 +01:00
Cedric Roux
246abce5d1
Merge remote-tracking branch 'origin/develop' into x2
...
Conflicts:
openair2/ENB_APP/enb_config.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/MESSAGES/asn1_msg.h
openair2/RRC/LTE/rrc_defs.h
openair2/RRC/LTE/rrc_eNB.c
openair2/RRC/LTE/rrc_eNB_S1AP.c
openair2/RRC/LTE/rrc_proto.h
openair3/GTPV1-U/gtpv1u_eNB.c
openair3/S1AP/s1ap_eNB_handlers.c
2019-01-18 10:35:39 +01:00
Cedric Roux
4cd58ac80a
apply astyle
2019-01-16 11:44:38 +01:00
Cedric Roux
aea6b4b5a6
fix a lot of file mode
...
For whatever reason most of the files had their permission
changed from 644 to 755, which is not wanted.
2019-01-07 16:22:28 +01:00
Raymond Knopp
44a225c6b7
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair1/PHY/LTE_TRANSPORT/dci_tools.c
openair1/SCHED/fapi_l1.c
openair1/SCHED/phy_procedures_lte_eNb.c
openair2/COMMON/rrc_messages_types.h
openair2/ENB_APP/enb_config.c
openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
openair2/LAYER2/MAC/eNB_scheduler_fairRR.c
openair2/LAYER2/MAC/eNB_scheduler_primitives.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/LAYER2/MAC/mac.h
openair2/RRC/LTE/L2_interface.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/MESSAGES/asn1_msg.h
openair2/RRC/LTE/rrc_eNB.c
openair2/RRC/LTE/rrc_eNB_S1AP.c
targets/RT/USER/lte-enb.c
2019-01-05 23:28:31 +01:00
laurent
b3f1440249
issue 384
2018-12-23 17:55:07 +01:00
Konstantinos Alexandris
ea105c39b1
X2AP MOBILITY PROCEDURES (X2AP HANDOVER REQUEST/REQUEST ACK)
...
S1AP PATH SWITCH REQUEST/REQUEST ACK/FAILURE
RRC MEASUREMENT REPORT
MINOR CHANGES IN MAC LAYER
2018-12-18 13:45:03 +01:00
Raymond Knopp
552bd6979d
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair2/RRC/LTE/MESSAGES/asn1_msg.c
2018-11-26 23:01:47 +01:00
Raphael Defosseux
f8ccd284a0
Merge remote-tracking branch 'origin/develop' into 374-missing-rrc-inactivity-timer-missing-default-drx-ie-in-s1-setup-ue-s1-id-unknown-after-detach-for-switch-off
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2018-11-23 14:10:50 +01:00
Louis Adrien Dufrene
cf07c4d394
astyle applied
2018-11-20 16:39:05 +01:00
OAI-admin
1094835db1
RRC timer fixed and tested
2018-11-20 15:07:43 +01:00
Louis Adrien Dufrene
c194956da3
RRC timer thres removed from UE context and added to eNB RRC context, value 0 of thres equivalent to infinity
2018-11-20 14:15:50 +01:00
Raymond Knopp
6266d5c389
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair1/PHY/INIT/lte_init.c
openair1/PHY/LTE_TRANSPORT/dci.c
openair1/PHY/LTE_TRANSPORT/edci.c
openair1/PHY/LTE_TRANSPORT/prach.c
openair1/PHY/LTE_TRANSPORT/transport_eNB.h
openair1/SCHED/fapi_l1.c
openair1/SCHED/phy_procedures_lte_eNb.c
openair2/COMMON/rrc_messages_types.h
openair2/ENB_APP/enb_config.c
openair2/LAYER2/MAC/config.c
openair2/LAYER2/MAC/eNB_scheduler_RA.c
openair2/LAYER2/MAC/eNB_scheduler_bch.c
openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/LAYER2/MAC/mac.h
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/rrc_defs.h
openair2/RRC/LTE/rrc_eNB.c
openair2/RRC/LTE/rrc_eNB_S1AP.c
2018-11-19 00:43:49 +01:00
Raymond Knopp
246ee327fb
rework of configuration for eMTC/Sidelink. Removal of warnings introduced by eMTC code. Validation of configuration component for eMTC and regular LTE. Sidelink is still not configured.
2018-11-18 20:17:18 +01:00
Louis Adrien Dufrene
700437f184
astyle applied
2018-11-16 08:49:28 +01:00
Louis Adrien Dufrene
22e44306f8
RRC inactivity timer deactivated
2018-11-15 13:28:59 +01:00
Louis Adrien Dufrene
961a70a04e
Fusion wasn't ok, needed some modifications
2018-11-13 11:20:14 +01:00
Louis Adrien Dufrene
a409614185
Merge develop done, conflicts resolved
2018-11-13 10:49:20 +01:00
Louis Adrien Dufrene
287010f82f
RRC timer: last format done. Timer reset in scheduling of DTCH (DL/UL). Commit to test.
2018-11-13 10:21:38 +01:00
Louis Adrien Dufrene
1c196a9eff
rrc inactivity timer reset in RRC Connection Release generation
2018-11-05 16:48:50 +01:00
frtabu
df6030540a
reduce compilation warnings in noS1 build to try to pass CI
2018-11-05 11:28:25 +01:00
Raymond Knopp
374d00d857
removal of warnings during configuration
2018-11-04 00:03:44 +01:00
Raymond Knopp
b27ed63fa9
lte-softmodem compiles, many memory faults during configuration ...
2018-11-03 22:51:24 +01:00
Louis Adrien Dufrene
1bb53286bb
Bug fixed: S1 setup requst sends the correct default DRX value
2018-11-02 16:23:32 +01:00
OAI-admin
6ae27efac0
minor update in format, variable ctxt removed in rrc_eNB_free_UE()
2018-10-31 16:24:29 +01:00
Raymond Knopp
d24f521a5a
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair1/PHY/INIT/lte_init.c
openair1/PHY/LTE_ESTIMATION/lte_ul_channel_estimation.c
openair1/PHY/LTE_TRANSPORT/dci.c
openair1/PHY/LTE_TRANSPORT/dci_tools.c
openair1/PHY/LTE_TRANSPORT/dlsch_coding.c
openair1/PHY/LTE_TRANSPORT/edci.c
openair1/PHY/LTE_TRANSPORT/if4_tools.c
openair1/PHY/LTE_TRANSPORT/prach.c
openair1/PHY/LTE_TRANSPORT/print_stats.c
openair1/PHY/LTE_TRANSPORT/pucch.c
openair1/PHY/LTE_TRANSPORT/transport_eNB.h
openair1/PHY/LTE_TRANSPORT/ulsch_decoding.c
openair1/PHY/LTE_UE_TRANSPORT/transport_proto_ue.h
openair1/PHY/impl_defs_lte.h
openair1/SCHED/fapi_l1.c
openair1/SCHED/phy_procedures_lte_eNb.c
openair2/COMMON/rrc_messages_types.h
openair2/ENB_APP/enb_config.c
openair2/ENB_APP/enb_paramdef.h
openair2/LAYER2/MAC/config.c
openair2/LAYER2/MAC/defs.h
openair2/LAYER2/MAC/eNB_scheduler.c
openair2/LAYER2/MAC/eNB_scheduler_RA.c
openair2/LAYER2/MAC/eNB_scheduler_bch.c
openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
openair2/LAYER2/MAC/eNB_scheduler_primitives.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/LAYER2/MAC/pre_processor.c
openair2/LAYER2/MAC/rar_tools.c
openair2/LAYER2/MAC/ue_procedures.c
openair2/PHY_INTERFACE/IF_Module.c
openair2/RRC/LITE/rrc_common.c
openair2/RRC/LTE/L2_interface_ue.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/rrc_eNB.c
targets/ARCH/USRP/USERSPACE/LIB/usrp_lib.cpp
targets/RT/USER/lte-enb.c
targets/RT/USER/lte-ru.c
2018-10-29 07:54:17 +01:00
root
266645d98d
Minor corrections, compilation ok
2018-10-26 09:50:01 +02:00
Louis Adrien Dufrene
78051a314a
RRC inactivity timer on RRC connection setup: to be tested
2018-10-26 08:14:47 +02:00
Louis Adrien Dufrene
a321e160cf
rrc inactivity timer created, S1 ue context release request sent on timeout, timer set at RRC connection complete reception
2018-10-25 16:03:38 +02:00
Louis Adrien Dufrene
2966cdf1c0
Format rrc_eNB_send_S1AP_UE_CONTEXT_RELEASE_REQ()
2018-10-23 17:12:45 +02:00
Louis Adrien Dufrene
57a383e77c
Format rrc_eNB_process_S1AP_UE_CONTEXT_RELEASE_COMMAND() and rrc_eNB_free_UE()
2018-10-23 16:51:55 +02:00
Louis Adrien Dufrene
2e5ae1eac6
Format of function rrc_rx_tx()
2018-10-23 16:20:14 +02:00
Bi-Ruei, Chiu
f58ad3c39f
Add prefix LTE_ to LTE-RRC generated data types by ASN1C_PREFIX=LTE_
...
1. Modify all expressions using original LTE-RRC data types for new generated ones
2. Does not change any program logic
2018-10-17 15:46:12 +08:00
laurent
d8472426c4
fix_issue_350_gtpu_init
2018-09-20 12:37:26 +02:00
Robert Schmidt
77f2ffcdfb
FlexRAN: call the agent_rrc_xface with the mod_id
2018-09-03 18:10:28 +02:00