Minor fixes, doesn't change anything. Not sure these are 'bugs' either,
but let's be polite with coverity scan...
One thing was not changed.
Coverity scan says:
*** CID 357991: Memory - illegal accesses (USE_AFTER_FREE)
/home/carabe/raphael/openairinterface5g/openair2/LAYER2/rlc_v2/rlc_entity_am.c: 507 in tx_list_remove_sn()
501 } else {
502 prev = cur;
503 cur = cur->next;
504 }
505 }
506
>>> CID 357991: Memory - illegal accesses (USE_AFTER_FREE)
>>> Using freed pointer "head.next".
507 return head.next;
508 }
509
510 void cleanup_sdu_list(rlc_entity_am_t *entity)
511 {
512 rlc_sdu_t head;
But as far as I understand, there is no problem. We don't access
head.next at all if it has been freed. Or is there some aliasing
going on there (pointer aliasing)? I doubt it. False positive?
-- check if C file has a GNU GPL license
-- check if C file has s suspect license
-- check if C header is having correct circular dependency protection (with Laurent Thomas's help)
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
- The number of nb_dmrs_re at gNB side was set to 6, but here it is assumed
that there will be no data allocation in OFDM symbols that carry DMRS
- nb_dmrs_re that is being given as an input to the TBS calculation,
should be multiplied by the number of DMRS symbols in order to get the total
number of DMRS REs per RB
- In the calculation of G, only the number of DMRS per RB in 1 OFDM symbol should
be given as an input, because inside the function of the G calculation, this
number is being multiplied by the number of OFDM symbols that carry DMRS
- By default this value is equal to 0 at gNB in case of ulsim, but
has a value in case of RF simulator
- The N_TA_offset was calculated but not used at UE side
- By default this value is equal to 0 at gNB in case of ulsim, but
has a value in case of RF simulator
- The N_TA_offset was calculated but not used at UE side
- The number of nb_dmrs_re at gNB side was set to 6, but here it is assumed
that there will be no data allocation in OFDM symbols that carry DMRS
- nb_dmrs_re that is being given as an input to the TBS calculation,
should be multiplied by the number of DMRS symbols in order to get the total
number of DMRS REs per RB
- In the calculation of G, only the number of DMRS per RB in 1 OFDM symbol should
be given as an input, because inside the function of the G calculation, this
number is being multiplied by the number of OFDM symbols that carry DMRS
Francesco Mani