Commit Graph
100 Commits
Author SHA1 Message Date
Cedric Roux 64cd0076ba bugfix: print a warning when a configuration parameter is not found
If your configuration file does not contain a parameter
the softmodem only printed "Failed to parse eNB configuration file"
without telling you what parameter was not found.

This quick fix adds a warning in such cases.

It also exists at the first error rather than trying to
parse the rest of the configuration file.
2016-09-05 11:41:48 +02:00
Cedric Roux 85e562d0b9 hotfix: fix a silly bug 2016-09-01 12:18:19 +02:00
Cedric Roux 55c83b00f9 hotfix: bug in rx_pucch
This hotfix does not change the processing at all.
At this point, stat_re == 0, so the behavior is the
same as before. But the code was wrong. There should
have been no test, it's a NACK, period.
2016-08-31 11:26:16 +02:00
Cedric Roux 4086c585d5 Merge branch 'bugfix-i17-s1ap-ue-capabilities' into 'develop'
Bugfix i17 s1ap ue capabilities



See merge request !39
2016-08-22 09:46:52 +02:00
Cedric Roux 99acedd0e7 Merge branch 'enhancement-i18-asn1c-from-gitlab' into 'develop'
download asn1c from oai gitlab

We need to test at least one attach by the UEs of the test setup, to check that the local asn1c is the same as the one from github we used so far.

I don't think we need to do lots of traffic, it's only about control plane (rrc, s1ap).

And of course see if compilation is still ok.

See merge request !40
2016-08-22 09:33:05 +02:00
Cedric Roux f4e97b50fa download asn1c from oai gitlab
the official asn1c repository at github posed problems to
some people in the past. It's better to have it locally
for such a critical piece of the software.
2016-08-18 15:29:33 +02:00
Cedric Roux 07b3408d6c Merge remote-tracking branch 'origin/develop' into bugfix-i17-s1ap-ue-capabilities 2016-08-18 13:52:58 +02:00
Cedric Roux 4b32194719 fix internal issue 17 2016-08-18 13:03:42 +02:00
Cedric Roux 8b732dc7e2 T: add a mac pdu -> wireshark replay tracer
This tracer takes the traces ENB_MAC_UE_DL_PDU_WITH_DATA
and ENB_MAC_UE_UL_PDU_WITH_DATA from a trace file
(as generated by the "record" tracer) and sends them
in UDP packets correctly formatted for wireshark to
dissect them.

One unresolved problem I face with my version of
wireshark (1.10.6) is that I don't get the frame number,
only subframe. See in the code to change the behavior
if you use a more recent version of wireshark.

You need to properly configure wireshark for it to work.
See $OPENAIR_DIR/openair2/UTIL/OPT/README.txt.
2016-08-11 12:49:37 +02:00
Cedric Roux 696d92f04d bugfix: forgot to include T.h 2016-08-10 17:13:31 +02:00
Cedric Roux 3d64a195ef T: add a trace (random access downlink msg4) 2016-08-10 17:09:15 +02:00
Cedric Roux f33e9a7027 do not exit immediately in case of busy thread
5ms by default, easy to change (change the 10 in the loops)

if the behavior is worse than before, do git revert [commit ID]
2016-07-29 21:56:40 +02:00
Cedric Roux 56014444e2 bugfix
thanks to Supreeth Herle for reporting.
2016-07-29 09:54:23 +02:00
Cedric Roux 313acc6e96 fixes for the T 2016-07-28 15:58:54 +02:00
Cedric Roux 5e02e8e67d Merge branch 'develop' of https://gitlab.eurecom.fr/oai/openairinterface5g into develop 2016-07-28 12:45:29 +02:00
Cedric Roux 60f0d9ad46 bugfix 2016-07-28 12:27:54 +02:00
Cedric Roux 3f2a080cba better autoscroll management in textlist
left click: enable autoscroll and go to end of list
right click: disable autoscroll
2016-07-27 14:40:25 +02:00
Cedric Roux d62de525eb scroll by one line in textlist
to scroll by only one line, hold CONTROL key and scroll with
mouse wheel
2016-07-27 13:05:46 +02:00
Cedric Roux b07efe7a01 add trace ENB_MAC_UE_DL_PDU_WITH_DATA to trace downlink pdu 2016-07-27 11:36:35 +02:00
Cedric Roux 3f20ce7b87 mono-thread test 2016-07-26 13:30:12 +02:00
Cedric Roux 833714406c hotfix: RLC AM reported wrong number of bytes to retransmit
This was causing oaisim to fail way too often at the startup
of a connection.

Things should go better with this patch.

It may not be the end of the story, the use of retrans_num_bytes_to_retransmit
is not clear to me. The problem I see is: what if the max number of
retransimission has been reached (if that has a meaning at all in RLC AM)?
will this value be decreased or not?
2016-07-20 17:54:21 +02:00
Cedric Roux d0b046581c hotfix: set DCINdi for 1st uplink TX in the UE's harq process 2016-07-19 17:25:47 +02:00
Cedric Roux b1dde78f87 use official openair logo in enb.c 2016-07-12 16:00:14 +02:00
Cedric Roux 4fa14f209b merge oai/develop and oai-internal/T 2016-07-11 14:09:48 +02:00
Cedric Roux d48c336934 hotfix: better management of s-tmsi reconnect
The code was changing the rnti in the red-black tree without
removing/reinserting the context. This is wrong because the
rnti is a key of the red-black tree and you cannot change the
key in a stored item at will.

There are also modifications of the function mac_eNB_rrc_ul_failure
which has to remove the UE in any case.

And rrc_mac_remove_ue has been changed for the case where
the UE is not found.
2016-07-11 12:47:31 +02:00
Cedric Roux 19d4502c3d add PUCCH plots to enb.c 2016-07-08 13:14:03 +02:00
Cedric Roux 1dff3c4db6 add another IQ logger
iqlog.c should change its name, it's too specific.
This new one is more generic and should take over the name.
2016-07-08 13:02:54 +02:00
Cedric Roux aea2da5e4f minor compilation warning fix 2016-07-08 12:57:33 +02:00
Cedric Roux c4c288cb90 minor bugfix 2016-07-08 12:57:13 +02:00
Cedric Roux 3310c2a93f cosmetic changes 2016-07-08 12:56:25 +02:00
Cedric Roux 69ec911283 hotfix: remove HARQ process ID freelist
It creates more problems than it solves.

We replace this approach by a straightforward
synchronous one.

Now in the downlink, at frame f and subframe s
we use HARQ process (f * 10 + s) % 8.
This is similar to uplink scheduling.
2016-07-07 17:21:18 +02:00
Cedric Roux 633526331a hotfix: force 32-bytes alignment for avx2 code to be happy 2016-07-05 14:25:41 +02:00
Cedric Roux d0c99c296e Merge branch 'develop' into T 2016-06-28 13:21:32 +02:00
Cedric Roux cadb672d10 minor bugfix: forgot to update T_init in the example tracee 2016-06-28 13:00:16 +02:00
Cedric Roux 3d78e5a34b add option --T_dont_fork to tracee (lte-softmodem, oaisim)
The T has 2 processes: the tracee and the local tracer
if the tracee dies (segfault or whatever) the tracee
may still be running.

So there is a third process that monitors those two others
and kill everything when one dies.

The problem is that this third process has to be the parent
of the two others. That makes debugging the tracee with gdb
impossible. This new option disables the third monitor process.
2016-06-28 12:50:58 +02:00
Cedric Roux be03e9f80f bugfix in enb.c
we have to free memory in any case...
2016-06-24 18:11:09 +02:00
Cedric Roux 4bdacd953d add a .gitignore in the T directory
git status was way too noisy
2016-06-24 17:59:50 +02:00
Cedric Roux 3f4f285136 fix the T tracee example, it did not work anymore 2016-06-24 17:57:16 +02:00
Cedric Roux bc20616af7 minor: parameters missing to some LOG_ macros plus some cleanup 2016-06-24 17:51:00 +02:00
Cedric Roux bfa749a7fa hotfix: rrc_mac_remove_ue was wrong 2016-06-24 10:58:29 +02:00
Cedric Roux 1a6c20cf76 bugfix: record.c did not manage ctrl+c and ctrl+z correctly
ctrl+c did not work when the program was not connected yet.
It also didn't work if no event was received.
2016-06-23 14:48:25 +02:00
Cedric Roux 832ecfb470 update enb.c to include MAC PDU/SDU with full buffer logs 2016-06-23 12:41:19 +02:00
Cedric Roux 6445cc95f5 add T traces for MAC PDU/SDU including full buffers 2016-06-23 12:39:57 +02:00
Cedric Roux bb0816cdeb 2 new T logs: MAC PDU/SDU with buffer data 2016-06-23 12:38:59 +02:00
Cedric Roux bb051c0219 T_messages.txt is now sent by local_tracer.c
And it's sent at each connection attempt.
Before it was sent only once to the first tracer.
Plus there was a bug (length:(len) should have been length:(send_size)).
2016-06-23 11:09:05 +02:00
Cedric Roux d47e307472 rename T_cache to T_local_cache in T/local_tracer.c
needed because of the following commit
2016-06-23 11:06:48 +02:00
Cedric Roux 0d6c4a31f9 hotfix: include T.h before redefining VCD macros 2016-06-23 09:53:26 +02:00
Cedric Roux 6a809e84de add option -full to textlog.c to display full content of buffers 2016-06-22 16:13:47 +02:00
Cedric Roux 31e1be78fa add possibility to logger 'textlog' to print full content of buffers 2016-06-22 16:12:26 +02:00
Cedric Roux 088db3cf37 new function PUTX2 to display an int as an 8 bits hexadecimal 2016-06-22 16:10:32 +02:00
Cedric Roux bbcfd0047c add a "hacks" directory with hackish-quality pieces of software
stuff put in there is of lower quality / coding standard / whatever
and serves as example to do quick debugging taks using the T
infrastructure
2016-06-22 11:14:27 +02:00
Cedric Roux 3c5e27618d add PUSCH IQ and UL channel estimates for UE 0 to enb.c 2016-06-22 11:10:53 +02:00
Cedric Roux f31145ac96 new IQ logger
the current version is very specific to PUSCH IQ data, where the
input buffer has a special format

to be rewritten cleanly at some point
2016-06-22 10:58:25 +02:00
Cedric Roux d2bd09bb9d add function framelog_set_update_only_at_sf9 and update code about it 2016-06-22 10:55:34 +02:00
Cedric Roux 8c328e00b0 increase size of enb.c man window 2016-06-22 10:53:59 +02:00
Cedric Roux 7d311b57df hotfix: a value was missing in ref24
That led to uplink two resource blocks to fail being decoded (not always),
due to wrong channel estimation. (As was the previous hotfix for five
resource blocks.)

This commit also includes some cleanup of some historical code that is
not relevant anymore.
2016-06-21 15:54:03 +02:00
Cedric Roux 0d022cf5b0 hotfix: ref_primes has wrong value for 5 prbs
the bigger prime number lower than 60 is 59, not 50
2016-06-21 13:04:13 +02:00
Cedric Roux 0f0fa90d16 xy view to exist in two flavours
XY_LOOP_MODE: replace old points with new ones, using the maximum size
              of the view
XY_FORCE_MODE: append_forced sets those and only those points
               and we crash if we pass too much points
2016-06-20 15:40:53 +02:00
Cedric Roux 8e458d9c9b add a very basic step mechanism to replay.c 2016-06-20 11:36:17 +02:00
Cedric Roux c5b126f598 update format of trace ENB_PHY_PUSCH_IQ to include N_RB_UL and symbols_per_tti 2016-06-20 10:02:40 +02:00
Cedric Roux 8e28dacdd9 add a small utility to extract a configuration file from a log 2016-06-17 15:39:25 +02:00
Cedric Roux 99d1328d6e add a very basic replay tracer
to be used in conjunction with another tracer
so conceptually it's more a tracee than a tracer
2016-06-17 15:16:49 +02:00
Cedric Roux 97d1dcbccd add a 'record' tracer 2016-06-17 15:16:19 +02:00
Cedric Roux 9d49702639 cleanup: put DEFAULT_REMOTE_IP and DEFAULT_REMOTE_PORT in utils.h 2016-06-17 11:14:14 +02:00
Cedric Roux 031e6a024f Merge branch 'develop' into T 2016-06-16 17:22:30 +02:00
Cedric Roux 126be3fea6 synchronize VCD data in the T 2016-06-16 17:13:32 +02:00
Cedric Roux d0a33fac6c cleanup: rename legacy groups warning/info/error/xxx 2016-06-16 12:36:29 +02:00
Cedric Roux 1f389ec019 cleanup: rename PHY traces (and update code to reflect the changes) 2016-06-16 12:16:20 +02:00
Cedric Roux 70d58491fc bugfix: uplink transmission/retransmission traces were wrong 2016-06-16 11:09:25 +02:00
Cedric Roux 4ea0121cab hotfix: rewrite allocate_CCEs, it didn't work properly.
The distinction common space/user space still requires some
careful examination.
2016-06-15 22:24:15 +02:00
Cedric Roux 26c3a6a039 forgot to include T.h
if you compile *without* T it fails because the T macro is interpreted
as a function call
2016-06-10 12:42:44 +02:00
Cedric Roux e1cc2fe2b8 cleanup after merge 2016-06-10 12:12:03 +02:00
Cedric Roux 310b027acd Merge remote-tracking branch 'main/develop' into T
Conflicts:
	cmake_targets/CMakeLists.txt
	cmake_targets/build_oai
	openair1/PHY/LTE_TRANSPORT/pucch.c
	openair1/SCHED/phy_procedures_lte_eNb.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	targets/RT/USER/lte-softmodem.c
2016-06-10 11:49:59 +02:00
Cedric Roux 468020879e enb.c logs MAC/RLC/PDCP
very basic, to be refined, find a nice way to display (plot? text?)
protocol data movement
2016-06-10 10:48:39 +02:00
Cedric Roux 262cda6199 add PDCP traces to the code 2016-06-10 10:48:13 +02:00
Cedric Roux 10dbc33e01 add RLC traces to the code 2016-06-10 10:47:42 +02:00
Cedric Roux d7e072a413 MAC tracing in the code 2016-06-10 10:46:45 +02:00
Cedric Roux 416491821d add mac/rlc/pdcp messages' definitions to T_messages.txt
to be refined, it's rough
2016-06-10 10:44:42 +02:00
Cedric Roux dd55be2c67 cleanup 2016-06-09 17:35:41 +02:00
Cedric Roux 57240cc03b switch to utf-8 2016-06-09 17:33:43 +02:00
Cedric Roux b0e50688ee cleanup: introduce ticktime_filter() 2016-06-09 16:20:32 +02:00
Cedric Roux f9843f46bc add UL/DL harq ticktime view to enb.c 2016-06-09 10:51:24 +02:00
Cedric Roux 6f72af21c2 make tick larger in ticktime.c
3 pixels wide look better than 1
2016-06-09 10:47:27 +02:00
Cedric Roux c27e69f633 add harq_pid to some T traces
- update T_messages.txt
- update call sites of the T for thoses traces
2016-06-09 10:44:47 +02:00
Cedric Roux bdd8ee3eed restructure a bit the views in enb.c
more readable, still not satisfying though
2016-06-09 10:41:38 +02:00
Cedric Roux e268281233 add T log ENB_MASTER_TICK 2016-06-09 10:40:53 +02:00
Cedric Roux 1dff773eb2 add 'and' filter operation 2016-06-08 16:47:45 +02:00
Cedric Roux 72f56da6b6 add a filter to loggers
events are accepted by the logger if the filter accepts them
the filter is optional (no filter means to accept all events)
2016-06-08 16:35:08 +02:00
Cedric Roux dfd2a541c3 Merge branch 'bugfix-11i-oaisim-frame' into 'develop'
improve the use of the variable "frame" in oaisim

The modifications are only in oaisim.c.
It is thus needless to run soft-modem tests.
Only oaisim tests are required.

See merge request !34
2016-06-08 15:52:51 +02:00
Cedric Roux 63652f94fa tick timeview/log
this is like timeview but the plotting is done at frame/subframe
resolution of a given reference clock signal, let's say.

The realtime information of the events is not used. It's all
logical.

It will be used to log harq processes for the moment.
2016-06-08 12:50:35 +02:00
Cedric Roux d350ee329d improve the use of the variable "frame" in oaisim 2016-06-08 12:25:07 +02:00
Cedric Roux 2b1287384a bugfix: include T.h in phich.c 2016-06-06 17:52:05 +02:00
Cedric Roux e0966584cf monitor tracee and local tracer to avoid "dead" processes
this may be removed at some point, it's very brutal. But when you
write some code, it may happen (it "may"!!) that *sometimes* the
code does not work and crashes. In thoses cases I prefer the
local tracer (or the tracee) to go away immediately without even
thinking about it maybe still running in the background.

In case of monitoring (as opposed to debugging) maybe it's preferable
to let the process live its life as it wants.

Time will tell.
2016-06-06 12:30:50 +02:00
Cedric Roux c96039108c update enb.c to trace uplink dci/retrans/ack/nack
and also start to use the PHY textview
2016-06-06 11:41:39 +02:00
Cedric Roux b87405ad7c add PHY uplink dci/retrans/ack/nack T traces 2016-06-06 11:40:46 +02:00
Cedric Roux 127ca5ee81 minor improvement
always a good idea to crash in unknown situations...
2016-06-06 09:35:12 +02:00
Cedric Roux 0b7d242083 enb.c stays alive if tracee dies
enb.c will then try to reconnect.
2016-06-05 17:57:57 +02:00
Cedric Roux 88c44ef9fe rename store_config_file load_config_file 2016-06-05 17:54:38 +02:00
Cedric Roux 18c2bdda98 don't abord if read fails in get_message
it may legitimately happen when the tracee is ctrl+c'ed.
Let's print something though because read may fail for
other reasons. Why not?
2016-06-05 17:47:08 +02:00
Cedric Roux 1a9d614f0e take care of SIGPIPE received when writing a dead socket
write() on a socket with the other end closed throws a SIGPIPE.
Let's ignore this signal. write() will return an error anyway...
2016-06-05 17:42:44 +02:00