laurent
bdee45878a
cleanup branch
2020-05-20 15:44:20 +02:00
cig
928dd902e3
Code cleanup
2020-05-20 12:41:06 +02:00
cig
783470905d
Bugfix: missing deactivation dlsch after processing is done:
...
- the issue popped up with the new rx/tx implementation at the UE
- this was causing false processing of DLSCH PDU and reception of false
TA commands
2020-05-20 12:41:05 +02:00
WANG Tsu-Han
a85a39048d
Merge branch 'develop' into NR_RRCConfiguration_trx_thread
2020-05-20 09:50:05 +02:00
matzakos
6d71096637
Change pseudo-subheader byte of random ULSCH PDU (phytest) to an appropriate value
...
- Apply a value which cannot be interpreted as any valid LCID at the MAC layer of the receiver gNB (as per 38.321 Table 6.2.1-2),
to avoid forwarding the random PDU to the upper layers in noS1 mode.
2020-05-17 13:03:24 +02:00
Raphael Defosseux
11783e755a
Fixing errored/missing circular dependency protection
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-05-15 15:39:11 +02:00
Thomas Schlichter
7fc9ab7720
use NR_UE_sched_ctrl_t instead of UE_sched_ctrl_t in gNB_scheduler
2020-05-14 18:38:08 +02:00
Thomas Schlichter
95833dde60
Merge branch 'develop'
2020-05-14 18:36:59 +02:00
Ahmed Hussein
566de5670b
Bug fixes regarding ping issues
2020-05-14 16:18:53 +02:00
cig
268a35419e
Hotfix scrambling rnti
...
- this is needed because in the current implementation of the gNB
the scrambling rnti is 0 for the RA and dci rnti otherwise
2020-05-12 17:38:47 +02:00
cig
4522cd4eb9
Changes to RA procedures:
...
- monitoring RA window
- taking RA_offset into account
- workaround to generate PRACH only when the RAR has not been received yet (RA is idle)
2020-05-12 17:33:28 +02:00
cig
66395ff7b7
Set RA offset at UE to compensate for 2 frames offset introduced by gNB
2020-05-12 17:28:35 +02:00
cig
8394ee82f5
More dynamic DCI configuration
2020-05-12 17:28:11 +02:00
cig
08b6211956
Scheduling of Msg2
2020-05-12 17:23:50 +02:00
cig
12b585a190
Fixes to RA procedure
2020-05-12 17:19:10 +02:00
cig
58dbf7d4b9
New design UE scheduler
2020-05-12 17:19:00 +02:00
Raphael Defosseux
e376241a82
Merge branch 'develop_integration_2020_w19' into 'develop'
...
Develop Integration Branch -- 2020 week 19
The following Merge Requests were included:
* MR [810] : NR PUCCH
* MR [812] : fix 20 compilation warnings
* MR [815] : rlc v2 -- coverity scan fixes
* MR [816] : hotfix: fix compilation of UE with --musim
Also add fixes for CI
2020-05-11 21:10:34 +02:00
Raphael Defosseux
f9403e9a2e
Merge remote-tracking branch 'origin/hotfix-ue-musim-compilation' into develop_integration_2020_w19
2020-05-11 11:22:48 +02:00
Raphael Defosseux
ab7ec85342
Merge remote-tracking branch 'origin/rlc_v2_coverity_fixes' into develop_integration_2020_w19
2020-05-11 11:22:34 +02:00
cig
96b5755753
Cleanup NR UE DCI configuration
2020-05-11 11:09:36 +02:00
cig
785ffa4def
Minor fixes
2020-05-11 11:09:36 +02:00
cig
4dc0e7f235
Enabled UE to process RX and TX in every DL or UL (or mixed) slot respectivey
...
- the commit fixes also the selection of the thread_id in TX procedures
- DCI configuration is currently limited to slot 1 and 7
2020-05-11 11:09:36 +02:00
cig
e3ba90b055
Fixes for polar and scrambling RNTI at UE
...
- including temporary hotfix for the polar rnti
2020-05-11 11:09:36 +02:00
Francesco Mani
cdead06962
fix for scrambling rnti and dci format
2020-05-11 11:09:36 +02:00
Cedric Roux
301ea42482
hotfix: fix compilation of UE with --musim
...
The following was failing:
./build_oai --UE --musim
Not sure this fix is correct, but it seems consistent with
the rest of platform_constants.h.
2020-05-09 10:12:38 +02:00
Cedric Roux
21a2a8c6e1
rlc v2: some fixes for 'bugs' found by coverity scan
...
Minor fixes, doesn't change anything. Not sure these are 'bugs' either,
but let's be polite with coverity scan...
One thing was not changed.
Coverity scan says:
*** CID 357991: Memory - illegal accesses (USE_AFTER_FREE)
/home/carabe/raphael/openairinterface5g/openair2/LAYER2/rlc_v2/rlc_entity_am.c: 507 in tx_list_remove_sn()
501 } else {
502 prev = cur;
503 cur = cur->next;
504 }
505 }
506
>>> CID 357991: Memory - illegal accesses (USE_AFTER_FREE)
>>> Using freed pointer "head.next".
507 return head.next;
508 }
509
510 void cleanup_sdu_list(rlc_entity_am_t *entity)
511 {
512 rlc_sdu_t head;
But as far as I understand, there is no problem. We don't access
head.next at all if it has been freed. Or is there some aliasing
going on there (pointer aliasing)? I doubt it. False positive?
2020-05-07 18:05:05 +02:00
Raphael Defosseux
bca9ecfd3c
add missing circular dependency protection
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-05-07 16:38:00 +02:00
Raphael Defosseux
2a8dacc009
CI: better code guideline analysis
...
-- check if C file has a GNU GPL license
-- check if C file has s suspect license
-- check if C header is having correct circular dependency protection (with Laurent Thomas's help)
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-05-07 16:35:28 +02:00
Raphael Defosseux
454139ac63
CI: fix a few typos in python framework
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-05-07 16:34:53 +02:00
Thomas Schlichter
25c4cea36f
remove now unnecessary frame_gap completely
2020-05-07 10:02:11 +02:00
Thomas Schlichter
aa7e10c405
also use the high 6 bits from MIB when calculating decoded_frame_rx after the initial synchronization
2020-05-07 10:02:11 +02:00
Thomas Schlichter
fa18a88fdb
fix updating UE->frame_gap and calculation if proc->frame_rx > dcireq.dl_config_req.sfn
2020-05-07 10:02:11 +02:00
Francesco Mani
d4929cc21e
bugfix in dmrs offset for pusch
2020-05-07 09:52:48 +02:00
Ahmed Hussein
1ffa9eed64
Bug fix regarding the uplink dmrs symbol position bitmask
2020-05-06 16:15:30 +02:00
Raphael Defosseux
ae5a1e4131
CI: fix unresolved merge conflicts
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-05-06 12:08:53 +02:00
Raphael Defosseux
29f984a60a
CI: fix missing class member for EPC
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-05-06 12:08:53 +02:00
Raphael Defosseux
0113a9b978
Merge remote-tracking branch 'origin/nr_pucch2' into develop_integration_2020_w19
2020-05-06 12:08:41 +02:00
laurent
da54778c4a
fix warnings
2020-05-03 18:27:07 +02:00
Thomas Schlichter
79471f2f6d
Merge branch 'develop' into NR_RRC_PRACH_procedures
...
Conflicts:
executables/nr-ue.c
openair1/PHY/NR_TRANSPORT/nr_dci_tools.c
openair1/PHY/NR_UE_TRANSPORT/nr_prach.c
openair1/PHY/defs_RU.h
openair1/SCHED_NR_UE/phy_procedures_nr_ue.c
openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_primitives.c
openair2/RRC/NR/rrc_gNB_nsa.c
openair2/X2AP/x2ap_eNB_handler.c
2020-04-30 18:54:37 +02:00
Raymond Knopp
4210c41179
removal of a massive number of warnings
2020-04-30 15:48:37 +02:00
Raphael Defosseux
cd82d94cb2
Merge branch 'develop_integration_2020_w17' into 'develop'
...
Develop Integration Branch -- 2020 week 17
See merge request oai/openairinterface5g!809
2020-04-30 14:37:31 +02:00
Raphael Defosseux
9f09885dbf
Merge remote-tracking branch 'origin/split73' into develop_integration_2020_w17
2020-04-30 10:37:22 +02:00
Raymond Knopp
7caf3d9cd9
Merge remote-tracking branch 'origin/develop' into nr_pucch2
...
Conflicts:
cmake_targets/autotests/test_case_list.xml
executables/nr-gnb.c
openair1/PHY/INIT/nr_init.c
openair1/PHY/TOOLS/tools_defs.h
openair1/PHY/defs_gNB.h
openair1/SCHED_NR/phy_procedures_nr_gNB.c
2020-04-30 09:48:13 +02:00
Raymond Knopp
cd3f5ad001
added parameters to generate_pucch2 in ue pucch procedures
2020-04-30 09:18:54 +02:00
Raphael Defosseux
7ad752232d
Merge remote-tracking branch 'origin/new_rlc_2020' into develop_integration_2020_w17
2020-04-29 18:50:32 +02:00
Cedric Roux
e5ea8a5a03
rlc v2: fix cmake file
2020-04-29 16:15:59 +02:00
Ahmed Hussein
fcf6439040
Fixed bug related to N_TA_offset not being applied at UE
...
- By default this value is equal to 0 at gNB in case of ulsim, but
has a value in case of RF simulator
- The N_TA_offset was calculated but not used at UE side
2020-04-29 12:08:22 +02:00
laurent
9ac5f6015d
update license text
2020-04-29 11:31:00 +02:00
Raphael Defosseux
8007758efe
Merge remote-tracking branch 'origin/split73' into develop_integration_2020_w17
2020-04-29 10:31:14 +02:00
Raphael Defosseux
c47daed70c
LIC: wrong license banner on proto-agent files
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2020-04-29 10:30:09 +02:00