maki/openairinterface5g
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,081 Commits 5 Branches 0 Tags
79a655d47e8a3c8bd35d64e5bcfb553d3df58310
Commit Graph
479 Commits
Author SHA1 Message Date
Cedric Roux e3782b5ca2 bugfix: fix PDCP sequence management (plus some cleanup) 
With the introduction of X2AP into develop, the UEs now have to regularly
send measurement reports.

In the logs of the eNB, we see:

[OSA]   Mismatch found in integrity for algorithm 2,
        got e0.a0.c2.66, expecting a5.9c.cb.57
[PDCP]   [OSA][RB 1] eNB failed to validate MAC-I of incoming PDU

This is a bug in the PDCP layer that uses wrong parameters to compute the
integrity.

This commit fixes this bug.

The function pdcp_is_rx_seq_number_valid was removed. Its processing
has been directly integrated into the function pdcp_data_ind.

The function pdcp_mark_current_pdu_as_received is not called anymore.
Its processing was not used later on, so as of today, not calling it does
not introduce any functional change.

The function pdcp_validate_security takes now as parameters both
SN and HFN. Same for the function pdcp_get_next_count_rx.

Useless constants PDCP_SN_5BIT, PDCP_SN_7BIT and PDCP_SN_12BIT have been
removed.

The compilation option ENABLE_SECURITY has been removed. It's now always
on. (This may impact some use cases.)

The PDCP for DRB using RLC AM is not correct. It was not correct before
this commit (apart from the integrity bug). We should deal with a list
of PDUs and transmit packets to upper layers as detailed in the specs.
Today we transmit the PDU as soon as we get it. We don't care about
duplicates, in-order delivery, timeouts.

Also, we don't deal with "PDCP re-establishment". Not sure how that impacts
the software.

And, last but not least, there is still no ROHC.
 2019-02-27 12:33:04 +01:00
Javier Morgade 39fe25a44d FeMBMS RRC->MAC config request protypes 2019-02-27 11:01:47 +01:00
OAI-admin c22f10aa72 Add PHR/BSR to RRCConnectionSetup + add some debug for DLSCH scheduling 2019-02-26 12:44:59 +01:00
nepes 282985eb2b RRC bugfix 2019-02-25 21:52:47 +01:00
frtabu fb46545526 Fix corrupted LOGs in L1L2simulator, introducing two new components NFAPI_VNF and NFAPI_pnf. Integrate Fujitsu fix for up to 50 UEs. Apply astyle to all modified files in the branch 2019-02-25 16:50:03 +01:00
Robert Schmidt 97126eb57e Fix carrierFreq MeasObj calculation to handle F1 case 2019-02-25 16:33:02 +01:00
Robert Schmidt cc2a507d59 Unify and comment RRC container print of F1 2019-02-25 16:23:42 +01:00
nepes b28b14411e modifications for LTE-M testing 2019-02-25 13:29:43 +01:00
Robert Schmidt 80b6245213 Remove comments left after merge 2019-02-22 18:38:34 +01:00
Robert Schmidt c75fd52e3a Remove many warnings 2019-02-22 15:22:13 +01:00
Robert Schmidt 030e11ba9a Merge branch 'develop' into feature-127-protocol-split 2019-02-21 20:18:35 +01:00
frtabu 38d772d8a2 nos1 et s1 execs identical, nos1 enforced based on exec name or --noS1 option 2019-02-17 23:46:45 +01:00
Javier Morgade fb435f2d48 Bugfix MBMS Initialization 2019-02-16 13:17:14 +01:00
Raphael Defosseux d14ad6797e Applying the cppcheck fix on last files 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 19:18:24 +01:00
Javier Morgade 74aee78635 MBMS Dedicated Serving Cell Params added 2019-02-15 13:03:31 +01:00
Raphael Defosseux 341fedd468 Merge branch 'issue394_fix_cppcheck' into develop_integration_2019_w07_v2 
--> openair2/LAYER2/MAC/eNB_scheduler_primitives.c is still old (not from issue394_fix_cppcheck branch)

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 12:24:19 +01:00
Javier Morgade 11dffe80b4 Basic SIB1-MBMS Initilization added 2019-02-15 11:55:20 +01:00
Javier Morgade 46a8c83b6c UE procedures for FeMBMS SIB1-MBMS (SystemInformationBlockType1-MBMS message) 
-- asn1 dissectors ETSI TS 136 331 V14.2.2 (2017-05)
	-- schedule_SI_MBMS
	-- ue_decode_si_mbms
 2019-02-14 15:35:00 +01:00
Cedric Roux e4443b1810 x2: fix compilation 2019-02-13 15:42:29 +01:00
Cedric Roux 1c6b9f0eda Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	openair2/LAYER2/MAC/config.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.c
	openair2/RRC/LTE/rrc_defs.h
 2019-02-13 15:20:45 +01:00
frtabu 60defa245d more fixes for cppcheck 2019-02-12 10:12:07 +01:00
Raymond Knopp e704e7ccc0 Merge remote-tracking branch 'origin/develop' into enhancement-ltem 2019-02-07 23:58:17 +01:00
Cedric Roux be68e1e651 Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	common/utils/msc/msc.h
	openair2/X2AP/x2ap_eNB.c
 2019-02-01 14:27:55 +01:00
Robert Schmidt d9d6ce374f Perform S1 UE Context Release Complete after corresponding F1 message 
This commits isolates the S1 UE Ctxt Rel Complete and GTP Tunnel Delete
Requests in functions and calls these function in the original place
(rrc_rx_tx()). The same functions are then used in the F1 UE Ctxt Rel
Complete handler to perform the same functionality, i.e. forward the UE
Ctxt Rel Complete message to the MME and free outstanding resources (RRC
context, GTP tunnels, S1 context).
 2019-01-25 16:37:57 +01:00
Raphael Defosseux 64144a8442 Merge remote-tracking branch 'origin/issue391-removeunusedcode_L2L1task' into develop_integration_2019_w04 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-24 15:33:19 +01:00
Raphael Defosseux 8260607ed6 CI: fix in L2-simulator VM build start script 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-22 21:37:40 +01:00
frtabu 9d0c70c9fe remove L1L2 task, also remove some call to send messages to UNKNOWN_TASK, removed in new itti. Align LOG in rlc sources with new LOG code (remove DEBUG_RLC...) 2019-01-21 19:43:19 +01:00
Cedric Roux 3ee6ccbeb5 fix enb nos1 ethernet compilation 2019-01-21 17:27:57 +01:00
Cedric Roux 1c4ec9e90b fix dlsim compilation 2019-01-21 17:24:26 +01:00
Konstantinos Alexandris 83c414fc83 remove warnings (nb_e_rabs_tobeswitched not in use) 2019-01-21 16:34:52 +01:00
Konstantinos Alexandris 80cf53a3c0 minor: fix spacing 2019-01-21 10:54:21 +01:00
Raymond Knopp c47e1fc97f Merge remote-tracking branch 'origin/develop' into enhancement-ltem 2019-01-19 12:14:23 +01:00
Robert Schmidt 7df8257526 F1AP: when UL_sync failure, send UEContextRelReq 
When a phone loses connection, it should not simply be removed but first
CU should be informed which will send a ContextRelCmd. Correspondingly,
when the RRC releases the UE, it does not send a UE Context Release Req
 2019-01-18 16:44:01 +01:00
Cedric Roux 7d481c5734 Merge remote-tracking branch 'origin/develop' into x2 2019-01-18 10:40:01 +01:00
Cedric Roux 246abce5d1 Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	openair2/ENB_APP/enb_config.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.h
	openair2/RRC/LTE/rrc_defs.h
	openair2/RRC/LTE/rrc_eNB.c
	openair2/RRC/LTE/rrc_eNB_S1AP.c
	openair2/RRC/LTE/rrc_proto.h
	openair3/GTPV1-U/gtpv1u_eNB.c
	openair3/S1AP/s1ap_eNB_handlers.c
 2019-01-18 10:35:39 +01:00
Robert Schmidt 0699e539fe Put RRC S1AP UEContextReleaseReq message inside corresponding if 2019-01-17 18:21:47 +01:00
Raphael Defosseux 4075fbc86a Merge remote-tracking branch 'origin/develop' into issue_345_l2_fapi_simulator_new_jan2019 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-17 18:19:46 +01:00
Cedric Roux 4cd58ac80a apply astyle 2019-01-16 11:44:38 +01:00
Raphael Defosseux d73685933c Merge remote-tracking branch 'origin/develop' into issue_345_l2_fapi_simulator_new 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-16 11:21:27 +01:00
Robert Schmidt 05e08d5094 Remove DU's UE RRC, MAC, RLC contexts correctly on UE RELEASE COMMAND 2019-01-10 16:51:04 +01:00
Cedric Roux aea6b4b5a6 fix a lot of file mode 
For whatever reason most of the files had their permission
changed from 644 to 755, which is not wanted.
 2019-01-07 16:22:28 +01:00
Raymond Knopp 44a225c6b7 Merge remote-tracking branch 'origin/develop' into enhancement-ltem 
Conflicts:
	openair1/PHY/LTE_TRANSPORT/dci_tools.c
	openair1/SCHED/fapi_l1.c
	openair1/SCHED/phy_procedures_lte_eNb.c
	openair2/COMMON/rrc_messages_types.h
	openair2/ENB_APP/enb_config.c
	openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
	openair2/LAYER2/MAC/eNB_scheduler_fairRR.c
	openair2/LAYER2/MAC/eNB_scheduler_primitives.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	openair2/LAYER2/MAC/mac.h
	openair2/RRC/LTE/L2_interface.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.h
	openair2/RRC/LTE/rrc_eNB.c
	openair2/RRC/LTE/rrc_eNB_S1AP.c
	targets/RT/USER/lte-enb.c
 2019-01-05 23:28:31 +01:00
laurent 4753f92bad remove more files, add a LOG_E() for UE not developped use case 2018-12-26 10:25:56 +01:00
laurent b3f1440249 issue 384 2018-12-23 17:55:07 +01:00
Konstantinos Alexandris ea105c39b1 X2AP MOBILITY PROCEDURES (X2AP HANDOVER REQUEST/REQUEST ACK) 
S1AP PATH SWITCH REQUEST/REQUEST ACK/FAILURE
RRC MEASUREMENT REPORT
MINOR CHANGES IN MAC LAYER
 2018-12-18 13:45:03 +01:00
Raymond Knopp adaa8e1337 debugging of DCI indication and UE-FAPI interface 2018-12-14 06:21:40 +01:00
Robert Schmidt 58850e3c86 Send F1 UE CONTEXT RELEASE REQ when RRC detects radio failure 2018-12-07 16:31:36 +01:00
Robert Schmidt ae3ef27059 Move F1 UE ctxt release req to function mac_eNB_rrc_ul_failure() 2018-12-07 15:37:32 +01:00
Robert Schmidt 956fafb51c F1AP_UE_CONTEXT_RELEASE_REQUEST/COMPLETE: Implement in CU 2018-12-07 14:16:42 +01:00
Raphael Defosseux 5d0fe4cea7 Fixing some compilation errors/warnings 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2018-11-28 20:31:24 +01:00