The files NativeInteger.c.diff and constr_SET_OF.c.diff
from asn1c were generating compilation warnings. We had
local patches applied on generated files by asn1c.
A new version of asn1c has been pushed to
https://gitlab.eurecom.fr/oai/asn1c
(commit 224dc1f991b7e7ad705ce92e171b942f87b7b7e7)
making obsolete the fixes we do here.
So we now remove those fixes.
*************************
* IMPORTANT BEGIN *
*************************
Everyone should update their asn1c installation.
The simplest is to do:
source oaienv
cd cmake_targets
./build_oai -I
*************************
* IMPORTANT END *
*************************
- import RRC ASN.1 defintions from the specifications
(file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn)
contrary to rel8/10, all modules have been imported, maybe it's too much
to refine in case of problems
- deal with rel14 in fix_asn1
- all code that was for Rel10 is now for Rel10/Rel14
- some incompatible changes (mostly in naming) were resolved in favor
of rel14, see in openair2/RRC/LITE/defs.h
- unsure about the rlc layer, some arrays have changed (values appended),
I only changed the definition and in tests in the code, I changed
the index limit, maybe it's not enough
Rel14 is the default compilation mode.
Also modified CMakeLists.txt to run asn1tostruct.py at cmake time,
because the generated Makefile was wrong. When compiling with -j4
it would mess up by calling fix_asn1 twice with a weird timing,
leading to failures.
The strategy is rather basic. Files with warnings are replaced
by an edited copy that triggers no warning.
We take care to check that the replaced file is the same as the
one that was analyzed at the time of warning removal (through
checking its SHA1).
There is a new bash script "fix_asn1" in cmake_targets/tools
and the files replacing the existing ones are in
cmake_targets/tools/fix_asn1.data.
WEI-TAI CHEN