Commit Graph
407 Commits
Author SHA1 Message Date
Cedric Roux c824eea074 better (maybe) freeing of RA process when an UE is removed from MAC
The RA process may be in the state:
RA_active == FALSE and wait_ack_Msg4 == 1

Testing only the rnti should be enough, if everything else works
properly.

Also, don't break, just in case. (Not sure it makes a
difference.)
2017-01-20 15:21:37 +01:00
Cedric Roux c3c2b774d6 bugfix: do not get pCC_id if UE_id is invalid 2017-01-20 15:15:58 +01:00
Cedric Roux 0d3fa21187 add a LOG in RA 2017-01-20 15:11:40 +01:00
Cedric Roux 428c2212aa fix: better creation of RNTI
The previous version was calling taus(), which
may return any value in [0..65535].

The new version restricts it to [1024..59999]
(arbitrary values, big enough, and in the valid range).

It also checks that the new RNTI is not already present
in the MAC.

I think we should also check that it's not used by a RA
process.

The "loop" thing may not be the best solution either.

To be refined.
2017-01-20 15:09:05 +01:00
Cedric Roux c1fee62473 RA: fix allocation of RA process
A RA process is not available if
and RA_template[i].wait_ack_Msg4 != 0

We can have RA_active==FALSE and wait_ack_Msg4==1,
in which case the RA process is in use and cannot
be reassigned.
2017-01-20 15:05:28 +01:00
Cedric Roux a5d5a21ddb "fix" handling of UE_id in RA.
What if it's -1? Is it possible?
We catch the case and abort.

We may do a proper fix if the case happen.
I don't think it will, but who knows...
2017-01-20 15:01:51 +01:00
Cedric Roux c33afccb1b bugfix: logging was done after modification of values
It resulted in wrong log message, leading to complicated
debugging.
2017-01-20 14:57:28 +01:00
Cedric Roux 2a1d1134e9 log an error if UE is -1 in rrc_mac_config_req 2017-01-20 14:54:19 +01:00
Cedric Roux 5933f21882 hack to avoid zombie UEs in the MAC layer
Here is the problem:
    Sometimes the UE has no PHY context but
    is still present in the MAC with 'ul_failure_timer' = 0 and
    'ul_out_of_sync' = 0. It seems wrong and the UE stays there forever. Let's
    start an UL out of sync procedure in this case.
    The root cause of this problem has to be found and corrected.
    In the meantime, this hack...

This has to be redone at some point.
2017-01-19 10:00:19 +01:00
Cedric Roux 05d02c43ec remove annoying logging (dump_CCE_table) 2017-01-19 09:49:39 +01:00
Cedric Roux adbc609bbf bugfix: reset DCI count before adding one
The management of uplink failure generates a DCI to send
a RA PDCCH order. It calls add_ue_spec_dci which increases
DCI_pdu[CC_id]->Num_ue_spec_dci, but this was reset to 0
*after* the DCI generation. Let's reset *before*.

Bug reported by Liang Yong on openair5g-user mailing list.
2017-01-18 10:33:52 +01:00
Cedric Roux 67e53e72ab fix the use of get_eNB_UE_stats
The function may return NULL if the UE has been dropped
in the PHY layer but is still present in the MAC layer.

Deal with the NULL case everywhere it's needed.
2017-01-16 17:07:47 +01:00
Cedric Roux f2f32f5340 fix LOG_X macros
Some of them might not be correctly handled.
I put /* TODO: XXX */ where I didn't know if
the fix was correct.
2017-01-11 15:48:00 +01:00
Cedric Roux 40add2d572 Merge remote-tracking branch 'origin/various-fixes-2016-w50' into develop_integration_wk01 2017-01-06 18:03:32 +01:00
Wilson W.K. Thong 2e7c28a591 fix incorrect PUCCH format causing no SR received by eNB in TDD
fix incorrect fss_pusch calculation
fix the incorrrect HARQ-PID checking
remove incorrect checking on downlink DCI HARQ PID value
fix incorrect downlink ACK/NACK feedback procedures in TDD
fix no activating PDSCH decoding when DL-DCI is indicating a downlink retransmission

see issue #176
2017-01-06 12:01:05 +08:00
Raymond.Knopp a190005316 fixes for SRB2 in MAC/RRC. 2017-01-05 08:19:28 +01:00
Cedric Roux 2a62db97e6 Merge remote-tracking branch 'origin/develop' into develop_integration_w50 2016-12-16 22:47:18 +01:00
gabrielC f79dd53edf Merge remote-tracking branch 'origin/feature-21-TM7-tmp' into develop_integration_w50 2016-12-15 11:39:04 +01:00
hbilel ca078ff549 fix compilation error 2016-12-13 17:38:43 +01:00
hbilel 495e357a1e Merge branch 'develop1B' of https://gitlab.eurecom.fr/oai1B/openairinterface5g into enhancement-45
Conflicts:
	openair2/LAYER2/MAC/ue_procedures.c
2016-12-13 12:31:45 +01:00
Chia-Yu Chang 7f4c961d82 add T messages for FLEXRAN and fix a complication error in FLEXRAN 2016-12-12 18:41:26 +01:00
hbilel e0bf855fbf initialize max retans tx Mlimit 2016-12-12 12:12:27 +01:00
hbilel e04e8a62cc remove mac-struct usage from phy 2016-12-12 11:45:22 +01:00
gabrielC bd30471076 [OAI-UE] merge com4Innov branch to integration branch 2016-12-08 11:07:38 +01:00
Florian Kaltenberger e470e2d3bd Merge remote-tracking branch 'origin/develop' into feature-21-TM7-tmp
Conflicts:
	targets/RT/USER/lte-enb.c
2016-12-07 09:40:20 +01:00
Wilson W.K. Thong 55e50b2052 enhanced wireshark logging. also logs BCH, PRACH and RAR. Tested with wireshark 2.2.2 on linux and windows
see issue #45
2016-12-07 10:45:44 +08:00
Wilson W.K. Thong 4041a661fc fixed incorrect wiresahrk SFN/SF for UL/DL data 2016-12-07 10:43:47 +08:00
gabrielC 0fb34b2e28 Merge branch 'develop' of https://gitlab.eurecom.fr/oai/openairinterface5g into develop1B 2016-12-06 12:05:25 +01:00
Xenofon Foukas 8def47c488 Changed old licenses in FlexRAN agent source files 2016-12-05 22:04:12 +02:00
fnabet bc032392c9 add workarounds for OAI issues 2016-12-05 16:51:27 +01:00
hbilel ea7c0e1b36 reduce BSR logging 2016-11-29 15:26:57 +01:00
GabrirelCouturier b80ce3510e BSR and MAC UL encoding fixes 2016-11-28 19:27:25 +01:00
hbilel 710a246596 enhance BSR log 2016-11-28 10:55:00 +01:00
hbilel ca2aeaccb8 BSR and MAC multiplexing fixes 2016-11-28 10:36:46 +01:00
Rohit Gupta 045c947015 Merge branch 'develop' into feature-68-enb-agent 2016-11-25 10:08:53 +01:00
hbilel b0b472e035 BSR fixes on CMW500 2016-11-24 18:17:21 +01:00
fnabet 880cddb4a0 Merge branch 'develop1B' into BSR_fixes_fabrice 2016-11-24 11:39:56 +01:00
fnabet 6f0b71deac merge Calvin changes and add fixes 2016-11-24 11:37:13 +01:00
Florian Kaltenberger f446a5ea17 Merge branch 'develop' into feature-21-TM7 2016-11-22 18:24:40 +01:00
Cedric Roux b526ef7b47 T: update a trace
add ndi to trace ENB_MAC_UE_DL_SDU
2016-11-22 12:04:06 +01:00
Cedric Roux 6bb69e1964 hotfix: correct Msg3 ressource blocks reservation
The Msg3 ressource blocks used by random access procedure
were not correctly handled. The MAC scheduler could wrongly
allocate a ressource block for both random access Msg3 and
a regular UE.

This hotfix hopefully fixes the problem.

A new function "set_msg3_subframe" has been added in the
interface between PHY and MAC.
2016-11-22 10:38:18 +01:00
GabrirelCouturier 34b75f393d Merge branch 'develop' of https://gitlab.eurecom.fr/oai/openairinterface5g into bugfix-26 2016-11-21 11:19:30 +01:00
Florian Kaltenberger 8769024922 Merge remote-tracking branch 'origin/develop' into feature-21-TM7
Conflicts:
	cmake_targets/CMakeLists.txt
	openair1/PHY/INIT/lte_init.c
	openair1/PHY/INIT/lte_param_init.c
	openair1/PHY/LTE_ESTIMATION/lte_dl_channel_estimation.c
	openair1/PHY/LTE_ESTIMATION/lte_ue_measurements.c
	openair1/PHY/LTE_REFSIG/lte_dl_uespec.c
	openair1/PHY/LTE_TRANSPORT/dci.c
	openair1/PHY/LTE_TRANSPORT/dlsch_demodulation.c
	openair1/PHY/LTE_TRANSPORT/dlsch_llr_computation.c
	openair1/PHY/LTE_TRANSPORT/dlsch_modulation.c
	openair1/PHY/LTE_TRANSPORT/initial_sync.c
	openair1/PHY/LTE_TRANSPORT/pbch.c
	openair1/PHY/LTE_TRANSPORT/pilots.c
	openair1/PHY/LTE_TRANSPORT/pmch.c
	openair1/PHY/LTE_TRANSPORT/proto.h
	openair1/PHY/defs.h
	openair1/SCHED/phy_procedures_lte_eNb.c
	openair1/SCHED/phy_procedures_lte_ue.c
	openair1/SIMULATION/LTE_PHY/dlsim.c
	openair1/SIMULATION/LTE_PHY/mbmssim.c
	openair1/SIMULATION/LTE_PHY/pdcchsim.c
	openair1/SIMULATION/LTE_PHY/ulsim.c
	openair2/ENB_APP/enb_config.c
	openair2/RRC/LITE/rrc_eNB.c
	targets/ARCH/EXMIMO/USERSPACE/LIB/openair0_lib.c
	targets/RT/USER/lte-softmodem.c
	targets/RT/USER/lte-ue.c
	targets/RT/USER/sched_rx_pdsch.c
	targets/SIMU/USER/init_lte.c
	targets/SIMU/USER/oaisim_functions.c
2016-11-18 15:35:21 +01:00
GabrirelCouturier 7f74065484 BSR fixes for ping 2016-11-18 15:22:11 +01:00
calvin wang 319ae6fbbf fix bsr report inaccurate value 2016-11-18 16:44:18 +08:00
fnabet 69ccc900e8 fix BSR long size and fill 2016-11-16 18:24:04 +01:00
Xenofon Foukas c0ad88e537 Fixed bug in the creation of MAC PDUs in the local flexran scheduler 2016-11-16 16:12:30 +02:00
hbilel f0f34c029b BSR fixes with CMW500 2016-11-15 16:13:24 +01:00
calvin wang 3bd591bfec change bsr trigger 2016-11-15 18:41:46 +08:00
calvin wang 6097e0516f fix build error 2016-11-14 11:10:33 +08:00