Robert Schmidt
f79bab42fa
Merge remote-tracking branch 'origin/asn1_log_issue' into integration_2023_w30
2023-07-29 07:24:15 +02:00
Alireza Mohammadi
5f5b8f2914
Fix for ASN1 logging: change name from ASN to ASN1
...
There is a conflict with some E2AP definitions that put ASN as a
preprocessor definition. To avoid this conflict, and since ASN1 is more
descriptive than ASN, we change the logging mechanism name from ASN to
ASN1.
2023-07-28 12:21:22 +02:00
Robert Schmidt
b0b3c7ee67
Merge remote-tracking branch 'origin/t-tools-dependency-fix' into integration_2023_w29
2023-07-21 15:32:54 +02:00
Robert Schmidt
1f8e95833c
Merge remote-tracking branch 'origin/fix_warnings_gcc13' into integration_2023_w29
2023-07-21 14:06:41 +02:00
mir
e04554dcb0
Warnings generated in gcc 13 and tackled in this PR (except const correctness)
...
49 /home/mir/workspace/oai_dev/common/utils/T/tracer/to_vcd.c: In function ‘main’:
50 /home/mir/workspace/oai_dev/common/utils/T/tracer/to_vcd.c:349:30: warning: ‘%s’ directive writing up to 240 bytes into a region of size between 11 and 251 [-Wformat-overflow=]
51 349 | sprintf(format, "%c [%s] %s",
52 | ^~
53 In file included from /usr/include/stdio.h:894,
54 from /home/mir/workspace/oai_dev/common/utils/T/tracer/to_vcd.c:1:
55 In function ‘sprintf’,
56 inlined from ‘main’ at /home/mir/workspace/oai_dev/common/utils/T/tracer/to_vcd.c:349:5:
57 /usr/include/x86_64-linux-gnu/bits/stdio2.h:38:10: note: ‘__builtin___sprintf_chk’ output between 6 and 486 bytes into a destination of size 256
58 38 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
59 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
60 39 | __glibc_objsize (__s), __fmt,
61 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
62 40 | __va_arg_pack ());
63 | ~~~~~~~~~~~~~~~~~
2005 /home/mir/workspace/oai_dev/openair1/SIMULATION/TOOLS/random_channel.c:1726:6: warning: conflicting types for ‘set_channeldesc_owner’ due to enum/integer mismatch; have ‘void(channel_desc_t *, uint32_t)’ { aka ‘void(channel_desc_t *, unsigned int)’} [-Wenum-int-mismatch]
2006 1726 | void set_channeldesc_owner(channel_desc_t *cdesc, uint32_t module_id) {
2007 | ^~~~~~~~~~~~~~~~~~~~~
2008 In file included from /home/mir/workspace/oai_dev/openair1/SIMULATION/TOOLS/random_channel.c:31:
2009 /home/mir/workspace/oai_dev/openair1/SIMULATION/TOOLS/sim.h:348:6: note: previous declaration of ‘set_channeldesc_owner’ with type ‘void(channel_desc_t *, channelmod_moduleid_t)’
2010 348 | void set_channeldesc_owner(channel_desc_t *cdesc, channelmod_moduleid_t module_id);
2011 | ^~~~~~~~~~~~~~~~~~~~~
24209 /home/mir/workspace/oai_dev/openair1/SCHED_UE/phy_procedures_lte_ue.c:954:17: warning: ‘n1_pucch_inter’ may be used uninitialized [-Wmaybe-uninitialized]
24210 954 | return(n1_pucch_inter);
24211 | ^
24212 /home/mir/workspace/oai_dev/openair1/SCHED_UE/phy_procedures_lte_ue.c:647:60: note: ‘n1_pucch_inter’ was declared here
24213 647 | uint16_t n1_pucch0=0,n1_pucch1=0,n1_pucch2=0,n1_pucch3=0,n1_pucch_inter;
24214 |
2023-07-21 09:39:36 +02:00
Robert Schmidt
d989760d1f
Merge remote-tracking branch 'origin/incorrectStringBooleanError_cppcheck_fix_on_w27_2023' into integration_2023_w29
2023-07-20 17:28:43 +02:00
Robert Schmidt
7c847cd908
Merge remote-tracking branch 'origin/uninitvar_cppcheck_fix_on_w27_2023' into integration_2023_w29
2023-07-20 17:28:34 +02:00
Robert Schmidt
372c067335
T GUI tools: guard with cmake option, default off
...
The T tools offering a GUI use libxft as a dependency. By default, we
try to limit the amount of dependencies, but libxft comes with X11.
Put the GUI tools behind cmake option T_TOOLS_GUI (default: off) to only
build on demand with a cmake option.
2023-07-20 13:42:26 +02:00
Vaibhav Shrivastava
428f9c0946
fix uninitialized variable warnings found by cppcheck
2023-07-19 16:43:33 +02:00
Robert Schmidt
b55bff37ca
Merge remote-tracking branch 'origin/ue-code-cleanup' into integration_2023_w28
2023-07-13 16:56:36 +02:00
Robert Schmidt
9132992801
T: add tutorial for new trace
2023-07-13 10:29:33 +02:00
Cedric Roux
ad8612abd6
Import T documentation from wiki
2023-07-13 10:29:33 +02:00
Robert Schmidt
abf04db97b
Allow to use cmake to generate T tracer programs
...
- Add CMakeLists.txt to build all T tracer user tools
- Previous Makefiles are retained in common/utils/T: you can do
$ cd common/utils/T/tracer
$ make # all executables are there
or also
$ mkdir build && cd build
$ cmake .. -GNinja
$ ninja T_tools # all executables are in build/common/utils/T/tracer
2023-07-13 10:29:33 +02:00
Cedric Roux
8a2a5015e6
T tracer tools: fix memory leaks, clang warnings
...
- Fix memory leaks detected by ASan
- Initialize variables that are flagged by compiler
- C struct initializer: x:y needs to be .x=y
2023-07-13 10:29:33 +02:00
Robert Schmidt
c853f74167
Include T.h in log.h only when T_TRACER=ON
2023-07-13 10:29:33 +02:00
Robert Schmidt
2ae1908339
Put T source library in subdirectory, don't build multiple times
...
- UTIL: has LOG which brings as (public) dependency T, so link it publicly
- Move T to top to ensure all targets can have it
2023-07-13 10:28:38 +02:00
Vaibhav Shrivastava
ae751e13ca
incorrectStringBooleanError CPPCheck warnings fix on W27
2023-07-12 17:43:05 +05:30
laurent
9121541b3c
only cleaning
2023-07-10 12:00:25 +02:00
Robert Schmidt
c3f8488456
Generate T headers using cmake
2023-07-10 09:18:14 +02:00
Robert Schmidt
4ae73af46f
Merge remote-tracking branch 'origin/cmake-refactor' into integration_2023_w27
2023-07-08 13:29:55 +02:00
Robert Schmidt
28ec4944a5
Fix minimal_stub.c
...
It uses definitions from stdlib.h, so include it.
2023-07-07 08:35:28 +02:00
Robert Schmidt
7ebdaf35c5
Remove cmake ENB_MODE option
...
ENB_MODE is a cmake option to swap the order of include directories.
This has historical reasons; before OAI used cmake, it was very
sensitive to the order of includes. Nowadays, the order does not matter.
Remove this option, and fix the compilation issues that arise while
doing so.
2023-07-07 08:35:28 +02:00
Robert Schmidt
49703eee7b
Rename threadPoolMeasurements to OAI_THREADPOOLMEASUREMENTS
...
- make it clear that it belongs to OAI
- follow convention of uppercase name
2023-06-28 07:16:00 +02:00
Robert Schmidt
ba11dfba4e
Rename env var gdbStacks to OAI_GDBSTACKS
...
- make it clear that it belongs to OAI
- follow convention of uppercase name
2023-06-28 07:16:00 +02:00
Robert Schmidt
96aacd58aa
Merge remote-tracking branch 'origin/remove-thread-pool-abort' into integration_2023_w24
2023-06-16 17:54:11 +02:00
Robert Schmidt
eca43633ee
Merge remote-tracking branch 'origin/NR_SSB_sync_raster_check' into integration_2023_w24
2023-06-16 11:08:56 +02:00
laurent
615324294b
ldpc check based on crc
2023-06-12 10:24:57 +02:00
Laurent THOMAS
3645c96c09
remove generic thread pool abort
2023-06-12 10:24:37 +02:00
laurent
1b09f683f9
Fix compilation errors due to -Werror
2023-06-08 19:15:24 +02:00
francescomani
ce7d6cc3fb
review
2023-06-08 14:56:14 +02:00
Vijay Chadachan
836469e849
CPPCHECK fixes for printf issues
...
Fix for following CPPCheck warnings
- invalidPrintfArgType
Rebased with latest develop branch w21.
Reverted modifications unrelated to printf issues.
2023-06-01 12:07:26 +02:00
Raphael Defosseux
dacbcc0d55
Merge remote-tracking branch 'origin/fix-get_samplerate_and_bw' into integration_2023_w19
2023-05-11 13:27:11 +02:00
Raphael Defosseux
211fcb217a
Merge remote-tracking branch 'origin/threading-rk' into integration_2023_w19
2023-05-11 13:24:50 +02:00
Cedric Roux
c68549d861
modification of get_samplerate_and_bw(): add break where needed
2023-05-07 15:24:51 +02:00
Robert Schmidt
a8879d3b9c
Merge remote-tracking branch 'origin/remove-some-globales' into integration_2023_w17
2023-05-02 18:39:25 +02:00
Raymond Knopp
a3c7af0a7a
Merge remote-tracking branch 'origin/develop' into threading-rk
2023-04-28 22:28:18 +02:00
laurent
b339460666
cleanup only
2023-04-28 16:25:24 +02:00
rakesh mundlamuri
594fb18cc8
adressing the comments
2023-04-24 11:05:05 +02:00
Robert Schmidt
418c6e23f0
Merge remote-tracking branch 'origin/NR_common_duplicated_function' into integration_2023_w16b
2023-04-22 07:51:14 +02:00
Robert Schmidt
302f016650
Merge remote-tracking branch 'origin/NR_UE_TA_procedures_at_MAC' into integration_2023_w16b
2023-04-22 07:48:58 +02:00
francescomani
87d9517738
avoid duplicated function in nr_common for supported bandwidth
2023-04-20 18:16:37 +02:00
laurent
b735f8bec6
ubsan fixes
2023-04-19 22:12:08 +02:00
Raymond Knopp
7d3a0cd157
Merge remote-tracking branch 'origin/develop' into threading-rk
2023-04-18 23:25:38 +02:00
Robert Schmidt
04451c7078
Merge remote-tracking branch 'origin/clang_warnings_new' into integration_2023_w15
2023-04-14 13:54:46 +02:00
Robert Schmidt
224c5538e4
Merge remote-tracking branch 'origin/NR_UE_get_Pmax' into integration_2023_w15
2023-04-14 13:54:40 +02:00
francescomani
eb09a63001
separating MAC and PHY procedures for TA
2023-04-12 10:32:35 +02:00
Raymond Knopp
455e2203e7
Merge remote-tracking branch 'origin/develop' into threading-rk
2023-04-09 18:29:42 +02:00
francescomani
e49c6db2bf
final round of warning fixes to compile nr softmodems
2023-04-07 15:52:16 +02:00
francescomani
41d9e775c9
reworking the function to get Pmax
2023-04-07 11:33:14 +02:00
Sakthivel Velumani
f3be849904
Delete job data when no response FIFO
2023-04-03 10:24:26 -04:00