Commit Graph
3221 Commits
Author SHA1 Message Date
Cedric Roux d1fdbfedbc fix power estimation
Some computation has been fixed in PUCCH reception.

SNR has been fixed, uses measurement instead of
a fixed value for the noise.

normalized_rx_power and target_rx_power have been removed,
replaced by snr and target_snr. All the files using those
variables have been updated.
2019-07-19 17:10:42 +02:00
Raphael Defosseux dccda75168 Fix for FDD DL performance issue
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
2019-07-16 12:33:12 +02:00
Cedric Roux 2421b71d68 x2ap/sctp: increase buffer size
The 5G phone OPPO has a very big UE capability (> 2KB).

We need bigger buffers to transfer this, especially in x2 handover.

Also the sctp messages need a bigger buffer.

Note: in sctp, we didn't check for partial messages, it's now
      done. When detected, we exit. To be redone differently
      if needed. (Look for "if (!(flags & MSG_EOR))".)
2019-07-11 16:34:28 +02:00
Cedric Roux 8a8fdd59c2 cleanup: no variable definition in header file
We declare variables in header files, we don't define them. So we need
to use 'extern' in the header file and put the definition
in some C file.
2019-07-11 15:28:33 +02:00
Raphael Defosseux a03ef2bfc3 Merge remote-tracking branch 'origin/hotfix-measurement-report' into develop_integration_2019_w27 2019-07-05 11:24:24 +02:00
Raphael Defosseux 3f2acf9485 Fix Coverity Scan CID 342010
Fix a few cppcheck errors/warnings

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
2019-07-05 11:03:30 +02:00
Cedric Roux e0eac2e331 hotfix: do not set s-Measure in measurement report configuration
The value was set to 20 which means -120 dB. Setting this value means
that the UE reports an event only if the RSRP of the serving cell
is lower than -120 dB.

In the lab, we get values of around -70, and to go as low as -120
means a very degraded environment. This is not practical.

Let's disactivate the setting of this parameter for the moment so that
the UE reports an event without taking into consideration the RSRP
of the serving cell.

With this hotfix, the X2 handover works much better.
2019-07-04 14:47:11 +02:00
Raphael Defosseux 6eb4661a5d Merge remote-tracking branch 'origin/fix-init-cu' into develop_integration_2019_w27 2019-07-04 12:54:46 +02:00
Raphael Defosseux 6e1cac6e8b Merge remote-tracking branch 'origin/flexran_agent_rrc_cm_rebased2' into develop_integration_2019_w27 2019-07-04 12:53:08 +02:00
laurent 924e10f73a fix rfsim ue initial sync and legacy OAI C struct syntax 2019-07-01 15:17:07 +02:00
Robert Schmidt e26f7d7555 F1: correctly initialize CU RRC params (clean up code after 99012f88b9) 2019-06-27 14:22:10 +02:00
Robert Schmidt 5b12a60950 Flexran-triggered RRC Reconf: free memory of mac_MainConfig after setting new, do not free new memory 2019-06-25 15:47:52 +02:00
Robert Schmidt 0f568fd40a FlexRAN: Comment non-functional code regarding Neigh CGI PLMN ID reporting 2019-06-25 10:40:12 +02:00
Robert Schmidt f1a1ff036d FlexRAN: HO request first check whether X2 is active, minor indentation fixes 2019-06-24 17:55:13 +02:00
Robert Schmidt a6be54a6f4 Fix: X2 Setup Req/Resp: first check, then increase number of cells 2019-06-24 17:54:38 +02:00
Robert Schmidt 960e8dc9d8 FlexRAN: Calculate sfnsn such that diff 1s = 1000 2019-06-24 16:29:14 +02:00
Robert Schmidt a90a7f352e Additional messages for error diagnosis for net-ctrld HO 2019-06-24 16:29:14 +02:00
Robert Schmidt 67fc2f7c62 FlexRAN: add GTP statistics in UE stats through RRC module 2019-06-24 16:29:14 +02:00
Konstantinos Alexandris 75e3622daf Configure eNB for X2 handover controlled by network (ignore UE HO request) 2019-06-24 16:29:14 +02:00
Konstantinos Alexandris 8957cfef78 Add HO trigger function via FlexRAN controller (OAI + FlexRAN handler) 2019-06-24 16:29:14 +02:00
Konstantinos Alexandris 5e148d439a Legal 3GPP values check for measurement report parameters 2019-06-24 16:29:14 +02:00
Robert Schmidt 939251e004 Fix: Memory allocation for offsetFreq parameter 2019-06-24 16:29:14 +02:00
Robert Schmidt 8cf520d283 Rename FlexRAN RRC reconfiguration function, simplify function 2019-06-24 16:29:11 +02:00
Konstantinos Alexandris 1b90c4a02d Create RRC setters for Periodic, A1-A5 event and offsets related to RRC Measurement Report 2019-06-24 16:28:16 +02:00
Konstantinos Alexandris 1de4b7400b Fix: flexran agent for HO case, to be tested if Nb_ue in RRC is needed 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 3cd1717fb6 add measurement information/clean-up measurement report in flexran agent 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris f5e928afab Fix: condition on CellsToAddModList memory allocation in case of zero neighbouring cells 2019-06-24 16:15:44 +02:00
Robert Schmidt 76a7b7036e FlexRAN: Add Protobuf UE-specific RRC measurement report configuration 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 772dc508e8 Fix: Segfault error, free properly measurement info struct, add rsrp/rsrq filter coefficient 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris b7530528e0 To be tested: Add code for measurement report based on the neighbouring cells after x2 setup, ocs/ocn for multiple cells 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 5dfec71629 Fill in the RRC Measurement info struct in the RRC layer 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 0eeee616d8 Create RRC struct and getters for Periodic, A1-A5 event and offsets related to RRC Measurement Report 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 7024f289a6 fixes: segmentation faults issues in RRC CM for RRC Measurement report, clean-up and re-implementation of functions in RAN API 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 9ec157d9e1 Add neighbouring cells (cgi,plmn), clean-up a bit current RRC CM 2019-06-24 16:15:08 +02:00
Raphael Defosseux 99012f88b9 HACK: force initialization of variables in CU case!
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
2019-06-21 16:02:23 +02:00
Raphael Defosseux 8931915030 Merge remote-tracking branch 'origin/434-coverity-scan-fix-week25' into develop_integration_2019_w25 2019-06-21 13:04:51 +02:00
Raphael Defosseux 18b8bd4ee9 Merge remote-tracking branch 'origin/bugfix-rrc-ue-removal' into develop_integration_2019_w25 2019-06-21 13:03:39 +02:00
Cedric Roux f6f83ca01b bugfix: fix RRC UE removal
If several UEs are removed, the variable ue_to_be_removed may be overwritten.
Let's use an array instead.
2019-06-20 17:20:20 +02:00
Dong Anyuan 3adb2efd8c Fix Coverity Scan CID 339954 (Overrunning callee's array of size 16 by passing argument ue_id (which evaluates to 65535) in call to flexran_set_ue_ul_slice_idx.) 2019-06-20 14:06:32 +09:00
Dong Anyuan 2f2f21d2aa Fix Coverity Scan CID 339964 (Passing &rrc_eNB_mui to function rrc_eNB_process_S1AP_DOWNLINK_NAS which uses it as an array. This might corrupt or misinterpret adjacent memory locations.) 2019-06-20 14:06:04 +09:00
Dong Anyuan 486f1368e0 Fix Coverity Scan CID 339974 (Overrunning array eutra_bandtable of 48 24-byte elements at element index 48 (byte offset 1152) using index i (which evaluates to 48).) 2019-06-20 14:05:13 +09:00
Dong Anyuan f3c3a1ff67 Fix Coverity Scan CID 340004 (Overrunning array eutra_bandtable of 48 24-byte elements at element index 48 (byte offset 1152) using index i (which evaluates to 48).) 2019-06-20 14:03:17 +09:00
Dong Anyuan a70288769a Fix Coverity Scan CID 340209 (Variable message_p going out of scope leaks the storage it points to.) 2019-06-20 14:02:45 +09:00
Dong Anyuan 9b80070a59 Fix Coverity Scan CID 340211 (Variable message_p going out of scope leaks the storage it points to.) 2019-06-20 14:02:11 +09:00
Dong Anyuan c7d2937e35 Fix Coverity Scan CID 340221 (Variable msg going out of scope leaks the storage it points to.) 2019-06-20 14:01:40 +09:00
Dong Anyuan 4a3f26b2cf Fix Coverity Scan CID 340228 (Handle variable s going out of scope leaks the handle.) 2019-06-20 14:01:05 +09:00
Dong Anyuan f1fdff80a0 Fix Coverity Scan CID 340235 (Using variable UE_id_mac as an index to array RC.mac[ctxt_pP->module_id]->UE_list.UE_sched_ctrl.) 2019-06-20 13:59:53 +09:00
Dong Anyuan bca84e8160 Fix Coverity Scan CID 340237 (Using variable UE_id as an index to array UE_list->UE_sched_ctrl.) 2019-06-20 13:59:21 +09:00
Dong Anyuan 6087373184 Fix Coverity Scan CID 340245 (Variable Sparams going out of scope leaks the storage it points to.) 2019-06-20 13:58:08 +09:00
Dong Anyuan 8e599681b0 Fix Coverity Scan CID 340247 (Variable pc5s_header going out of scope leaks the storage it points to.) 2019-06-20 13:57:34 +09:00