Commit Graph
988 Commits
Author SHA1 Message Date
Wu Jing e4dfc07553 Fix: reestablishment timer when there are two reestablishmentrequest at a moment 2019-07-16 19:28:20 +09:00
Haruki NAOI 25a1e76a0e Fix: avoid pthread_mutex_lock abort.
This commit is workaround. This issue realy occures with the following log.
lte-softmodem: ../nptl/pthread_mutex_lock.c:81: _pthread_mutex_lock: Assertion `mutex->_data.__owner == 0' failed.
2019-07-16 19:23:29 +09:00
Cedric Roux 2421b71d68 x2ap/sctp: increase buffer size
The 5G phone OPPO has a very big UE capability (> 2KB).

We need bigger buffers to transfer this, especially in x2 handover.

Also the sctp messages need a bigger buffer.

Note: in sctp, we didn't check for partial messages, it's now
      done. When detected, we exit. To be redone differently
      if needed. (Look for "if (!(flags & MSG_EOR))".)
2019-07-11 16:34:28 +02:00
Cedric Roux 8a8fdd59c2 cleanup: no variable definition in header file
We declare variables in header files, we don't define them. So we need
to use 'extern' in the header file and put the definition
in some C file.
2019-07-11 15:28:33 +02:00
Raphael Defosseux a03ef2bfc3 Merge remote-tracking branch 'origin/hotfix-measurement-report' into develop_integration_2019_w27 2019-07-05 11:24:24 +02:00
Cedric Roux e0eac2e331 hotfix: do not set s-Measure in measurement report configuration
The value was set to 20 which means -120 dB. Setting this value means
that the UE reports an event only if the RSRP of the serving cell
is lower than -120 dB.

In the lab, we get values of around -70, and to go as low as -120
means a very degraded environment. This is not practical.

Let's disactivate the setting of this parameter for the moment so that
the UE reports an event without taking into consideration the RSRP
of the serving cell.

With this hotfix, the X2 handover works much better.
2019-07-04 14:47:11 +02:00
Raphael Defosseux 6e1cac6e8b Merge remote-tracking branch 'origin/flexran_agent_rrc_cm_rebased2' into develop_integration_2019_w27 2019-07-04 12:53:08 +02:00
laurent 924e10f73a fix rfsim ue initial sync and legacy OAI C struct syntax 2019-07-01 15:17:07 +02:00
Robert Schmidt 5b12a60950 Flexran-triggered RRC Reconf: free memory of mac_MainConfig after setting new, do not free new memory 2019-06-25 15:47:52 +02:00
Robert Schmidt f1a1ff036d FlexRAN: HO request first check whether X2 is active, minor indentation fixes 2019-06-24 17:55:13 +02:00
Robert Schmidt a6be54a6f4 Fix: X2 Setup Req/Resp: first check, then increase number of cells 2019-06-24 17:54:38 +02:00
Robert Schmidt a90a7f352e Additional messages for error diagnosis for net-ctrld HO 2019-06-24 16:29:14 +02:00
Konstantinos Alexandris 75e3622daf Configure eNB for X2 handover controlled by network (ignore UE HO request) 2019-06-24 16:29:14 +02:00
Konstantinos Alexandris 8957cfef78 Add HO trigger function via FlexRAN controller (OAI + FlexRAN handler) 2019-06-24 16:29:14 +02:00
Robert Schmidt 939251e004 Fix: Memory allocation for offsetFreq parameter 2019-06-24 16:29:14 +02:00
Konstantinos Alexandris 1b90c4a02d Create RRC setters for Periodic, A1-A5 event and offsets related to RRC Measurement Report 2019-06-24 16:28:16 +02:00
Konstantinos Alexandris 1de4b7400b Fix: flexran agent for HO case, to be tested if Nb_ue in RRC is needed 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris f5e928afab Fix: condition on CellsToAddModList memory allocation in case of zero neighbouring cells 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 772dc508e8 Fix: Segfault error, free properly measurement info struct, add rsrp/rsrq filter coefficient 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris b7530528e0 To be tested: Add code for measurement report based on the neighbouring cells after x2 setup, ocs/ocn for multiple cells 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 5dfec71629 Fill in the RRC Measurement info struct in the RRC layer 2019-06-24 16:15:44 +02:00
Konstantinos Alexandris 0eeee616d8 Create RRC struct and getters for Periodic, A1-A5 event and offsets related to RRC Measurement Report 2019-06-24 16:15:44 +02:00
Raphael Defosseux 8931915030 Merge remote-tracking branch 'origin/434-coverity-scan-fix-week25' into develop_integration_2019_w25 2019-06-21 13:04:51 +02:00
Raphael Defosseux 18b8bd4ee9 Merge remote-tracking branch 'origin/bugfix-rrc-ue-removal' into develop_integration_2019_w25 2019-06-21 13:03:39 +02:00
Cedric Roux f6f83ca01b bugfix: fix RRC UE removal
If several UEs are removed, the variable ue_to_be_removed may be overwritten.
Let's use an array instead.
2019-06-20 17:20:20 +02:00
Dong Anyuan 2f2f21d2aa Fix Coverity Scan CID 339964 (Passing &rrc_eNB_mui to function rrc_eNB_process_S1AP_DOWNLINK_NAS which uses it as an array. This might corrupt or misinterpret adjacent memory locations.) 2019-06-20 14:06:04 +09:00
Dong Anyuan f1fdff80a0 Fix Coverity Scan CID 340235 (Using variable UE_id_mac as an index to array RC.mac[ctxt_pP->module_id]->UE_list.UE_sched_ctrl.) 2019-06-20 13:59:53 +09:00
Dong Anyuan 6087373184 Fix Coverity Scan CID 340245 (Variable Sparams going out of scope leaks the storage it points to.) 2019-06-20 13:58:08 +09:00
Dong Anyuan b40385aa09 Fix Coverity Scan CID 340261 (Variable securityConfigHO going out of scope leaks the storage it points to.) 2019-06-20 13:57:04 +09:00
Dong Anyuan 3354bd5122 Fix Coverity Scan CID 340278 (Variable quantityConfig going out of scope leaks the storage it points to.) 2019-06-20 13:54:55 +09:00
Dong Anyuan cd31745af1 Fix Coverity Scan CID 340290 (Variable msg_p going out of scope leaks the storage it points to.) 2019-06-20 13:53:08 +09:00
Dong Anyuan 2a8ed1a056 Fix Coverity Scan CID 21666 (Variable measResultListEUTRA2 going out of scope leaks the storage it points to.) 2019-06-20 12:43:44 +09:00
Dong Anyuan dc8b2c1ef0 Fix Coverity Scan CID 21694 (Variable quantityConfig going out of scope leaks the storage it points to.) 2019-06-20 12:43:17 +09:00
Dong Anyuan 87023eeb6a Fix Coverity Scan CID 21734 (Variable Sparams going out of scope leaks the storage it points to.) 2019-06-20 12:42:42 +09:00
Dong Anyuan 76fbb7c0b1 Fix Coverity Scan CID 60430 (Using uninitialized value meas2. Field meas2.ext1 is uninitialized.) 2019-06-20 12:32:07 +09:00
Dong Anyuan 39e3769e9a Fix Coverity Scan CID 261570 (Overwriting DRB_config in DRB_config = calloc(1UL, 96UL) leaks the storage that DRB_config points to.) 2019-06-20 11:12:44 +09:00
Dong Anyuan 91dcaae357 Fix Coverity Scan CID 261623 (Variable msg_p going out of scope leaks the storage it points to.) 2019-06-20 11:11:41 +09:00
Dong Anyuan 0d7fa51405 Fix Coverity Scan CID 261633 (Overrunning array reestablish_rnti_map of 16 4-byte elements at element index 16 (byte offset 64) using index i (which evaluates to 16).) 2019-06-20 11:09:57 +09:00
Dong Anyuan 0e23059320 Fix Coverity Scan CID 261663 (Overrunning array reestablish_rnti_map of 16 4-byte elements at element index 16 (byte offset 64) using index i (which evaluates to 16).) 2019-06-20 11:05:52 +09:00
Dong Anyuan fdb47bed67 Fix Coverity Scan CID 300383 (Variable sl_CommConfig going out of scope leaks the storage it points to.) 2019-06-20 10:59:59 +09:00
Dong Anyuan 42e3a1394d Fix Coverity Scan CID 300388 (Variable destinationInfoList going out of scope leaks the storage it points to.) 2019-06-20 10:55:36 +09:00
Javier Morgade 8b4c23cf80 Merge remote-tracking branch 'origin/develop' into develop-entv 2019-06-10 15:21:51 +02:00
Dong Anyuan 04732d3a8b Fix Coverity Scan CID 341064 (Null-checking mac_MainConfig->phr_Config suggests that it may be null, but it has already been dereferenced on all paths leading to the check.) 2019-05-31 10:29:42 +09:00
Dong Anyuan 507c9cd2a4 Fix Coverity Scan CID 341071 (Null-checking mac_MainConfig->ul_SCH_Config suggests that it may be null, but it has already been dereferenced on all paths leading to the check.) 2019-05-31 10:27:17 +09:00
Dong Anyuan 3dae026c09 Fix Coverity Scan CID 341067 (Null-checking mac_MainConfig suggests that it may be null, but it has already been dereferenced on all paths leading to the check.) 2019-05-31 10:23:58 +09:00
Dong Anyuan 1de860bc89 Fix Coverity Scan CID 341070 (Null-checking quantityConfig->quantityConfigEUTRA suggests that it may be null, but it has already been dereferenced on all paths leading to the check.) 2019-05-31 10:13:11 +09:00
Dong Anyuan b19f9d9c6e Fix Coverity Scan CID 341065 (Null-checking quantityConfig suggests that it may be null, but it has already been dereferenced on all paths leading to the check.) 2019-05-31 10:04:11 +09:00
Dong Anyuan 2d3d0f7ae7 Fix Coverity Scan CID 300396 (Variable mac_MainConfig going out of scope leaks the storage it points to.) 2019-05-28 22:21:04 +09:00
Dong Anyuan 3cbb53e069 Fix Coverity Scan CID 300429 (Overrunning array buffer of 255 bytes by passing it to a function which accesses it at byte offset 65534 using argument size (which evaluates to 65535).) 2019-05-28 21:40:35 +09:00
Dong Anyuan 0b328f3315 Fix Coverity Scan CID 300448 (Using uninitialized value sl_DiscConfig. Field sl_DiscConfig.ext1 is uninitialized.) 2019-05-28 21:34:20 +09:00