Commit Graph
41 Commits
Author SHA1 Message Date
Robert Schmidt f3c2c12fa2 Fix alignment of Tpool user data to 32 bytes
The thread pool provides user data to be stored by (pre-)allocating the
necessary memory. A previous attempt was made to have this user data
aligned on a 32 byte boundary (e.g., to prevent segfault with SIMD
instructions, or avoid inefficient data access); the current
implementation, however, leads to unaligned memory access.

This patch attempts again to implement user data to be 32 byte aligned.
First, use memalign() to allocate the actual job on a 32 byte boundary.
Second, use alignas(32) to align the pointer to the user data to be
aligned to 32 bytes. Since it is the last member of the struct, this
ensures that user data, which is allocated right behind it, will be
aligned to 32 bytes as well.
2023-08-11 14:38:28 +02:00
Laurent THOMAS 3645c96c09 remove generic thread pool abort 2023-06-12 10:24:37 +02:00
Sakthivel Velumani f3be849904 Delete job data when no response FIFO 2023-04-03 10:24:26 -04:00
Robert Schmidt 8198272571 Review remarks 2023-03-09 19:10:59 +01:00
Robert Schmidt c9b043eb09 Fix: Correct check thread pool initialized
traceFd of thread pool can be:
* -1: no tracing
* valid file descriptor/>0: tracing
2023-03-09 19:01:47 +01:00
Robert Schmidt f8d0c3de03 Minor fixes 2023-03-09 19:01:47 +01:00
francescomani 4065e7b4b7 adding thread pool patch 2023-03-09 19:01:47 +01:00
Robert Schmidt c8060da227 Tpool: Unlock after broadcast in abortNotifiedFIFO() 2022-11-25 16:53:53 +01:00
Robert Schmidt bfcf115298 Tpool: use condbroadcast() in case multiple waits on the same signal 2022-11-21 13:47:41 +01:00
laurent aa2a36768c simplify thread pool configuration
fix segv

fix bug redeclaration of same struct in phy sim

Apply 1 suggestion(s) to 1 file(s)

code reveiw comments
2022-09-02 11:36:47 +02:00
Robert Schmidt fafed7d181 Remove unused restrictRNTI variable in Tpool 2022-08-16 14:41:02 +02:00
Robert Schmidt 31dcdf2152 Implement abortNotifiedFIFO() to unlock FIFO waits 2022-08-16 14:41:02 +02:00
Robert Schmidt dfd9a91b50 Rename abortNotifiedFIFO() to abortNotifiedFIFOJob() 2022-08-16 14:41:02 +02:00
Robert Schmidt 178e2773ed Handle abortFIFO in FIFO functions 2022-08-16 14:41:02 +02:00
Robert Schmidt e63cc03c9d Implement abortTpool()
This stops all ongoing threads (using pthread_join()), and marks FIFOs
to not block anymore. In this case, returned messages will be NULL.
2022-08-16 14:41:02 +02:00
Robert Schmidt 31d5bb6ffd Rename abortTpool() to abortTpoolJob(), fix doc 2022-08-16 14:41:01 +02:00
Thomas Schlichter 6569ea1a20 fix use of uninitialized memory
found by valdgrind in nr_dlsim
2022-03-14 16:39:17 +01:00
Robert Schmidt 98a684d157 Tpool: no measurements (no trials) if not measured 2022-03-01 08:57:32 +01:00
Robert Schmidt 63dea20c64 Address review comments 2022-02-28 14:35:18 +01:00
Robert Schmidt 26d0d65747 get execution time_stats_t from Tpool job 2022-02-25 17:55:27 +01:00
Robert Schmidt 211b6feadf Use (portable) rdtsc_oai() in tpool 2022-02-25 17:55:27 +01:00
Robert Schmidt d20ff45fc6 Remove logging module dependency from Tpool 2022-02-25 17:22:02 +01:00
Robert Schmidt b742717fb8 Remove timing functions from logging module 2022-02-25 17:22:01 +01:00
Laurent THOMAS 792b6b4e0b merge develop 2021-12-23 22:52:36 +01:00
Raymond Knopp 07d735f93c step-by-step merging from tx-proc-optim-lts. Everything except NR_TRANSPORT merged. Some issues with 64QAM modulation 2021-11-11 08:28:10 +01:00
Laurent THOMAS 686e585666 replace protobuf in 4G F1 split, first step: UL packets 2021-09-21 10:30:46 +02:00
hardy c4745c3e46 Merge remote-tracking branch 'origin/new-gtpu' into integration_2020_wk15
Conflicts:
	cmake_targets/CMakeLists.txt
	openair1/PHY/TOOLS/time_meas.h
	openair2/LAYER2/PDCP_v10.1.0/pdcp_fifo.c
	openair2/LAYER2/RLC/rlc.h
2021-04-14 14:56:04 +02:00
Laurent THOMAS 86f1c69f26 Fix code review remarks, merge develop, revert some merge errors 2021-04-13 22:28:02 +02:00
Laurent Thomas abfa103247 fix re-reading and end marker code 2021-02-15 10:54:35 +01:00
frtabu 6ec065fe2a add tpool thread name parameter, review fixes 2021-01-08 18:19:29 +01:00
frtabu 58309dd730 simplify nrue command line parameter processing 2020-12-23 18:43:03 +01:00
frtabu 4338d5365b cancel thread pool modif 2020-12-07 23:46:14 +01:00
Raymond Knopp d9b7d43ec6 rebase and fix non paralellized errors 2020-12-01 18:26:07 +01:00
laurent 9ac5f6015d update license text 2020-04-29 11:31:00 +02:00
laurent 255d32389c real time ok in monolithic cases, phy test tools fixed 2020-02-06 11:01:54 +01:00
laurent ea7c4d9536 fix fix-nr-rfsim-gNB-notx-slots2to19 2019-11-12 14:35:43 +01:00
laurent 290ca22dbb fix rfsimulator initialized variable, first pass on gNB scope, bugs 2019-05-17 15:21:27 +02:00
laurent 8a92138086 rework threads in 5G 2019-04-30 10:17:08 +02:00
laurent 2e6d9d7d4a Remove table of thread_id in the main UE thread 2019-04-11 13:44:08 +02:00
laurent 48a103ea82 fixes 2019-04-03 22:12:10 +02:00
laurent d9c68d8b30 new thread model 2019-03-21 14:15:26 +01:00