Robert Schmidt
f7181caf65
Remove commented code
2023-04-11 10:07:07 +02:00
Angelo Athanassopoulos
1679cf38ba
NR RRC - RRCReestablishment - Reviewer comments
...
Changes
1. Passing function argument by reference.
2. Use a pointer for ue->established_drbs[drb_id - 1] in generateDRB.
2023-04-05 22:40:55 +02:00
Angelo Athanassopoulos
5b35523c2c
NR RRC - RRCReestablishment - Apply clang format
2023-04-05 11:22:59 +02:00
luis_pereira87
3cf3a42b44
Flag integrityProtection work in inverse logic state, '0' means enabled which is the default the value, we need to set it to '1' to disable it
2023-04-04 18:25:08 +01:00
luis_pereira87
6fb10cd5fa
Fix SRB_configList2 and DRB_configList2 array position (new_xid) while creating RRCReconfiguration message after RRCReestablishmentComplete
2023-04-04 18:13:11 +01:00
Angelo Athanassopoulos
f4dc362247
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Fixed a bug where the integrity protection was included in the ASN1 and caused significant throughput bottleneck.
2023-04-04 14:05:06 +02:00
Angelo Athanassopoulos
778c88d8a9
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Cosmetic changes, also changed the LOG message for updating the UEid, and moved the drb_id_to_setup_start and nb_drb_to_setup right before the function that they are used
2023-04-04 14:05:06 +02:00
Angelo Athanassopoulos
ad598a2d5d
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Removed the unused variables, and changed the tenary operator conditions of drb_id_to_setup_start & nb_drb_to_setup, to the correct ones
2023-04-04 14:05:05 +02:00
Angelo Athanassopoulos
ca010654bf
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Changed the SRB2 and DRB at the do_RRCReconfiguration arguments, to pass the correct structures that are generated
2023-04-04 14:05:05 +02:00
Angelo Athanassopoulos
1923bed4a3
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Simplify RRCReestablishmentComplete procedure with respective function,
removed the block that creates the SRB2 and created a function, with doxygen
2023-04-04 14:05:05 +02:00
Angelo Athanassopoulos
9142357069
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Simplify RRCReestablishmentComplete procedure with respective function,
removed the block that creates the ASN1 DRBs and created a function, with doxygen
2023-04-04 14:05:04 +02:00
Angelo Athanassopoulos
a3c13fdc71
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Simplify RRCReestablishmentComplete procedure with respective function,
removed the block that updates NGU Tunnels and created a function, with doxygen
2023-04-04 14:05:04 +02:00
Angelo Athanassopoulos
bf844247bf
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Simplify RRCReestablishmentComplete procedure with respective function,
removed the block that updates NAS PDUSession and created a function, with doxygen
2023-04-04 14:05:04 +02:00
Angelo Athanassopoulos
7eb2e99dcd
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Simplify RRCReestablishmentComplete procedure with respective function,
removed the block that frees all the NAS PDUs and created a function for this.
2023-04-04 14:05:03 +02:00
Angelo Athanassopoulos
26909e7c32
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Cosmetic changes, added doxygen configuration, and changed the rrc_gNB_process_RRCReestablishmentComplete function arguments' alignment, so in the future if an argument is removed or added to be better visible in the commits
2023-04-04 14:05:03 +02:00
Angelo Athanassopoulos
33c09b7776
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
The generateDRB function now creates a DRB and puts it in the struct member of gNB_RRC_UE_t, from this struct we can generate ASN1 messages by calling the generateDRB_ASN1
2023-04-04 00:44:43 +02:00
Angelo Athanassopoulos
af8b3b0486
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Added function to create ASN1 DRB-ToAddMod structs from, gNB_RRC_UE_t established_drbs
2023-04-04 00:44:38 +02:00
Angelo Athanassopoulos
5403198996
NR RRC - RRCReestablishment - Fix MultiplePDU Regression
...
Added struct member to gNB_RRC_UE_t to store the established DRBs for a UE, this can be used to generate ASN1 structs, during RRCReconfiguration
2023-04-04 00:18:44 +02:00
Robert Schmidt
51fe9b84dd
Merge remote-tracking branch 'origin/pdcp-callbacks-simplify' into integration_2023_w13
2023-03-31 18:03:40 +02:00
Robert Schmidt
c4a9f0ea03
gNB RRC: Shorten time till UE is removed for RRCRelease
2023-03-31 17:23:03 +02:00
Robert Schmidt
d1fc95a8a1
GTP: when creating a tunnel, tell which functions to use
...
The GTP module is common for 4G and 5G. It hardcodes the functions to
call when creating S1U and NGU tunnels. The S1U case is both applicable
for LTE and NR (NSA), which until now was not a problem as the PDCP data
forwarding functions where called pdcp_data_req. The issue is that in this
branch, the NR PDCP functions have changed to nr_pdcp_data_req_drb().
When setting up a GTP tunnel, we now pass the PDCP data forwarding
functions into GTP, since the caller knows whether it is in 4G or 5G,
but GTP itself does not.
2023-03-31 11:53:52 +02:00
Robert Schmidt
6529d875d8
nr_pdcp_data_req_srb(): take callback to forward data
2023-03-27 16:47:46 +02:00
Robert Schmidt
c405ad16a8
Remove nr_rrc_data_req()/rrc_data_req_nr_ue()
2023-03-27 16:47:46 +02:00
Robert Schmidt
2ac2a7f074
Make separate header for nr_pdcp instead of using 4G pdcp
...
Creates function that have nr_pdcp_ prepended to their name, and change
the signature of some functions for the 5G PDCP:
- nr_pdcp_layer_init()
- nr_pdcp_data_req()
- nr_pdcp_remove_UE()
- nr_pdcp_config_set_security()
- nr_pdcp_remove_UE()
- Make separate functions for nr_pdcp_data_req_srb/drb()
2023-03-27 16:39:24 +02:00
Robert Schmidt
8fd0ad58b2
Merge remote-tracking branch 'origin/NR_harmonize_mac_cellgroup' into integration_2023_w12
2023-03-24 11:56:41 +01:00
Robert Schmidt
9eac725441
Merge remote-tracking branch 'origin/simplify-f1-rrc-msg-transfer' into integration_2023_w12
2023-03-24 11:56:30 +01:00
Robert Schmidt
5b8674cc57
Remove any reference to NR_SRB_INFO in gNB RRC
2023-03-23 10:30:49 +01:00
Robert Schmidt
b5acd48e5b
Remove unused rrc_rlc_register_rrc()
2023-03-22 19:21:06 +01:00
Robert Schmidt
acf73ac23f
Delete misleading comment
2023-03-22 19:03:51 +01:00
Robert Schmidt
b3791364fd
Review: correct indentation
2023-03-22 19:03:42 +01:00
francescomani
508b67e5e5
limiting SR periodicity according to scs
2023-03-21 13:52:03 +01:00
francescomani
90bfdfcaf3
harmonize mac_CellGroupConfig
2023-03-20 17:18:02 +01:00
Robert Schmidt
7b40520a2d
Do not handle NR_RRC_DL_INDICATION message at NR RRC
...
The message is never sent to the RRC. And this message is to be
forwarded by the DU to the UE, hence it should not even be handled by
the RRC (as the RRC in the CU sends it).
2023-03-20 16:57:58 +01:00
Robert Schmidt
c4c41d3b69
Simplify nr_rlc: provide functions to add SRB/DRB
2023-03-20 16:57:58 +01:00
Robert Schmidt
0ed9201169
Remove useless node_type switches in RRC
2023-03-20 16:57:55 +01:00
luis_pereira87
3514cb43ba
Minor fixes to get NR_RRCReestablishment working again after merging on the integration branch
2023-03-20 09:23:05 +00:00
Robert Schmidt
6fdb44953b
Merge remote-tracking branch 'origin/nr_rrc_asn1_1730' into integration_2023_w11b
2023-03-18 11:53:18 +01:00
Robert Schmidt
9dc3f4f61f
Merge remote-tracking branch 'origin/rework-ngap' into integration_2023_w11b
2023-03-18 11:43:53 +01:00
laurent
563421b4dc
merge develop
2023-03-15 11:33:46 +01:00
Thomas Schlichter
6cee30ba79
review comments and further transform precoding cleanup
2023-03-15 11:01:47 +01:00
francescomani
8131f63504
setting transform precoding in pusch-config
2023-03-15 10:57:51 +01:00
francescomani
7db8dce51c
fixes for allowing softmodem to schedule PUSCH with transform precoding
2023-03-15 10:54:03 +01:00
Robert Schmidt
36f374be2a
Merge remote-tracking branch 'origin/remove-unused-stuff' into integration_2022_wk11
2023-03-14 17:46:45 +01:00
Robert Schmidt
32f9d95bba
Merge remote-tracking branch 'origin/telnet-ci' into integration_2022_wk11
2023-03-14 15:24:33 +01:00
laurent
03d3e1a5db
code review comments
2023-03-14 14:48:09 +01:00
Robert Schmidt
9288930a3b
Merge remote-tracking branch 'origin/Fix_RRCReestablishment_regression' into telnet-ci
2023-03-13 19:46:22 +01:00
Robert Schmidt
3efb55ad17
Merge remote-tracking branch 'origin/Fix_RRCReestablishment_regression' into integration_2022_wk11
2023-03-13 19:25:17 +01:00
Robert Schmidt
4352c8314c
Merge remote-tracking branch 'origin/t-reordering-gt-0' into integration_2022_wk11
2023-03-13 19:24:51 +01:00
laurent
082ba963d3
error free
2023-03-13 15:48:19 +01:00
laurent
474f662337
merge develop
2023-03-13 12:45:32 +01:00