netlink_init.c: Memory leak

Found by `-fsanitize=address`.

openair1/SIMULATION/ETH_TRANSPORT/netlink_init.c

@@ -133,6 +133,7 @@ int netlink_init_mbms_tun(char *ifprefix, int id) {//for UE, id = 1, 2, ...,
     nas_dest_addr.nl_pid = 0;   /* For Linux Kernel */
     nas_dest_addr.nl_groups = 0; /* unicast */
     // TX PART
+    free(nas_nlh_tx);
     nas_nlh_tx=(struct nlmsghdr *)malloc(NLMSG_SPACE(NL_MAX_PAYLOAD));
     memset(nas_nlh_tx, 0, NLMSG_SPACE(NL_MAX_PAYLOAD));
     /* Fill the netlink message header */
@@ -193,6 +194,7 @@ int netlink_init_tun(char *ifprefix, int num_if, int id) {//for UE, id = 1, 2, .
     nas_dest_addr.nl_pid = 0;   /* For Linux Kernel */
     nas_dest_addr.nl_groups = 0; /* unicast */
     // TX PART
+    free(nas_nlh_tx);
     nas_nlh_tx=(struct nlmsghdr *)malloc(NLMSG_SPACE(NL_MAX_PAYLOAD));
     memset(nas_nlh_tx, 0, NLMSG_SPACE(NL_MAX_PAYLOAD));
     /* Fill the netlink message header */
@@ -251,6 +253,7 @@ int netlink_init(void) {
   nas_dest_addr.nl_pid = 0;   /* For Linux Kernel */
   nas_dest_addr.nl_groups = 0; /* unicast */
   // TX PART
+  free(nas_nlh_tx);
   nas_nlh_tx=(struct nlmsghdr *)malloc(NLMSG_SPACE(NL_MAX_PAYLOAD));
   memset(nas_nlh_tx, 0, NLMSG_SPACE(NL_MAX_PAYLOAD));
   /* Fill the netlink message header */
@@ -273,3 +276,8 @@ int netlink_init(void) {
   return(nas_sock_fd[0]);
 }
 
+void netlink_cleanup(void)
+{
+  free(nas_nlh_tx);
+  nas_nlh_tx = NULL;
+}

openair1/SIMULATION/ETH_TRANSPORT/proto.h

@@ -64,5 +64,6 @@ void clear_UE_transport_info(uint8_t);
 int netlink_init(void);
 int netlink_init_tun(char *ifsuffix, int num_if, int id);
 int netlink_init_mbms_tun(char *ifsuffix, int id);
+void netlink_cleanup(void);
 
 #endif /* EMU_PROTO_H_ */

openair2/LAYER2/PDCP_v10.1.0/pdcp.c

@@ -2331,6 +2331,7 @@ pdcp_free (
 void pdcp_module_cleanup (void)
 //-----------------------------------------------------------------------------
 {
+  netlink_cleanup();
 }
 
 //-----------------------------------------------------------------------------

targets/RT/USER/lte-softmodem.c

@@ -803,6 +803,7 @@ int main ( int argc, char **argv )
     }
   }
 
+  pdcp_module_cleanup();
   terminate_opt();
   logClean();
   printf("Bye.\n");

targets/RT/USER/lte-uesoftmodem.c

@@ -834,6 +834,7 @@ int main( int argc, char **argv ) {
   if (PHY_vars_UE_g[0][0]->rfdevice.trx_end_func)
     PHY_vars_UE_g[0][0]->rfdevice.trx_end_func(&PHY_vars_UE_g[0][0]->rfdevice);
 
+  pdcp_module_cleanup();
   terminate_opt();
   logClean();
   printf("Bye.\n");