T: validate input data a bit more

When data is generated by "normal" T tracers, it should be fine.
But it might come from unknown sources and then content might be
"strange". So let's validate input data a bit more.

common/utils/T/tracer/event.c

@@ -24,9 +24,11 @@ event get_event(int socket, OBUF *event_buffer, void *database)
 again:
   if (fullread(socket, &length, 4) == -1) goto read_error;
 #ifdef T_SEND_TIME
+  if (length < sizeof(struct timespec)) goto error;
   if (fullread(socket, &t, sizeof(struct timespec)) == -1) goto read_error;
   length -= sizeof(struct timespec);
 #endif
+  if (length < sizeof(int)) goto error;
   if (fullread(socket, &type, sizeof(int)) == -1) goto read_error;
   length -= sizeof(int);
   if (event_buffer->omaxsize < length) {
@@ -48,6 +50,9 @@ again:
   return new_event(type, length, event_buffer->obuf, database);
 #endif
 
+error:
+  printf("error: bad data in get_event()\n");
+
 read_error:
   return (event){.type = -1};
 }
@@ -64,6 +69,9 @@ event new_event(int type, int length, char *buffer, void *database)
   int i;
   int offset;
 
+  /* arbitrary limit to 1GiB (to simplify size checks) */
+  if (length < 0 || length > 1024 * 1024 * 1024) goto fatal;
+
 #ifdef T_SEND_TIME
   e.sending_time = sending_time;
 #endif
@@ -87,26 +95,33 @@ event new_event(int type, int length, char *buffer, void *database)
   for (i = 0; i < f.count; i++) {
     //e.e[i].offset = offset;
     if (!strcmp(f.type[i], "int")) {
+      if (offset + 4 > length) goto fatal;
       e.e[i].type = EVENT_INT;
       e.e[i].i = *(int *)(&buffer[offset]);
       offset += 4;
     } else if (!strcmp(f.type[i], "ulong")) {
+      if (offset + sizeof(unsigned long) > length) goto fatal;
       e.e[i].type = EVENT_ULONG;
       e.e[i].ul = *(unsigned long *)(&buffer[offset]);
       offset += sizeof(unsigned long);
     } else if (!strcmp(f.type[i], "float")) {
+      if (offset + sizeof(float) > length) goto fatal;
       e.e[i].type = EVENT_FLOAT;
       e.e[i].f = *(float *)(&buffer[offset]);
       offset += sizeof(float);
     } else if (!strcmp(f.type[i], "string")) {
+      if (offset + 1 > length) goto fatal;
       e.e[i].type = EVENT_STRING;
       e.e[i].s = &buffer[offset];
-      while (buffer[offset]) offset++;
+      while (offset < length && buffer[offset]) offset++;
+      if (offset == length) goto fatal;
       offset++;
     } else if (!strcmp(f.type[i], "buffer")) {
+      if (offset + sizeof(int) > length) goto fatal;
       int len;
       e.e[i].type = EVENT_BUFFER;
       len = *(int *)(&buffer[offset]);
+      if (len <= 0 || offset + len + sizeof(int) > length) goto fatal;
       e.e[i].bsize = len;
       e.e[i].b = &buffer[offset+sizeof(int)];
       offset += len+sizeof(int);
@@ -119,4 +134,8 @@ event new_event(int type, int length, char *buffer, void *database)
   if (e.ecount==0) { printf("FORMAT not set in event %d\n", type); abort(); }
 
   return e;
+
+fatal:
+  printf("fatal: bad buffer in new_event\n");
+  abort();
 }

common/utils/T/tracer/multi.c

@@ -123,10 +123,12 @@ int read_tracee(int s, OBUF *ebuf, int *_type, int32_t *_length)
   memcpy(v+vpos, &length, 4);
   vpos += 4;
 #ifdef T_SEND_TIME
+  if (length < sizeof(struct timespec)) return -1;
   if (fullread(s,v+vpos,sizeof(struct timespec))==-1) return -1;
   vpos += sizeof(struct timespec);
   length -= sizeof(struct timespec);
 #endif
+  if (length < sizeof(int)) return -1;
   if (fullread(s, &type, sizeof(int)) == -1) return -1;
   memcpy(v+vpos, &type, sizeof(int));
   vpos += sizeof(int);

common/utils/T/tracer/record.c

@@ -142,10 +142,12 @@ int main(int n, char **v)
     memcpy(v+vpos, &length, 4);
     vpos += 4;
 #ifdef T_SEND_TIME
+    if (length < sizeof(struct timespec)) goto read_error;
     if (fullread(socket,v+vpos,sizeof(struct timespec))==-1) goto read_error;
     vpos += sizeof(struct timespec);
     length -= sizeof(struct timespec);
 #endif
+    if (length < sizeof(int)) goto read_error;
     if (fullread(socket, &type, sizeof(int)) == -1) goto read_error;
     memcpy(v+vpos, &type, sizeof(int));
     vpos += sizeof(int);