maki/openairinterface5g
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,625 Commits 5 Branches 0 Tags
e3782b5ca2f02569bdfdedc5dd5e4a598495fa11
Commit Graph
8625 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Cedric Roux e3782b5ca2 bugfix: fix PDCP sequence management (plus some cleanup) 
With the introduction of X2AP into develop, the UEs now have to regularly
send measurement reports.

In the logs of the eNB, we see:

[OSA]   Mismatch found in integrity for algorithm 2,
        got e0.a0.c2.66, expecting a5.9c.cb.57
[PDCP]   [OSA][RB 1] eNB failed to validate MAC-I of incoming PDU

This is a bug in the PDCP layer that uses wrong parameters to compute the
integrity.

This commit fixes this bug.

The function pdcp_is_rx_seq_number_valid was removed. Its processing
has been directly integrated into the function pdcp_data_ind.

The function pdcp_mark_current_pdu_as_received is not called anymore.
Its processing was not used later on, so as of today, not calling it does
not introduce any functional change.

The function pdcp_validate_security takes now as parameters both
SN and HFN. Same for the function pdcp_get_next_count_rx.

Useless constants PDCP_SN_5BIT, PDCP_SN_7BIT and PDCP_SN_12BIT have been
removed.

The compilation option ENABLE_SECURITY has been removed. It's now always
on. (This may impact some use cases.)

The PDCP for DRB using RLC AM is not correct. It was not correct before
this commit (apart from the integrity bug). We should deal with a list
of PDUs and transmit packets to upper layers as detailed in the specs.
Today we transmit the PDU as soon as we get it. We don't care about
duplicates, in-order delivery, timeouts.

Also, we don't deal with "PDCP re-establishment". Not sure how that impacts
the software.

And, last but not least, there is still no ROHC.
 2019-02-27 12:33:04 +01:00
Raphael Defosseux f6cab340e1 Merge branch 'develop_integration_2019_w08' into 'develop' 
Develop integration 2019 week 08

See merge request oai/openairinterface5g!517
 2019-02-22 23:24:19 +01:00
Raphael Defosseux 929d71d06d Merge remote-tracking branch 'origin/uhd_3131_fix' into develop_integration_2019_w08 2019-02-22 12:14:12 +01:00
Raphael Defosseux c1308c61a8 Merge remote-tracking branch 'origin/second_pass_on_cppcheck' into develop_integration_2019_w08 2019-02-22 12:14:06 +01:00
Raphael Defosseux 7caea35158 Merge remote-tracking branch 'origin/393-dlsch-scheduler-optimization' into develop_integration_2019_w08 2019-02-22 12:14:00 +01:00
Raphael Defosseux 8fc1a61e6a Putting correct license banner on file 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-22 12:10:15 +01:00
Raphael Defosseux fd5238e478 Updated release notes 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-22 11:44:42 +01:00
Florian Kaltenberger 7fd089fe3f putting back uhd transport args for b200 with a reduced frame size. This is still compatible with uhd 3.13.1 and above. 2019-02-21 13:36:38 +01:00
Raphael Defosseux 92076ea8a8 CI: adding much needed lock mechanism when creating VM. 
-- should prevent VM-creation crashes during test stages

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
(cherry picked from commit eeffdfa200)
 2019-02-20 22:28:39 +01:00
Raphael Defosseux eeffdfa200 CI: adding much needed lock mechanism when creating VM. 
-- should prevent VM-creation crashes during test stages

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-20 18:13:43 +01:00
matzakos c1364f0117 changes to make oai work with UHD 3.13.1 2019-02-20 16:45:39 +01:00
Raphael Defosseux 9286b58fb6 CI: adding commit message to HTML slave reports 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-20 15:49:07 +01:00
Raphael Defosseux a82342298e changed back some cppcheck "fixes" and updated the cppcheck suppression list 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-20 14:42:17 +01:00
Raphael Defosseux f4bf32d7e7 Forgot one file 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-19 21:34:06 +01:00
Raphael Defosseux 9aab83c509 Fixing a few last cppcheck errors/warnings 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-19 17:42:27 +01:00
Louis Adrien Dufrene db51a61c2e Fix to remove cppcheck warnings 2019-02-19 07:56:32 +01:00
Louis Adrien Dufrene 0f52ce5031 remove previous X2AP fix after update of asn files 2019-02-18 15:36:02 +01:00
Louis Adrien Dufrene f8ab4080f7 Merge from develop + modification of a X2AP file for code to compile 2019-02-18 10:46:13 +01:00
Raphael Defosseux 6a47f9e775 Merge branch 'develop_integration_2019_w07_v2' into 'develop' 
Develop integration 2019 week 07 v2

See merge request oai/openairinterface5g!508
 2019-02-17 21:53:55 +01:00
Raphael Defosseux d14ad6797e Applying the cppcheck fix on last files 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 19:18:24 +01:00
Raphael Defosseux db51efa887 CI: comment message is now in HTML reports 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 15:44:15 +01:00
Raphael Defosseux 341fedd468 Merge branch 'issue394_fix_cppcheck' into develop_integration_2019_w07_v2 
--> openair2/LAYER2/MAC/eNB_scheduler_primitives.c is still old (not from issue394_fix_cppcheck branch)

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 12:24:19 +01:00
Raphael Defosseux 66f654cd0a CI: astyle trying to help merge 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 11:52:25 +01:00
Raphael Defosseux 9b143e9a69 CI: astyle to help merge 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 11:51:10 +01:00
Raphael Defosseux ee3b650904 Compilation fix 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 10:40:06 +01:00
Raphael Defosseux 869e0271d3 Merge remote-tracking branch 'origin/master' into develop_integration_2019_w07_v2 2019-02-15 09:55:55 +01:00
Raphael Defosseux 21aec74478 Merge remote-tracking branch 'origin/rhel76-support' into develop_integration_2019_w07_v2 2019-02-15 09:55:40 +01:00
Raphael Defosseux e4560d8ae4 Merge remote-tracking branch 'origin/issue397_telnet_stats' into develop_integration_2019_w07_v2 2019-02-15 09:55:17 +01:00
Raphael Defosseux 4cdae9d93d Merge remote-tracking branch 'origin/x2' into develop_integration_2019_w07_v2 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 09:54:44 +01:00
Raphael Defosseux 03d404a6ef Merge branch 'issue-399-master-ue-hot-fix' into 'master' 
Hot fix on UE configuration module

See merge request oai/openairinterface5g!506
 2019-02-14 13:14:39 +01:00
Louis Adrien Dufrene 0cc0485520 Merge branch 'ulsch_scheduler_opti' into 383-ulsch-scheduler-optimization 2019-02-14 10:32:30 +01:00
Raphael Defosseux 28a1fcde2e Adding comment in release notes 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-14 10:10:59 +01:00
Raphael Defosseux e85bd10307 CI: trying to improve reliability of L2 sim 
-- checking if oip1 interface has an IP address before pinging

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
(cherry picked from commit a4dd3fdb07)
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-13 16:47:27 +01:00
Boris Djalal 7c63d0d551 Proposal of Francois Taburet 
Signed-off-by: Boris Djalal <boris.djalal@eurecom.fr>
 2019-02-13 15:56:10 +01:00
Cedric Roux e4443b1810 x2: fix compilation 2019-02-13 15:42:29 +01:00
Cedric Roux 1c6b9f0eda Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	openair2/LAYER2/MAC/config.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.c
	openair2/RRC/LTE/rrc_defs.h
 2019-02-13 15:20:45 +01:00
Raphael Defosseux fcb16521f3 Hot fix on UE configuration module proposed by Xenofon Foukas 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-13 13:42:59 +01:00
Raphael Defosseux 4766a694c8 RHE7.6: UHD installation should be now correct 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-13 10:37:00 +01:00
Raphael Defosseux d035be0dd3 Fix for all other OS versions 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-13 10:04:40 +01:00
Louis Adrien Dufrene c7bce0f8d7 Merge from develop 2019-02-13 09:01:51 +01:00
Louis Adrien Dufrene ce87a9dc09 Merge from develop 2019-02-13 08:41:13 +01:00
Raymond Knopp b7cbb43130 minor change for UHD on RHEL7.6 2019-02-12 17:24:18 +01:00
Raphael Defosseux a4dd3fdb07 CI: trying to improve reliability of L2 sim 
-- checking if oip1 interface has an IP address before pinging

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-12 16:33:30 +01:00
Raphael Defosseux d97ba1e2fc CI: adding longer tempos for L2-nFAPI simulator 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-12 15:21:57 +01:00
Raphael Defosseux b88c1458a5 CI: my bad. Forgot to apply the suppression list to the variant used in Jenkins pipeline file 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-12 13:40:41 +01:00
frtabu 2fcc6333b3 Fix compil warnings after rebase 2019-02-12 10:32:57 +01:00
frtabu a50596af80 test for UE pucch and supression list update 2019-02-12 10:12:07 +01:00
frtabu 60defa245d more fixes for cppcheck 2019-02-12 10:12:07 +01:00
frtabu d0a3788ca8 re-apply fixes lost with last rebase 2019-02-12 10:12:07 +01:00
frtabu efe116abe5 rebase on develop (w04 - new master) 2019-02-12 10:12:07 +01:00