luaihui
e773fc6a71
modify some cppcheck errors and warnings
2019-07-15 11:58:19 +09:00
luaihui
e468376d93
add forwarding and end marker
2019-07-11 10:59:07 +09:00
Dong Anyuan
2f2f21d2aa
Fix Coverity Scan CID 339964 (Passing &rrc_eNB_mui to function rrc_eNB_process_S1AP_DOWNLINK_NAS which uses it as an array. This might corrupt or misinterpret adjacent memory locations.)
2019-06-20 14:06:04 +09:00
Dong Anyuan
cd31745af1
Fix Coverity Scan CID 340290 (Variable msg_p going out of scope leaks the storage it points to.)
2019-06-20 13:53:08 +09:00
Dong Anyuan
91dcaae357
Fix Coverity Scan CID 261623 (Variable msg_p going out of scope leaks the storage it points to.)
2019-06-20 11:11:41 +09:00
SAWADA Kentaro
a51fb55f8a
Fix Coverity Scan CID 339968
2019-05-28 19:10:16 +09:00
Raphael Defosseux
aceb3a83ea
Hack to break infinite loop when UE is released during RRC inactivity timeout
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2019-05-16 15:54:03 +02:00
Robert Schmidt
62d9b8cf36
Merge branch 'develop' into feature-127-protocol-split
2019-03-14 13:10:21 +01:00
Cedric Roux
c394188e73
x2: first implementation of ID management, some cleanup
...
Some deadcode was removed.
The implementation of the ID management is not finished.
It will only work if the handover is successful. No error
recovery has been done. For error recovery, we need to
implement the X2AP timers. As it is, in case of error, an ID
might very well never be released.
It has been tested with 1 and 2 UEs doing handover more or less
at the same time.
2019-03-05 14:56:42 +01:00
Konstantinos Alexandris
02193f4bab
x2: some cleanup in instance management
...
- manage target eNB based on target cell id received by measurement report
for Handover Request
- manage source eNB based on association id for Handover Request Ack
- use only x2ap instance and not x2ap data instance points to x2ap instance
2019-03-05 14:56:42 +01:00
Konstantinos Alexandris
52a52eefb9
X2AP UE Context Release (generate/handle message), Release eNB resources
2019-03-05 14:53:00 +01:00
Konstantinos Alexandris
4b5c42115d
bugfix: Path switch request ack (manage re-established/released E-RABs)
2019-03-05 14:46:21 +01:00
Konstantinos Alexandris
ca19953200
x2ap: bugfixes Store UE Capability at target, Key derivation (keNB star) at source
2019-03-05 14:22:40 +01:00
Robert Schmidt
f9c4c501e3
Merge branch 'develop' into feature-127-protocol-split
2019-03-05 14:17:38 +01:00
Raphael Defosseux
0f11865fa4
Merge remote-tracking branch 'origin/issue-404-pdcp-integrity' into develop_integration_2019_w09
...
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2019-02-28 14:37:10 +01:00
Cedric Roux
e3782b5ca2
bugfix: fix PDCP sequence management (plus some cleanup)
...
With the introduction of X2AP into develop, the UEs now have to regularly
send measurement reports.
In the logs of the eNB, we see:
[OSA] Mismatch found in integrity for algorithm 2,
got e0.a0.c2.66, expecting a5.9c.cb.57
[PDCP] [OSA][RB 1] eNB failed to validate MAC-I of incoming PDU
This is a bug in the PDCP layer that uses wrong parameters to compute the
integrity.
This commit fixes this bug.
The function pdcp_is_rx_seq_number_valid was removed. Its processing
has been directly integrated into the function pdcp_data_ind.
The function pdcp_mark_current_pdu_as_received is not called anymore.
Its processing was not used later on, so as of today, not calling it does
not introduce any functional change.
The function pdcp_validate_security takes now as parameters both
SN and HFN. Same for the function pdcp_get_next_count_rx.
Useless constants PDCP_SN_5BIT, PDCP_SN_7BIT and PDCP_SN_12BIT have been
removed.
The compilation option ENABLE_SECURITY has been removed. It's now always
on. (This may impact some use cases.)
The PDCP for DRB using RLC AM is not correct. It was not correct before
this commit (apart from the integrity bug). We should deal with a list
of PDUs and transmit packets to upper layers as detailed in the specs.
Today we transmit the PDU as soon as we get it. We don't care about
duplicates, in-order delivery, timeouts.
Also, we don't deal with "PDCP re-establishment". Not sure how that impacts
the software.
And, last but not least, there is still no ROHC.
2019-02-27 12:33:04 +01:00
frtabu
fb46545526
Fix corrupted LOGs in L1L2simulator, introducing two new components NFAPI_VNF and NFAPI_pnf. Integrate Fujitsu fix for up to 50 UEs. Apply astyle to all modified files in the branch
2019-02-25 16:50:03 +01:00
Robert Schmidt
030e11ba9a
Merge branch 'develop' into feature-127-protocol-split
2019-02-21 20:18:35 +01:00
frtabu
38d772d8a2
nos1 et s1 execs identical, nos1 enforced based on exec name or --noS1 option
2019-02-17 23:46:45 +01:00
Raphael Defosseux
341fedd468
Merge branch 'issue394_fix_cppcheck' into develop_integration_2019_w07_v2
...
--> openair2/LAYER2/MAC/eNB_scheduler_primitives.c is still old (not from issue394_fix_cppcheck branch)
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr >
2019-02-15 12:24:19 +01:00
Cedric Roux
1c6b9f0eda
Merge remote-tracking branch 'origin/develop' into x2
...
Conflicts:
openair2/LAYER2/MAC/config.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/rrc_defs.h
2019-02-13 15:20:45 +01:00
frtabu
60defa245d
more fixes for cppcheck
2019-02-12 10:12:07 +01:00
Robert Schmidt
d9d6ce374f
Perform S1 UE Context Release Complete after corresponding F1 message
...
This commits isolates the S1 UE Ctxt Rel Complete and GTP Tunnel Delete
Requests in functions and calls these function in the original place
(rrc_rx_tx()). The same functions are then used in the F1 UE Ctxt Rel
Complete handler to perform the same functionality, i.e. forward the UE
Ctxt Rel Complete message to the MME and free outstanding resources (RRC
context, GTP tunnels, S1 context).
2019-01-25 16:37:57 +01:00
Konstantinos Alexandris
83c414fc83
remove warnings (nb_e_rabs_tobeswitched not in use)
2019-01-21 16:34:52 +01:00
Cedric Roux
246abce5d1
Merge remote-tracking branch 'origin/develop' into x2
...
Conflicts:
openair2/ENB_APP/enb_config.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/MESSAGES/asn1_msg.h
openair2/RRC/LTE/rrc_defs.h
openair2/RRC/LTE/rrc_eNB.c
openair2/RRC/LTE/rrc_eNB_S1AP.c
openair2/RRC/LTE/rrc_proto.h
openair3/GTPV1-U/gtpv1u_eNB.c
openair3/S1AP/s1ap_eNB_handlers.c
2019-01-18 10:35:39 +01:00
Cedric Roux
aea6b4b5a6
fix a lot of file mode
...
For whatever reason most of the files had their permission
changed from 644 to 755, which is not wanted.
2019-01-07 16:22:28 +01:00
Raymond Knopp
44a225c6b7
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair1/PHY/LTE_TRANSPORT/dci_tools.c
openair1/SCHED/fapi_l1.c
openair1/SCHED/phy_procedures_lte_eNb.c
openair2/COMMON/rrc_messages_types.h
openair2/ENB_APP/enb_config.c
openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
openair2/LAYER2/MAC/eNB_scheduler_fairRR.c
openair2/LAYER2/MAC/eNB_scheduler_primitives.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/LAYER2/MAC/mac.h
openair2/RRC/LTE/L2_interface.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/MESSAGES/asn1_msg.h
openair2/RRC/LTE/rrc_eNB.c
openair2/RRC/LTE/rrc_eNB_S1AP.c
targets/RT/USER/lte-enb.c
2019-01-05 23:28:31 +01:00
Konstantinos Alexandris
ea105c39b1
X2AP MOBILITY PROCEDURES (X2AP HANDOVER REQUEST/REQUEST ACK)
...
S1AP PATH SWITCH REQUEST/REQUEST ACK/FAILURE
RRC MEASUREMENT REPORT
MINOR CHANGES IN MAC LAYER
2018-12-18 13:45:03 +01:00
Louis Adrien Dufrene
ed61d774f6
add test on ue_context
2018-11-21 17:03:52 +01:00
Raymond Knopp
6266d5c389
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair1/PHY/INIT/lte_init.c
openair1/PHY/LTE_TRANSPORT/dci.c
openair1/PHY/LTE_TRANSPORT/edci.c
openair1/PHY/LTE_TRANSPORT/prach.c
openair1/PHY/LTE_TRANSPORT/transport_eNB.h
openair1/SCHED/fapi_l1.c
openair1/SCHED/phy_procedures_lte_eNb.c
openair2/COMMON/rrc_messages_types.h
openair2/ENB_APP/enb_config.c
openair2/LAYER2/MAC/config.c
openair2/LAYER2/MAC/eNB_scheduler_RA.c
openair2/LAYER2/MAC/eNB_scheduler_bch.c
openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/LAYER2/MAC/mac.h
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/rrc_defs.h
openair2/RRC/LTE/rrc_eNB.c
openair2/RRC/LTE/rrc_eNB_S1AP.c
2018-11-19 00:43:49 +01:00
Louis Adrien Dufrene
700437f184
astyle applied
2018-11-16 08:49:28 +01:00
Louis Adrien Dufrene
9a080adec5
RRC inactivity timer: first commit to DRX_master
2018-11-13 14:20:16 +01:00
Louis Adrien Dufrene
961a70a04e
Fusion wasn't ok, needed some modifications
2018-11-13 11:20:14 +01:00
Louis Adrien Dufrene
a409614185
Merge develop done, conflicts resolved
2018-11-13 10:49:20 +01:00
Louis Adrien Dufrene
287010f82f
RRC timer: last format done. Timer reset in scheduling of DTCH (DL/UL). Commit to test.
2018-11-13 10:21:38 +01:00
Louis Adrien Dufrene
76e1636258
RRC timer reset in scheduler: format of some functions before first test
2018-11-12 17:38:19 +01:00
OAI-admin
d3f8f9d65b
End of bug fix: S1 id unknown after detach request for switch off in idle
2018-11-12 07:46:32 +01:00
Louis Adrien Dufrene
94bf32b0d4
Bug fix: S1 id unknown after Detach Request (need to test)
2018-11-08 08:31:23 +01:00
Robert Schmidt
397d2f4815
Merge commit 'develop' into feature-127-protocol-split
...
* remove a lot of white spaces
* many conflicts in enb_config.c
2018-11-07 16:07:59 +01:00
Raymond Knopp
b27ed63fa9
lte-softmodem compiles, many memory faults during configuration ...
2018-11-03 22:51:24 +01:00
OAI-admin
6ae27efac0
minor update in format, variable ctxt removed in rrc_eNB_free_UE()
2018-10-31 16:24:29 +01:00
Raymond Knopp
d24f521a5a
Merge remote-tracking branch 'origin/develop' into enhancement-ltem
...
Conflicts:
openair1/PHY/INIT/lte_init.c
openair1/PHY/LTE_ESTIMATION/lte_ul_channel_estimation.c
openair1/PHY/LTE_TRANSPORT/dci.c
openair1/PHY/LTE_TRANSPORT/dci_tools.c
openair1/PHY/LTE_TRANSPORT/dlsch_coding.c
openair1/PHY/LTE_TRANSPORT/edci.c
openair1/PHY/LTE_TRANSPORT/if4_tools.c
openair1/PHY/LTE_TRANSPORT/prach.c
openair1/PHY/LTE_TRANSPORT/print_stats.c
openair1/PHY/LTE_TRANSPORT/pucch.c
openair1/PHY/LTE_TRANSPORT/transport_eNB.h
openair1/PHY/LTE_TRANSPORT/ulsch_decoding.c
openair1/PHY/LTE_UE_TRANSPORT/transport_proto_ue.h
openair1/PHY/impl_defs_lte.h
openair1/SCHED/fapi_l1.c
openair1/SCHED/phy_procedures_lte_eNb.c
openair2/COMMON/rrc_messages_types.h
openair2/ENB_APP/enb_config.c
openair2/ENB_APP/enb_paramdef.h
openair2/LAYER2/MAC/config.c
openair2/LAYER2/MAC/defs.h
openair2/LAYER2/MAC/eNB_scheduler.c
openair2/LAYER2/MAC/eNB_scheduler_RA.c
openair2/LAYER2/MAC/eNB_scheduler_bch.c
openair2/LAYER2/MAC/eNB_scheduler_dlsch.c
openair2/LAYER2/MAC/eNB_scheduler_primitives.c
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
openair2/LAYER2/MAC/pre_processor.c
openair2/LAYER2/MAC/rar_tools.c
openair2/LAYER2/MAC/ue_procedures.c
openair2/PHY_INTERFACE/IF_Module.c
openair2/RRC/LITE/rrc_common.c
openair2/RRC/LTE/L2_interface_ue.c
openair2/RRC/LTE/MESSAGES/asn1_msg.c
openair2/RRC/LTE/rrc_eNB.c
targets/ARCH/USRP/USERSPACE/LIB/usrp_lib.cpp
targets/RT/USER/lte-enb.c
targets/RT/USER/lte-ru.c
2018-10-29 07:54:17 +01:00
Louis Adrien Dufrene
2966cdf1c0
Format rrc_eNB_send_S1AP_UE_CONTEXT_RELEASE_REQ()
2018-10-23 17:12:45 +02:00
Louis Adrien Dufrene
57a383e77c
Format rrc_eNB_process_S1AP_UE_CONTEXT_RELEASE_COMMAND() and rrc_eNB_free_UE()
2018-10-23 16:51:55 +02:00
Bi-Ruei, Chiu
f58ad3c39f
Add prefix LTE_ to LTE-RRC generated data types by ASN1C_PREFIX=LTE_
...
1. Modify all expressions using original LTE-RRC data types for new generated ones
2. Does not change any program logic
2018-10-17 15:46:12 +08:00
Navid Nikaein
403db5b544
Fix the issue in sending UE Initial Context Setup Response
2018-10-05 17:03:24 +02:00
Robert Schmidt
a4bc48a2f7
Fix in paging: iterate list of MCC/MNC/TAC
2018-09-28 11:46:11 +02:00
Robert Schmidt
81e70dfc25
NAS First REQ: Forward selected PLMN Identity
2018-09-28 11:46:06 +02:00
Robert Schmidt
514b8d833a
Use selectedPLMN_Identity IE to fill GUMMEI at NAS_FIRST_REQ
2018-09-28 11:45:56 +02:00
Navid Nikaein
374c1087a1
Add some comments
2018-09-25 11:36:36 +02:00