Cedric Roux
d262d152ec
rlc v2: implement SOstart/SOend in NACK reporting
...
The necessity of SOstart/SOend was understood after email exchanges with
David Breaux <davidbreaux67@gmail.com >.
See openair2/LAYER2/rlc_v2/tests/test46.h for some details.
Basically if we NACK without SOstart/SOend then the other end of the RLC
channel will consider all the bytes as NACKed and will have to resend them
all. If another status is then reported before all the bytes are sent,
and because we don't use SOstart/SOend this status will NACK all the bytes
again, then all the bytes are to be sent again. And the cycle repeats.
It will end with a max retx reached (which triggers RLF, Radio Link Failure).
The function put_bit in openair2/LAYER2/rlc_v2/rlc_pdu.c has been changed
too, maybe introducing some performance issues.
2020-12-03 16:17:24 +01:00
hardy
923c5f9d31
Merge remote-tracking branch 'origin/rlc-v2-tick' into integration_2020_wk49
2020-11-30 10:35:24 +01:00
hardy
279a721d23
Merge remote-tracking branch 'origin/remove_x2_gnb_hardcoding' into integration_2020_wk49
2020-11-30 10:34:52 +01:00
Cedric Roux
6f9fe2681c
rlc v2: add tick for UE
2020-11-26 11:53:22 +01:00
Cedric Roux
2c9d1b9d84
HACK: let the gNB compile again
...
This is messy, sorry. I don't have time to cleanup
cmake_targets/CMakeLists.txt.
2020-11-26 11:53:22 +01:00
Cedric Roux
25ab3a5ed3
rlc v2: change time keeping
...
RLC has timers. We need to keep track of time. We chose to not use
realtime but 'processing time'. That is we send a tick to RLC for every
subframe when it is processed by the softmodem. Before this commit we
used to increase time in the function mac_rlc_status_ind which may not be
called every subframe (especially in TDD mode). So we need another way
to keep track of time.
We introduce rlc_tick() and call it in eNB_dlsch_ulsch_scheduler, which
is called every subframe, both in FDD and TDD.
We also call rlc_tick() in the function ru_thread_synch() because
pdcp_run() and rrc_rx_tx() are called there too.
It may not be the best solution. To be revised if needed.
Note: the UE has not been touched. Some modification is needed for the UE
too, most probably.
2020-11-26 11:53:22 +01:00
hardy
b16d7b2eed
Merge remote-tracking branch 'origin/NR_mac_uci_functions_rework' into integration_2020_wk48_2
2020-11-25 18:15:43 +01:00
hardy
2855970763
Merge remote-tracking branch 'origin/NR_UE_stability_fixes' into integration_2020_wk48_2
2020-11-25 12:25:45 +01:00
hardy
40085ad064
Merge remote-tracking branch 'origin/nr_dl_ul_ptrs' into integration_2020_wk48_2
2020-11-25 12:23:55 +01:00
Shweta Shrivastava
e8b7dc8454
Fix error
2020-11-24 15:23:34 -06:00
Shweta Shrivastava
17b8ff50f8
Minor edits for consistency and clarity
2020-11-24 14:53:08 -06:00
Thomas Schlichter
6803e78ceb
Merge remote-tracking branch 'develop'
...
Conflicts:
openair1/PHY/NR_TRANSPORT/nr_dlsch.c
openair1/PHY/NR_UE_ESTIMATION/nr_dl_channel_estimation.c
openair1/PHY/NR_UE_TRANSPORT/nr_dlsch_demodulation.c
openair1/SCHED_NR_UE/phy_procedures_nr_ue.c
openair2/RRC/NR/nr_rrc_proto.h
2020-11-24 16:58:58 +01:00
hardy
25391056c4
Merge remote-tracking branch 'origin/bugfix-nr-rate-matching-assertion' into integration_2020_wk48_2
2020-11-24 15:28:03 +01:00
hardy
11eeafd328
Merge remote-tracking branch 'origin/repair-TA' into integration_2020_wk48_2
2020-11-24 15:27:21 +01:00
Shweta Shrivastava
06f55552fe
Fix small error
2020-11-24 01:04:46 -06:00
Shweta Shrivastava
683ff6eb39
DCI sanity checks for MCS and frequency domain assignment
2020-11-24 00:53:25 -06:00
Shweta Shrivastava
9ff55751ee
DCI sanity check for pucch_resource_indicator value
2020-11-24 00:42:14 -06:00
Sakthivel Velumani
0aa14f183e
Editing an error message
2020-11-20 13:39:54 +01:00
Francesco Mani
82c4380a4e
uci mac functions in a new file
2020-11-20 10:22:10 +01:00
Robert Schmidt
d116c60831
Improve DLSCH MAC scheduling logging
2020-11-20 09:54:38 +01:00
Robert Schmidt
e6bb685b5d
re-enable TA
2020-11-20 09:54:34 +01:00
Robert Schmidt
bc088c975b
Account for OH in preprocessor
2020-11-20 09:54:34 +01:00
Robert Schmidt
d89716541f
Fix: Always place padding subPDU if space permits
2020-11-20 09:54:37 +01:00
Robert Schmidt
d245f7b958
Fix: Use DL-SCH long subheader when L >= 256
2020-11-20 09:54:34 +01:00
Robert Schmidt
3ff26c8f84
Fix: Reset HARQ feedback slot
...
If we schedule in a second slot, this ensures that the correct HARQ
process' NDI is toggled.
2020-11-20 09:52:42 +01:00
Thomas Schlichter
291c94d34c
Merge remote-tracking branch 'origin/nr_ue_tti_cleanup' into integration_2020_wk48
...
Conflicts:
openair1/PHY/NR_UE_TRANSPORT/dci_nr.c
openair1/PHY/NR_UE_TRANSPORT/nr_transport_proto_ue.h
openair1/SCHED_NR_UE/phy_procedures_nr_ue.c
2020-11-19 18:42:30 +01:00
hardy
4c3ee5f0e0
Merge remote-tracking branch 'origin/fix-itti-segv' into integration_2020_wk48
2020-11-19 14:59:39 +01:00
hardy
b57ef17b1c
Merge remote-tracking branch 'origin/bch-fixes-bitmap' into integration_2020_wk48
2020-11-19 14:58:02 +01:00
hardy
a0d58f224c
Merge remote-tracking branch 'origin/NR_SA_NGAP_RRC_wk42' into integration_2020_wk48
2020-11-19 14:57:08 +01:00
Thomas Schlichter
f41502cd19
fix compile warnings introduced by merge with develop
2020-11-18 10:38:15 +01:00
Thomas Schlichter
e059eeabc8
Merge remote-tracking branch 'develop'
2020-11-18 10:37:20 +01:00
Laurent
a592d0eb6f
fix warnings
2020-11-18 08:53:02 +01:00
hardy
fcd00c2af0
Merge remote-tracking branch 'origin/hotfix-nr-rlc-tick' into integration_2020_wk47
2020-11-17 13:53:44 +01:00
hardy
9d58ead40f
Merge remote-tracking branch 'origin/nr-rlc-am-bugfix-w44' into integration_2020_wk47
2020-11-17 13:51:46 +01:00
matzakos
0a60085d87
Increase size of array storing PDCP PDU to be aligned with the expected size
2020-11-16 15:19:39 +01:00
Parminder Singh
6c2fbb361d
Merge remote-tracking branch 'origin/develop' into fhg_shp_phase_noise_est
2020-11-16 09:47:46 +01:00
Thomas Schlichter
47ce347d7e
NR UE cleanup: remove current_thread_id array, nr_tti_rx, nr_tti_tx, subframe_rx and subframe_tx
2020-11-13 17:29:02 +01:00
hardy
63277ad3de
Merge remote-tracking branch 'origin/mac-fixes-wk45_2' into integration_2020_wk46_2
2020-11-13 13:26:15 +01:00
hardy
4b3a67b3a7
Merge remote-tracking branch 'origin/benetel_phase_rotation' into integration_2020_wk46_2
2020-11-13 13:21:42 +01:00
Parminder Singh
4fe5986845
Corrected conditional statement wrt OAI Formatting Rules
2020-11-12 19:29:10 +01:00
Robert Schmidt
65c7ab092a
Correct use of ssb_position bitmaps
2020-11-12 10:45:13 +01:00
hardy
e7b2c47348
Merge remote-tracking branch 'origin/nr_fdd_if_fix' into integration_2020_wk46
2020-11-12 09:27:00 +01:00
Robert Schmidt
fe6f7244df
Fix compiler warning: %ld in printf
2020-11-11 16:48:53 +01:00
Robert Schmidt
308de3b68d
Lower PHY/HARQ log level
2020-11-11 16:48:40 +01:00
Robert Schmidt
67d6311143
Hotfix: disable TA to keep RTT low + HARQ retx intact
2020-11-11 16:47:18 +01:00
Robert Schmidt
434186fd9f
Correct TA timer condition
...
- wrap around 1024 (frame number is 0-1023)
- check for equality of frames with high numbers will trigger every 10ms
2020-11-11 16:45:54 +01:00
Thomas Schlichter
f2502eebab
fix some compile warnings
2020-11-10 21:10:55 +01:00
hardy
e9fff748c6
Merge remote-tracking branch 'origin/NR_UE_MAC_scheduler' into integration_2020_wk46
2020-11-10 17:23:36 +01:00
cig
122e18d088
Common function to check the frequency channel raster
2020-11-10 10:52:44 +01:00
Parminder Singh
841ddaf9f8
Corrected data type for printf to remove warning in nr-softmodem
...
- In gNB_scheduler int is updated to long int to avoid warnings for
printf
2020-11-10 10:50:27 +01:00