maki/openairinterface5g
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,625 Commits 5 Branches 0 Tags
e3782b5ca2f02569bdfdedc5dd5e4a598495fa11
Commit Graph
1444 Commits
Author SHA1 Message Date
Cedric Roux e3782b5ca2 bugfix: fix PDCP sequence management (plus some cleanup) 
With the introduction of X2AP into develop, the UEs now have to regularly
send measurement reports.

In the logs of the eNB, we see:

[OSA]   Mismatch found in integrity for algorithm 2,
        got e0.a0.c2.66, expecting a5.9c.cb.57
[PDCP]   [OSA][RB 1] eNB failed to validate MAC-I of incoming PDU

This is a bug in the PDCP layer that uses wrong parameters to compute the
integrity.

This commit fixes this bug.

The function pdcp_is_rx_seq_number_valid was removed. Its processing
has been directly integrated into the function pdcp_data_ind.

The function pdcp_mark_current_pdu_as_received is not called anymore.
Its processing was not used later on, so as of today, not calling it does
not introduce any functional change.

The function pdcp_validate_security takes now as parameters both
SN and HFN. Same for the function pdcp_get_next_count_rx.

Useless constants PDCP_SN_5BIT, PDCP_SN_7BIT and PDCP_SN_12BIT have been
removed.

The compilation option ENABLE_SECURITY has been removed. It's now always
on. (This may impact some use cases.)

The PDCP for DRB using RLC AM is not correct. It was not correct before
this commit (apart from the integrity bug). We should deal with a list
of PDUs and transmit packets to upper layers as detailed in the specs.
Today we transmit the PDU as soon as we get it. We don't care about
duplicates, in-order delivery, timeouts.

Also, we don't deal with "PDCP re-establishment". Not sure how that impacts
the software.

And, last but not least, there is still no ROHC.
 2019-02-27 12:33:04 +01:00
Louis Adrien Dufrene db51a61c2e Fix to remove cppcheck warnings 2019-02-19 07:56:32 +01:00
Louis Adrien Dufrene f8ab4080f7 Merge from develop + modification of a X2AP file for code to compile 2019-02-18 10:46:13 +01:00
Raphael Defosseux d14ad6797e Applying the cppcheck fix on last files 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 19:18:24 +01:00
Raphael Defosseux 341fedd468 Merge branch 'issue394_fix_cppcheck' into develop_integration_2019_w07_v2 
--> openair2/LAYER2/MAC/eNB_scheduler_primitives.c is still old (not from issue394_fix_cppcheck branch)

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 12:24:19 +01:00
Raphael Defosseux ee3b650904 Compilation fix 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 10:40:06 +01:00
Raphael Defosseux 4cdae9d93d Merge remote-tracking branch 'origin/x2' into develop_integration_2019_w07_v2 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-02-15 09:54:44 +01:00
Cedric Roux 1c6b9f0eda Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	openair2/LAYER2/MAC/config.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.c
	openair2/RRC/LTE/rrc_defs.h
 2019-02-13 15:20:45 +01:00
Louis Adrien Dufrene c7bce0f8d7 Merge from develop 2019-02-13 09:01:51 +01:00
Louis Adrien Dufrene ce87a9dc09 Merge from develop 2019-02-13 08:41:13 +01:00
frtabu 2fcc6333b3 Fix compil warnings after rebase 2019-02-12 10:32:57 +01:00
frtabu 60defa245d more fixes for cppcheck 2019-02-12 10:12:07 +01:00
frtabu d0a3788ca8 re-apply fixes lost with last rebase 2019-02-12 10:12:07 +01:00
frtabu 824d2b478a new set of cppcheck fixes 2019-02-12 10:12:07 +01:00
frtabu 875bdaf282 cppcheck fixes (2) 2019-02-12 09:46:02 +01:00
frtabu 501ae74cb5 first set of cppcheck fixes 2019-02-12 09:46:02 +01:00
Raymond Knopp e704e7ccc0 Merge remote-tracking branch 'origin/develop' into enhancement-ltem 2019-02-07 23:58:17 +01:00
Cedric Roux be68e1e651 Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	common/utils/msc/msc.h
	openair2/X2AP/x2ap_eNB.c
 2019-02-01 14:27:55 +01:00
Stefan 0eb430c508 forme eNB_scheduler_primitives < 5500 2019-01-28 16:02:13 +01:00
Stefan b5fb496882 forme eNB_scheduler_primitives < 3900 2019-01-25 17:17:30 +01:00
Stefan d0b5dfa484 forme eNB_scheduler_primitives < 3000 2019-01-25 11:26:45 +01:00
Stefan 0a7e800077 forme eNB_scheduler_primitives < 2000 2019-01-24 16:26:21 +01:00
Konstantinos Alexandris 6f0267c4fa x2: fix UE measurement report 2019-01-24 15:55:26 +01:00
Raphael Defosseux 64144a8442 Merge remote-tracking branch 'origin/issue391-removeunusedcode_L2L1task' into develop_integration_2019_w04 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-24 15:33:19 +01:00
Stefan 169ba6011e forme eNB_scheduler_primitives < 1000 2019-01-24 11:19:13 +01:00
Stefan 1074a2cdc7 forme eNB_scheduler_dlsch 2019-01-23 16:22:55 +01:00
Louis Adrien Dufrene f0eaad5c1c Merge from develop 2019-01-23 14:15:21 +01:00
OAI-admin 1c26da5ad5 Some corrections: commit test is ok! 2019-01-23 13:56:43 +01:00
Louis Adrien Dufrene aac0a56116 Merge from develop 2019-01-23 13:27:56 +01:00
Stefan 2a8e7f3f6f modif fill_nfapi_uci_acknaks 2019-01-23 11:56:31 +01:00
Stefan 485e83f9e6 modif scheduler_dlsch + primitives 2019-01-23 08:50:59 +01:00
Raphael Defosseux 8260607ed6 CI: fix in L2-simulator VM build start script 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-22 21:37:40 +01:00
frtabu 9d0c70c9fe remove L1L2 task, also remove some call to send messages to UNKNOWN_TASK, removed in new itti. Align LOG in rlc sources with new LOG code (remove DEBUG_RLC...) 2019-01-21 19:43:19 +01:00
Louis Adrien Dufrene a36510d304 Merge branch 'develop' into dlsch_scheduler_opti 2019-01-21 08:54:49 +01:00
Raymond Knopp f84e52bad5 replaced AssertFatal with LOG_E and RA procedure cancellation 2019-01-20 15:39:58 +01:00
Raymond Knopp b2748da3c9 removal of warnings and excessive logging 2019-01-20 13:18:49 +01:00
Raymond Knopp f3a79f4be5 Merge remote-tracking branch 'origin/develop' into enhancement-ltem 2019-01-19 16:07:34 +01:00
haswell 023b6ebc29 testing LTE-M configuration 2019-01-19 16:02:59 +01:00
Stefan 151873e987 pre_processor improvements 2019-01-18 17:04:57 +01:00
Cedric Roux 7d481c5734 Merge remote-tracking branch 'origin/develop' into x2 2019-01-18 10:40:01 +01:00
Cedric Roux 246abce5d1 Merge remote-tracking branch 'origin/develop' into x2 
Conflicts:
	openair2/ENB_APP/enb_config.c
	openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.c
	openair2/RRC/LTE/MESSAGES/asn1_msg.h
	openair2/RRC/LTE/rrc_defs.h
	openair2/RRC/LTE/rrc_eNB.c
	openair2/RRC/LTE/rrc_eNB_S1AP.c
	openair2/RRC/LTE/rrc_proto.h
	openair3/GTPV1-U/gtpv1u_eNB.c
	openair3/S1AP/s1ap_eNB_handlers.c
 2019-01-18 10:35:39 +01:00
Raphael Defosseux d0190899d2 Try out to comment added lines 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-17 23:09:10 +01:00
Raphael Defosseux 4075fbc86a Merge remote-tracking branch 'origin/develop' into issue_345_l2_fapi_simulator_new_jan2019 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-17 18:19:46 +01:00
Raphael Defosseux c5f17fa7fd Merge remote-tracking branch 'origin/ue-hotfix-UEmode-during-initial-connection' into develop_integration_2019_w03 2019-01-17 11:54:05 +01:00
Louis Adrien Dufrene f034b6933f unused variable added in the commented bloc, remove build warnings 2019-01-16 11:54:50 +01:00
Raphael Defosseux d73685933c Merge remote-tracking branch 'origin/develop' into issue_345_l2_fapi_simulator_new 
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
 2019-01-16 11:21:27 +01:00
Louis Adrien Dufrene 0aff104545 Debug removed and first fix added for false RA caused by UL scheduling on PRACH resources 2019-01-16 08:58:53 +01:00
Raymond Knopp cae1ed0b11 changed some AssertFatal into LOG_E + return(-1) 2019-01-15 21:31:29 +01:00
Stefan c638d16a04 pre_processor improvements 2019-01-15 17:59:40 +01:00
Stefan d5841cbe9e Merge branch 'ulsch_scheduler_opti' of https://gitlab.forge.orange-labs.fr/afyf6286/oai-orange into ulsch_scheduler_opti 2019-01-15 09:00:45 +01:00